Commit graph

1873 commits

Author SHA1 Message Date
Marc Alexander
d9358c26da [ticket/11997] Add clean_url() method to path_helper
This method will get rid of unnecessary . and .. in URLs.

PHPBB3-11997
2013-12-21 20:08:00 +01:00
Cesar G
cd98dba0b9 [ticket/12079] Add default value to $multibyte in request.untrimmed_variable().
PHPBB3-12079
2013-12-19 19:09:40 -08:00
Joas Schilling
725c512468 [ticket/11849] Replace pagination in viewforum.php with class
PHPBB3-11849
2013-12-18 18:35:16 +01:00
Joas Schilling
268afe20f4 [ticket/11849] Move pagination code to class
PHPBB3-11849
2013-12-18 18:34:13 +01:00
Joas Schilling
4a73ce0933 Merge remote-tracking branch 'prototech/ticket/12009' into develop
* prototech/ticket/12009:
  [ticket/12009] Prevent user from enabling invalid extension through direct URL
  [ticket/12009] Update functional test to check for invalid extensions.
  [ticket/12009] Fix functional tests.
  [ticket/12009] Move valid extensions in tests to correct dir structure.
  [ticket/12009] Do not allow incorrectly structured extensions to be installed.
2013-12-16 10:18:56 +01:00
Cesar G
c42bd28d17 [ticket/12009] Prevent user from enabling invalid extension through direct URL
PHPBB3-12009
2013-12-12 14:40:03 -08:00
Joas Schilling
4816446c4a Merge remote-tracking branch 'Marc/ticket/11859' into develop
* Marc/ticket/11859:
  [ticket/11859] Add missing get_template_name method to test drivers
  [ticket/11859] Make avatar drivers return template filename
2013-12-12 10:21:36 +01:00
Cesar G
4d65727acc [ticket/12009] Do not allow incorrectly structured extensions to be installed.
PHPBB3-12009
2013-12-11 23:11:52 -08:00
Marc Alexander
47ea6bc9e6 Merge branch 'develop' of https://github.com/phpbb/phpbb into ticket/11997
Conflicts:
	tests/functional/fixtures/ext/foo/bar/config/services.yml
2013-12-07 13:32:19 +01:00
Marc Alexander
8bbede4251 [ticket/11997] Add method for controller redirect URLs to path helper
This method will allow us to get proper redirect URLs for controllers.

PHPBB3-11997
2013-12-07 13:23:57 +01:00
Marc Alexander
53be0a4432 [ticket/12058] Add missing apostrophe to avatar_types migration queries
PHPBB3-12058
2013-12-04 23:40:38 +01:00
Nathan Guse
1d243b78bb Merge pull request #1813 from marc1706/ticket/11912
[ticket/11912] Add mimetype guesser for proper mimetype guessing
2013-12-04 14:12:25 -08:00
Joas Schilling
86e629e533 [ticket/12039] Remove debug code
PHPBB3-12039
2013-12-02 13:26:49 +01:00
Marc Alexander
6618f0ea24 [ticket/11859] Make avatar drivers return template filename
The service name might not follow the expected naming scheme which would
cause abnormally long filenames and confusion for authors that might add
more avatar drivers.

PHPBB3-11859
2013-11-27 15:18:42 +01:00
Joas Schilling
de727b80e2 [ticket/12039] Fix option descriptions
PHPBB3-12039
2013-11-27 15:16:40 +01:00
Marc Alexander
33f4d267ef Merge branch 'develop' of https://github.com/phpbb/phpbb3 into ticket/11842
Conflicts:
	phpBB/includes/acp/acp_groups.php
2013-11-27 14:55:24 +01:00
Joas Schilling
e6749261f1 [ticket/12039] Use an abstract class and some more minor adjustments
PHPBB3-12039
2013-11-27 14:16:34 +01:00
Joas Schilling
d5743f008d [ticket/12039] Add config:* to the command line interface tool
PHPBB3-12039
2013-11-26 18:11:54 +01:00
Marc Alexander
0d4bf3ff45 [ticket/11842] Use type map for updating avatar types in database
PHPBB3-11842
2013-11-25 13:12:08 +01:00
Marc Alexander
943ab555da Merge branch 'develop' of https://github.com/phpbb/phpbb3 into ticket/11912
Conflicts:
	phpBB/config/services.yml
2013-11-23 00:54:56 +01:00
Marc Alexander
e108418824 [ticket/11912] Check if content_guesser is supported with function_exists
PHPBB3-11912
2013-11-23 00:51:29 +01:00
Nathan Guse
df7fa8e499 Merge pull request #1854 from Pico88/ticket/12005
[ticket/12005] Remove code responsible for PM popup completely
2013-11-21 14:01:23 -08:00
Nathan Guse
20885ccb8c Merge pull request #1882 from prototech/ticket/11959
[ticket/11959] Trim the list of users from post notifications.
2013-11-21 13:27:52 -08:00
Cesar G
e3a28e5e2a [ticket/11959] Rename $extra_cnt to something more descriptive.
PHPBB3-11959
2013-11-21 13:18:28 -08:00
Cesar G
43f454a6c6 [ticket/11959] Use COMMA_SEPARATOR to join the user list.
PHPBB3-11959
2013-11-21 13:15:08 -08:00
Cesar G
bcf347420e [ticket/11959] Trim the list of users from post notifications.
PHPBB3-11959
2013-11-21 13:02:26 -08:00
Cesar G
44b6f45759 [ticket/11484] Display login box for users following email notification link.
The link used for the latest post now uses view=unread so redirecting the user
using the value for the e parameter is no longer necessary.

PHPBB3-11484
2013-11-21 08:11:17 -08:00
Marc Alexander
6db967bdd5 [ticket/11842] Add migration file for updating avatar type in database
PHPBB3-11842
2013-11-20 17:12:00 +01:00
Joas Schilling
7678186b09 [prep-release-3.1.0-a2] Add migration for 3.1.0-a2 2013-11-19 01:18:21 +01:00
Marc Alexander
23e2f920f5 [ticket/12018] Use path_helper for admin style CSS in sql report
The path to the admin style CSS is currently created with $phpbb_admin_path.
We should however use the path_helper to correctly link to this file in order
to have a correct link on pages like extensions

PHPBB3-12018
2013-11-14 15:55:04 +01:00
Marc Alexander
df6e03266f [ticket/11912] Remove obsolete "return null" in content_guesser
PHPBB3-11912
2013-11-14 15:12:42 +01:00
Cesar G
287c2550b8 [ticket/12008] Update the run time value for the prune notifications cron task
PHPBB3-12008
2013-11-14 01:05:58 -08:00
Cesar G
50896305fa [ticket/12008] The read_notification_last_gc config setting should be dynamic.
PHPBB3-12008
2013-11-14 01:05:53 -08:00
Nils Adermann
52845b22f2 Merge pull request #1815 from marc1706/ticket/11525
[ticket/11525] Only remove group or user prefix from given avatar data
2013-11-13 09:52:21 -08:00
Marc Alexander
13a4ceedb1 [ticket/11525] Use foreach instead of array_walk in method clean_row()
This approach is cleaner and probably even faster the previous ways that
included using array_walk() or array_map() and other helper functions
and methods.

PHPBB3-11525
2013-11-13 18:27:40 +01:00
Nils Adermann
e48b2c07eb Merge pull request #1871 from nickvergessen/ticket/12016
Ticket/12016 Event listeners should be services
2013-11-13 08:45:48 -08:00
Joas Schilling
d3f9a51709 [ticket/12016] Use a service provider for event listeners
This allows them to use dependency injection

PHPBB3-12016
2013-11-13 17:34:06 +01:00
Joas Schilling
0a7db81426 [ticket/11997] Fix redirects from inside controllers
The redirect url currently uses the web root path. However as we prepend the
full board url later, we need to remove the relative web root path and prepend
the normal root path again. Otherwise redirects from inside routes will not
work as intended.

PHPBB3-11997
2013-11-13 11:30:13 +01:00
Marc Alexander
e380eed78e [ticket/11912] Remove obsolete variable $mimetype from content_guesser
PHPBB3-11912
2013-11-12 00:35:52 +01:00
Nils Adermann
592c8b7566 Merge pull request #1849 from bantu/ticket/11998
[ticket/11998] Introduction of the phpBB Console
2013-11-11 15:02:03 -08:00
Marc Alexander
9d4893b047 [ticket/11912] Remove IN_PHPBB checks from mimetype guesser files
PHPBB3-11912
2013-11-11 21:29:11 +01:00
Marc Alexander
81caa35955 [ticket/11912] Remove obsolete $file_info from plupload
PHPBB3-11912
2013-11-11 21:24:44 +01:00
Marc Alexander
bef6a5a640 [ticket/11912] Introduce guesser priority to mimetype guessers
The mimetype guesser priority can now be set through the service definition.
Mimetypes will be guessed from the guesser with the highest priority to
the one with the lowest priority. Standard priority types have been added
to the service definition file. Any integer value can be used though.
Standard mimetype guessers that do not have the methods get_priority
and set_priority implemented, like the standard MimeTypeGuessers of symfony,
will have the default priority with the value of 0. Lower priority guessers
have values lower than 0 while high priority ones can be added with values
higher than 0.

PHPBB3-11912
2013-11-11 21:18:23 +01:00
Marc Alexander
b1719db47d [ticket/11912] Add extension_guesser for guessing mimetype by extension
The content_guesser now only guesses the mimetype with the function
mime_content_type() while the guessing by extension is done using the
extension_guesser.

PHPBB3-11912
2013-11-11 20:15:28 +01:00
Joas Schilling
cfb0a41030 Merge remote-tracking branch 'EXreaction/ticket/11943' into develop
* EXreaction/ticket/11943:
  [ticket/11943] New line at EOF for define_error.html
  [ticket/11943] Forgot template file for test
  [ticket/11943] Throw an exception if DEFINE is setup improperly
  [ticket/11943] Split fix_inline_variable_tokens into 3 steps
  [ticket/11943] Require stricter DEFINE statements for templates
  [ticket/11943] Do not quote the value when it is exactly true, false, or null
  [ticket/11943] Add test for DEFINE $VAR = false
2013-11-11 18:23:37 +01:00
Joas Schilling
aa84f7de04 [ticket/11525] Prefix id parameter with 'g' again when its a group avatar
PHPBB3-11525
2013-11-10 23:20:48 +01:00
Joas Schilling
47f2caff6b [ticket/11525] Fix doc blocks
PHPBB3-11525
2013-11-10 22:20:15 +01:00
Nathan Guse
2e5117a71e [ticket/11943] Throw an exception if DEFINE is setup improperly
PHPBB3-11943
2013-11-09 11:14:55 -06:00
Joas Schilling
31e60f0c8d [ticket/11949] Do not prepend leading backslash to cache class name
The container seems to prepend the leading \ itself, so we get an
InvalidArgumentException with message '"'\\phpbb\\cache\\driver\\file'" is
not a valid class name for the "cache.driver" service.'

PHPBB3-11949
2013-11-09 17:06:38 +01:00
Joas Schilling
7344024b10 Merge remote-tracking branch 'dhruv/ticket/12007' into develop
* dhruv/ticket/12007:
  [ticket/12007] Default last_result to 0 instead of false
2013-11-09 15:53:29 +01:00