Commit graph

3629 commits

Author SHA1 Message Date
Fyorl
61d74007a4 [ticket/10941] Minor typo fixes
Removed superfluous $user = null; that was left over from refactoring.

PHPBB3-10941
2012-07-09 14:08:19 +01:00
Fyorl
1bb64ab23e [ticket/10941] Changed assertTrue to assertEquals
PHPBB3-10941
2012-07-09 14:08:19 +01:00
Fyorl
19405a7f47 [ticket/10941] Now actually checks for the value of errors.
Uses phpbb_mock_lang to return the key used when setting errors to
allow that key to be checked for during tests rather than just checking
if any error was set.

PHPBB3-10941
2012-07-09 14:08:19 +01:00
Fyorl
943af957e6 [ticket/10941] Re-arranged dataProvidor methods to be near their callers
PHPBB3-10941
2012-07-09 14:08:19 +01:00
Fyorl
59a7b10f14 [ticket/10941] Added a comment explaining the incomplete test
PHPBB3-10941
2012-07-09 14:08:18 +01:00
Fyorl
f2bbbdaafa [ticket/10941] tearDown() now uses explicit file list
Instances of $it also renamed for clarity.

PHPBB3-10941
2012-07-09 14:08:18 +01:00
Fyorl
82ca2c8b08 [ticket/10941] Minor adjustments as per PR comments
Added some comments clarifying globals and lowercased fixture filenames

PHPBB3-10941
2012-07-09 14:08:18 +01:00
Fyorl
1233544c4a [ticket/10941] Marked broken test as incomplete
PHPBB3-10941
2012-07-09 14:08:18 +01:00
Fyorl
5693036bf9 [ticket/10941] Added functional tests for the fileupload class
NOTE: test_form_upload() is broken. Uploading files via Symfony fails to
retain $_FILES['fileupload']['type'] even if it set explicitely. This appears
to be a bug in Symfony. Since the current version of filespec::is_image()
relies on the mimetype, these tests will __fail__. filespec::is_image() has
been fixed in https://github.com/phpbb/phpbb3/pull/833 however.

PHPBB3-10941
2012-07-09 14:08:17 +01:00
Fyorl
dfef80f267 [ticket/10941] Unit tests for fileupload class added
PHPBB3-10941
2012-07-08 23:59:11 +01:00
Fyorl
fe4056c599 [ticket/10941] Finished filespec tests
PHPBB3-10941
2012-07-08 23:59:11 +01:00
Fyorl
d6bd8928b5 [ticket/10941] Minor adjustments as per PR comments
Switched from dirname(__FILE__) to just __DIR__.
Removed static definition from data provider methods.

PHPBB3-10941
2012-07-08 23:59:11 +01:00
Fyorl
33a13002af [ticket/10941] Unit tests for filespec class
PHPBB3-10941
2012-07-08 23:59:11 +01:00
Nils Adermann
9f0259c473 Merge remote-tracking branch 'github-bantu/ticket/10973' into develop
* github-bantu/ticket/10973:
  [ticket/10973] Drop all require_once for mocks. Use autoloading.
  [ticket/10973] Add autoloader for autoloading phpbb_mock_ in tests.

Conflicts:
	tests/bbcode/url_bbcode_test.php
	tests/text_processing/censor_text_test.php
2012-07-08 23:12:22 +02:00
Nils Adermann
527f02bb4b Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/10974] Rename tests/mock_user.php -> tests/mock/user.php

Conflicts:
	tests/bbcode/url_bbcode_test.php
2012-07-08 23:10:42 +02:00
Nils Adermann
088dbc0b54 Merge remote-tracking branch 'github-bantu/ticket/10974' into develop-olympus
* github-bantu/ticket/10974:
  [ticket/10974] Rename tests/mock_user.php -> tests/mock/user.php
2012-07-08 23:03:58 +02:00
Andreas Fischer
d3bbde69c4 [ticket/10973] Drop all require_once for mocks. Use autoloading.
PHPBB3-10973
2012-07-08 22:57:23 +02:00
Andreas Fischer
cde5411e8a [ticket/10974] Rename tests/mock_user.php -> tests/mock/user.php
PHPBB3-10974
2012-07-08 22:46:14 +02:00
Andreas Fischer
932428086e [ticket/10973] Add autoloader for autoloading phpbb_mock_ in tests.
PHPBB3-10973
2012-07-08 22:33:27 +02:00
Fyorl
d0cb5bb093 [ticket/10970] Added support for forms such as {FOO}bar.{EXT}
PHPBB3-10970
2012-07-08 20:41:22 +01:00
Fyorl
d589623906 [ticket/10970] Paths of the form {FOO}/a/{BAR}/b parsed correctly
A new method to handle this type of path was added and
compile_tag_include, compile_tag_include_php and
compile_tag_include_js were modified to use it appropriately.

Tests were added for these three macros also.

PHPBB3-10970
2012-07-08 20:41:00 +01:00
Oleg Pudeyev
b6a364b706 Merge PR #856 branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/10937] Update documentation to say which comment styles are removed.
  [ticket/10937] Comment removal functions: Restore backward compatibility
2012-07-07 16:43:30 -04:00
Oleg Pudeyev
a7da376004 Merge PR #856 branch 'prep-release-3.0.11' into develop-olympus
* prep-release-3.0.11:
  [ticket/10937] Update documentation to say which comment styles are removed.
  [ticket/10937] Comment removal functions: Restore backward compatibility
2012-07-07 16:43:28 -04:00
Joas Schilling
7988045bda [ticket/10950] Fix unit tests to reflect desired behaviour
See http://wiki.phpbb.com/Deleting_Private_Messages for further explanation.

PHPBB3-10950
2012-07-04 13:00:04 +02:00
Andreas Fischer
81d5327e44 [ticket/10937] Comment removal functions: Restore backward compatibility
PHPBB3-10937
2012-07-03 01:02:42 +02:00
Joas Schilling
ad9d650659 [ticket/10942] Fix up unit tests for sql_case()
PHPBB3-10942
2012-07-02 11:10:58 +02:00
Joas Schilling
0fd02035d8 [ticket/10942] Make unit tests for sql_case simpler
PHPBB3-10942
2012-06-30 13:02:50 +02:00
Joas Schilling
d30dc11f3e [ticket/10950] Add some first and simple unit tests for phpbb_delete_user_pms()
Todo: Add cases to in which the msg is also deleted.

PHPBB3-10950
2012-06-23 16:02:16 +02:00
Joas Schilling
089e5f5c79 [ticket/10942] Rename method sql_conditional() to sql_case()
PHPBB3-10942
2012-06-20 12:57:08 +02:00
Joas Schilling
4fbbbfcebb [ticket/10942] Fix function name on order_lower_test.php
PHPBB3-10942
2012-06-20 02:12:48 +02:00
Joas Schilling
8cea7b2a51 [ticket/10942] Add unit tests for sql_concatenate
PHPBB3-10942
2012-06-20 02:10:54 +02:00
Joas Schilling
dd0da6fffb [ticket/10942] Add unit tests for sql_conditional
PHPBB3-10942
2012-06-20 01:50:42 +02:00
Joas Schilling
72c3148cfe [feature/new-tz-handling] Add tests for get_timestamp_from_format()
PHPBB3-9558
2012-06-18 15:11:13 +02:00
Oleg Pudeyev
d8946e74de Merge PR #778 branch 'cyberalien/ticket/10800' into develop
* cyberalien/ticket/10800:
  [ticket/10800] Changing html to js for includejs tests
  [ticket/10800] Changing template paths in tests
2012-06-11 20:02:35 -04:00
Nils Adermann
f22c99ffdb Merge remote-tracking branch 'github-p/ticket/10882' into develop
* github-p/ticket/10882:
  [ticket/10882] Fix test name - oops.
  [ticket/10882] Add a test for including a nonexistent file.
  [ticket/10882] Add test for an ENDIF without IF.
  [ticket/10882] Add test for an invalid template tag.
2012-06-12 00:57:34 +02:00
Oleg Pudeyev
241033ae88 [ticket/10882] Fix test name - oops.
PHPBB3-10882
2012-06-11 18:50:05 -04:00
Nils Adermann
4ebcb5319e Merge remote-tracking branch 'github-p/ticket/10828' into develop-olympus
* github-p/ticket/10828:
  [ticket/10828] Connect to postgres database by default.
2012-06-12 00:44:59 +02:00
Nils Adermann
a0771b8814 Merge pull request #814 from p/ticket/10828
[ticket/10828] Connect to postgres database by default.
2012-06-11 15:42:26 -07:00
Nils Adermann
3852f78bb4 Merge pull request #796 from imkingdavid/ticket/10837
[ticket/10837] Removed tearDownAfterClass() from extension_controller_test.php
2012-06-11 14:30:33 -07:00
Andreas Fischer
72212077eb [ticket/10931] Also test get_bytes() and get_string() with false.
PHPBB3-10931
2012-06-11 15:46:03 +02:00
Andreas Fischer
cbff02db4f [ticket/10931] Make to_numeric function globally available.
PHPBB3-10931
2012-06-11 15:46:03 +02:00
Andreas Fischer
09fb9a9efe [ticket/10931] Make sure get_bytes() always returns either an int or a float.
PHPBB3-10931
2012-06-11 15:15:08 +02:00
Andreas Fischer
44287e57bf [ticket/10931] Use strict assertSame() instead of assertEquals().
PHPBB3-10931
2012-06-11 14:47:29 +02:00
Andreas Fischer
3872abd824 [ticket/10931] Also test for negative values.
PHPBB3-10931
2012-06-11 14:47:29 +02:00
Andreas Fischer
fb279c9677 [ticket/10931] Also test lower case units in test_get_bytes().
PHPBB3-10931
2012-06-11 14:31:09 +02:00
Andreas Fischer
80dfa53ee3 [ticket/10931] Correctly use GNU GPL version 2.
PHPBB3-10931
2012-06-11 14:24:30 +02:00
Andreas Fischer
5086366662 [ticket/10931] Make it clear that we are mocking the ini_get() function.
PHPBB3-10931
2012-06-11 14:23:09 +02:00
Andreas Fischer
afd6f86892 [ticket/10931] Unit tests for phpbb_php_ini class.
PHPBB3-10931
2012-06-11 13:22:11 +02:00
Nils Adermann
4a5004781a Merge branch 'develop-olympus' into develop
By Andreas Fischer
via Andreas Fischer (1) and Nils Adermann (1)
* develop-olympus:
  [ticket/10162] Increase maximum length of email address TLD from 6 to 63.
  [ticket/10162] Add test cases for top level domain names longer than 6 chars.
2012-05-31 15:30:05 +02:00
Andreas Fischer
de4dff8bb0 [ticket/10162] Add test cases for top level domain names longer than 6 chars.
PHPBB3-10162
2012-05-30 21:11:17 +02:00