Commit graph

19105 commits

Author SHA1 Message Date
David King
b1735e30bd Merge remote-tracking branch 'EXreaction/ticket/11372' into develop
# By Nathaniel Guse
# Via Nathaniel Guse
* EXreaction/ticket/11372:
  [ticket/11372] Migrator should only check if effectively installed if not
2013-02-28 11:17:23 -05:00
Nathan Guse
e5417ec123 Merge remote-tracking branch 'remotes/VSE/ticket/11103-VSEphpbb' into ticket/11103
# By Matt Friedman
# Via Matt Friedman
* remotes/VSE/ticket/11103-VSEphpbb:
  [ticket/11103] Remove padding from notifications for now.
  [ticket/11103] Add newlines to bottom of css file
  [ticket/11103] HTML encode double arrow character
  [ticket/11103] Update styling of UCP Notifications in subsilver2
  [ticket/11103] Update styling of UCP Notifications in prosilver
  [ticket/11103] Update styling of subsilver2 notification modal
  [ticket/11103] Update styling of prosilver notification modal
  [ticket/11103] Remove title attribute from notification link
2013-02-28 09:56:37 -06:00
Nathan Guse
f665a4b5cf Merge branch 'develop' of github.com:phpbb/phpbb3 into ticket/11103
# By Nathaniel Guse
# Via David King (2) and Nathaniel Guse (1)
* 'develop' of github.com:phpbb/phpbb3:
  [ticket/11370] Effectively installed migrations not inserted into table
  [ticket/11369] Reverting migration throws error
2013-02-28 09:52:23 -06:00
David King
0808e08c0b Merge remote-tracking branch 'EXreaction/ticket/11370' into develop
# By Nathaniel Guse
# Via Nathaniel Guse
* EXreaction/ticket/11370:
  [ticket/11370] Effectively installed migrations not inserted into table
2013-02-28 10:44:49 -05:00
David King
e20da8fb81 Merge remote-tracking branch 'EXreaction/ticket/11369' into develop
# By Nathaniel Guse
# Via Nathaniel Guse
* EXreaction/ticket/11369:
  [ticket/11369] Reverting migration throws error
2013-02-28 10:42:18 -05:00
Matt Friedman
18d85bfc11 [ticket/11103] Remove padding from notifications for now.
PHPBB3-11103
2013-02-27 20:18:41 -08:00
Joas Schilling
97a446f5b9 [ticket/10411] Update schema file with new table and remove the column
PHPBB3-10411
2013-02-27 22:00:15 +01:00
Joas Schilling
8bf04563bc [ticket/10411] Add unit tests for move() with values >1
PHPBB3-10411
2013-02-27 21:43:07 +01:00
Marc Alexander
96b1cabcf2 Merge branch 'develop' of https://github.com/phpbb/phpbb3 into ticket/11314 2013-02-27 21:40:02 +01:00
Nathaniel Guse
c3434dec40 [ticket/11363] Fix a couple bugs and throw errors if the file not found
PHPBB3-11363
2013-02-27 14:09:27 -06:00
Nathaniel Guse
9b554fbf3c [ticket/11372] Migrator should only check if effectively installed if not
installed at all

PHPBB3-11372
2013-02-27 13:52:45 -06:00
Joas Schilling
3362baca51 [ticket/10411] Add migrations file for teampage table
PHPBB3-10411
2013-02-27 19:27:30 +01:00
Nathaniel Guse
d296e809d5 [ticket/11363] Load module info files for extensions too
Use the acp_modules::get_module_infos function instead of our own include code

PHPBB3-11363
2013-02-27 11:12:18 -06:00
Joas Schilling
3cee183dd4 [ticket/9657] Break the schemas again to avoid merge conflicts
PHPBB3-9657
2013-02-27 12:51:34 +01:00
Joas Schilling
3495481b55 [ticket/9657] Revert database_update.php changes
We revert all database update changes here, so we can easily move to
migrations, without having a tones one conflicts. The changes will then be
added in it's own migration file.

PHPBB3-9657
2013-02-27 11:11:20 +01:00
Nathaniel Guse
c6aabab039 [ticket/11103] Notifications Migration file
PHPBB3-11103
2013-02-26 19:54:47 -06:00
Nathaniel Guse
51651b3d9f [ticket/11370] Effectively installed migrations not inserted into table
insert_migration() function now handles inserting/updating

Move all insert/update code to insert_migration() function to prevent this from occurring again.

PHPBB3-11370
2013-02-26 19:44:03 -06:00
Nathaniel Guse
f9cbf5b4c7 [ticket/11369] Reverting migration throws error
String is attempted to be unserialized

PHPBB3-11369
2013-02-26 19:25:51 -06:00
Joas Schilling
f76f36c669 Merge branch 'develop' of https://github.com/phpbb/phpbb3 into ticket/10411-2
* 'develop' of https://github.com/phpbb/phpbb3:
  [ticket/11367] Always freeresult
  [ticket/11367] Migrator throws error if migrations table does not exist
  [feature/migrations] Inject migrator rather than the container.
  [feature/migrations] Use the user class for language handling
  [feature/migrations] Fully revert the removal of the user_msnm field
  [feature/migrations] Revert unrelated change to schema_data.sql
  [feature/migrations] Remove user_msnm migration
  [feature/migrations] Correct depends_on
  [feature/migrations] Subdirectories for migration data
  [feature/migrations] Reports table schema changes in recent develop
  [feature/migrations] Automatically populate migrations table on install
  [feature/migrations] effectively installed check for migration data
  [feature/migrations] Comments for the return in the custom functions
  [feature/migrations] Order the migrations schema in schema_data.sql
  [feature/migrations] Fix migrations installer, schema for schema_data.sql
  [feature/migrations] Make depends_on static to call it without dependencies
  [feature/migrations] Remove hardcoded language, use lang instead.
  [feature/migrations] Revert schema for migration data
  [feature/migrations] Replace database_update.php with migrations updater
  [feature/migrations] Rebuilding migrations data on develop
2013-02-27 00:12:51 +01:00
Joas Schilling
d61eb95b48 [ticket/10411] Revert database_update.php changes from for easier update
Revert the changes from 8fc022033a
* [ticket/10411] Update schema and fix database update

The database changes will be added as a migration in the next step

PHPBB3-10411
2013-02-27 00:12:18 +01:00
Nathaniel Guse
a01da0c1ee Merge branch 'develop' of git://github.com/phpbb/phpbb3 into ticket/11103
Conflicts:
	phpBB/install/database_update.php
2013-02-26 15:32:27 -06:00
Andreas Fischer
5b2d272137 [ticket/11368] Fix background color for PM report rows by using accessing var.
PHPBB3-11368
2013-02-26 22:17:24 +01:00
David King
80bd78a5e5 Merge remote-tracking branch 'EXreaction/ticket/11367' into develop
# By Nathan Guse (1) and Nathaniel Guse (1)
# Via Nathan Guse
* EXreaction/ticket/11367:
  [ticket/11367] Always freeresult
  [ticket/11367] Migrator throws error if migrations table does not exist
2013-02-26 15:46:08 -05:00
Marc Alexander
1ebb17c698 [ticket/11323] Reduce additional code and revert regex to previous one
PHPBB3-11323
2013-02-26 21:43:39 +01:00
David King
82b20cc257 Merge remote-tracking branch 'EXreaction/feature/migrations-data' into develop
# By Nathan Guse (14) and Nathaniel Guse (4)
# Via Nathaniel Guse
* EXreaction/feature/migrations-data:
  [feature/migrations] Inject migrator rather than the container.
  [feature/migrations] Use the user class for language handling
  [feature/migrations] Fully revert the removal of the user_msnm field
  [feature/migrations] Revert unrelated change to schema_data.sql
  [feature/migrations] Remove user_msnm migration
  [feature/migrations] Correct depends_on
  [feature/migrations] Subdirectories for migration data
  [feature/migrations] Reports table schema changes in recent develop
  [feature/migrations] Automatically populate migrations table on install
  [feature/migrations] effectively installed check for migration data
  [feature/migrations] Comments for the return in the custom functions
  [feature/migrations] Order the migrations schema in schema_data.sql
  [feature/migrations] Fix migrations installer, schema for schema_data.sql
  [feature/migrations] Make depends_on static to call it without dependencies
  [feature/migrations] Remove hardcoded language, use lang instead.
  [feature/migrations] Revert schema for migration data
  [feature/migrations] Replace database_update.php with migrations updater
  [feature/migrations] Rebuilding migrations data on develop
2013-02-26 14:20:12 -05:00
Nathan Guse
9a319fefb2 [ticket/11367] Always freeresult
PHPBB3-11367
2013-02-26 10:22:13 -06:00
Joas Schilling
ba97303a60 [ticket/10411] Add maxlength to category name input field
PHPBB3-10411
2013-02-26 17:17:31 +01:00
Joas Schilling
1261583afa [ticket/10411] Test for thrown exceptions when group does not exist
PHPBB3-10411
2013-02-26 17:01:45 +01:00
Joas Schilling
9e70f7a4e0 [ticket/10411] Catch exceptions from grouppositions
PHPBB3-10411
2013-02-26 16:53:51 +01:00
Joas Schilling
e0df593448 [ticket/10411] Throw exceptions instead of using trigger_error()
PHPBB3-10411
2013-02-26 16:52:53 +01:00
Nathaniel Guse
6045aa7aa2 [ticket/11367] Migrator throws error if migrations table does not exist
Force load_migration_state to not throw errors if the table does not exist.

PHPBB3-11367
2013-02-25 19:16:29 -06:00
Joas Schilling
41eea66da9 [ticket/10411] Add return values to add/delete function
PHPBB3-10411
2013-02-25 21:24:52 +01:00
Joas Schilling
8c6a1e50f5 Merge branch 'develop' of https://github.com/phpbb/phpbb3 into ticket/10411-2
* 'develop' of https://github.com/phpbb/phpbb3: (497 commits)
  [ticket/10986] message.id fallback to SERVER_NAME or phpbb.generated
  [ticket/11358] Changed the name of post parameter.
  [ticket/11358] Changed the action parameter value to represent the link.
  [ticket/11358] Enabled link making all users default for a group.
  [ticket/11358] Removed redundant code and referred proper variable.
  [ticket/11358] Success message even without selecting a user.
  [ticket/11355] Referred proper variable when validating selection.
  [ticket/11355] Wrong error message when no user is selected.
  [ticket/10896] Add missing email validation lost in develop merge
  [ticket/7262] Add note about set_config() not updating is_dynamic.
  [ticket/7262] Add $is_dynamic example to set_config() and set_config_count().
  [ticket/7262] Backport set_config() and set_config_count() docs from develop.
  [ticket/11122] Move rxu to 'Former Contributors' section.
  [ticket/11122] Add EXreaction to docs/AUTHORS.
  [ticket/11298] Fix typo in language key; EXTENSIONS -> EXTENSION
  [ticket/11361] Make sure that array passed to strtr() has the proper format.
  [ticket/11342] Fix "unexpected token" syntax error
  [ticket/11179] remove extra & in function call
  [ticket/11179] correct start parameter in sphinx search
  [ticket/11179] correct start parameter in native author search
  ...

Conflicts:
	phpBB/config/services.yml
	phpBB/includes/functions_user.php
	phpBB/install/schemas/firebird_schema.sql
	phpBB/install/schemas/mssql_schema.sql
	phpBB/install/schemas/mysql_40_schema.sql
	phpBB/install/schemas/mysql_41_schema.sql
	phpBB/install/schemas/oracle_schema.sql
	phpBB/install/schemas/postgres_schema.sql
	phpBB/install/schemas/sqlite_schema.sql
2013-02-25 21:03:34 +01:00
Joas Schilling
1d7b082a6f [ticket/10411] Add return value to move functions
PHPBB3-10411
2013-02-25 20:58:12 +01:00
Joas Schilling
b0dc5925b9 [ticket/10411] Fix typehinting and change private to protected
PHPBB3-10411
2013-02-25 20:29:04 +01:00
Joas Schilling
9ea48dbd45 [ticket/10411] Use template loops instead of defining the html in php files
PHPBB3-10411
2013-02-25 20:24:11 +01:00
Nathaniel Guse
9b38c4579e Merge remote-tracking branch 'remotes/marc/ticket/11342' into develop
# By Marc Alexander
# Via Marc Alexander
* remotes/marc/ticket/11342:
  [ticket/11342] Fix "unexpected token" syntax error
  [ticket/11342] Mark active topics read when marking forums read
2013-02-25 13:17:27 -06:00
Nathaniel Guse
e632049e19 Merge branch 'feature/migrations-data' of github.com:EXreaction/phpbb3 into feature/migrations-data
# By Dhruv (19) and others
# Via Nathaniel Guse (3) and others
* 'feature/migrations-data' of github.com:EXreaction/phpbb3: (38 commits)
  [feature/migrations] Use the user class for language handling
  [feature/migrations] Fully revert the removal of the user_msnm field
  [feature/migrations] Revert unrelated change to schema_data.sql
  [ticket/11179] remove extra & in function call
  [ticket/11179] correct start parameter in sphinx search
  [ticket/11179] correct start parameter in native author search
  [ticket/11179] correct start parameter in native keyword search
  [ticket/11179] fix success query path for postgres
  [ticket/11179] fix success query path for mysql
  [ticket/11179] minor fixes
  [ticket/11179] pass start param by reference in postgres
  [ticket/11179] correct start param in author search of postgres
  [ticket/11179] correct start parameter in psql keyword search
  [ticket/11179] pass start param by reference in author search
  [ticket/11179] correct start parameter for author search
  [ticket/11179] use FOUND_ROWS query to re-search with changed start param
  [ticket/11179] pass start parameter by reference
  [ticket/11179] correct the start parameter while retrieving from cache
  [ticket/11179] add search query in case initial one fails
  [ticket/11359] html escape sphinx config data
  ...
2013-02-25 13:12:57 -06:00
Nathaniel Guse
7a8ae49300 [feature/migrations] Inject migrator rather than the container.
Some docblocks

PHBB3-9737
2013-02-25 13:12:32 -06:00
Joas Schilling
12cc64e715 [ticket/10411] Ensure we only get services that do exist
PHPBB3-10411
2013-02-25 19:01:35 +01:00
Joas Schilling
c2974187e5 Merge branch 'develop' of https://github.com/phpbb/phpbb3 into ticket/10714
* 'develop' of https://github.com/phpbb/phpbb3: (119 commits)
  [ticket/10986] message.id fallback to SERVER_NAME or phpbb.generated
  [ticket/11358] Changed the name of post parameter.
  [ticket/11358] Changed the action parameter value to represent the link.
  [ticket/11358] Enabled link making all users default for a group.
  [ticket/11358] Removed redundant code and referred proper variable.
  [ticket/11358] Success message even without selecting a user.
  [ticket/11355] Referred proper variable when validating selection.
  [ticket/11355] Wrong error message when no user is selected.
  [ticket/10896] Add missing email validation lost in develop merge
  [ticket/7262] Add note about set_config() not updating is_dynamic.
  [ticket/7262] Add $is_dynamic example to set_config() and set_config_count().
  [ticket/7262] Backport set_config() and set_config_count() docs from develop.
  [ticket/11122] Move rxu to 'Former Contributors' section.
  [ticket/11122] Add EXreaction to docs/AUTHORS.
  [ticket/11298] Fix typo in language key; EXTENSIONS -> EXTENSION
  [ticket/11361] Make sure that array passed to strtr() has the proper format.
  [ticket/11179] remove extra & in function call
  [ticket/11179] correct start parameter in sphinx search
  [ticket/11179] correct start parameter in native author search
  [ticket/11179] correct start parameter in native keyword search
  ...

Conflicts:
	phpBB/config/tables.yml
2013-02-25 16:04:22 +01:00
Joas Schilling
c1b4cdb188 [ticket/10714] Update add_log docs block with @param and @deprecated
PHPBB3-10714
2013-02-25 15:57:21 +01:00
Andreas Fischer
558ecdcd40 Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/10986] message.id fallback to SERVER_NAME or phpbb.generated
2013-02-24 20:55:01 +01:00
Andreas Fischer
8586ce8906 Merge remote-tracking branch 'naderman/ticket/10986' into develop-olympus
* naderman/ticket/10986:
  [ticket/10986] message.id fallback to SERVER_NAME or phpbb.generated
2013-02-24 20:54:46 +01:00
Nils Adermann
4615698807 [ticket/10986] message.id fallback to SERVER_NAME or phpbb.generated
Rather than send invalid message ids with a missing domain part we try
to read one from $_SERVER and otherwise use phpbb.generated

PHPBB3-10986
2013-02-24 19:07:24 +01:00
Nils Adermann
465ab7ab92 Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/11358] Changed the name of post parameter.
  [ticket/11358] Changed the action parameter value to represent the link.
  [ticket/11358] Enabled link making all users default for a group.
  [ticket/11358] Removed redundant code and referred proper variable.
  [ticket/11358] Success message even without selecting a user.
2013-02-24 18:17:42 +01:00
Nils Adermann
fe219e4bbe Merge branch 'ticket/11358' into develop-olympus
* ticket/11358:
  [ticket/11358] Changed the name of post parameter.
  [ticket/11358] Changed the action parameter value to represent the link.
  [ticket/11358] Enabled link making all users default for a group.
  [ticket/11358] Removed redundant code and referred proper variable.
  [ticket/11358] Success message even without selecting a user.
2013-02-24 18:17:32 +01:00
erangamapa
1b39d6d65e [ticket/11358] Changed the name of post parameter.
Replaced the parameter name 'defaultbylink' to a meaningful name
'set_default_on_all'. Parameter is used for making all users
default for selected group in acp_groups.php.

PHPBB3-11358
2013-02-24 18:12:50 +01:00
erangamapa
c0a39537e3 [ticket/11358] Changed the action parameter value to represent the link.
Changed the action parameter value to recognize whether 'Make default
group for every member' is clicked. If so execute a seperate code block
under switch statement for $action and add all the users as default
for the group.

PHPBB3-11358
2013-02-24 18:12:45 +01:00
erangamapa
538b09ba61 [ticket/11358] Enabled link making all users default for a group.
Detect whether link is clicked or form is posted for making users
default for a group. If form is posted and no users are selected,
validation happens and displays an error message. When the link is
clicked, all the users will be default users for that group.

PHPBB3-11358
2013-02-24 18:12:40 +01:00