David King
3004350281
[feature/controller] Correctly create Symfony object from globals
...
PHPBB3-10864
2012-11-19 11:47:42 -05:00
Joas Schilling
a7404409a8
[ticket/11219] Add unit test for inserting into a sequence column
...
PHPBB3-11219
2012-11-19 14:27:26 +01:00
Patrick Webster
41a95d2c64
[ticket/11219] Update sequence values after loading fixtures
...
If a value is provide for an auto_increment type of column, certain DBMSes
do not update their internal sequencers. If a row is inserted later, it can
be given an ID that is already in use, resulting in an error. The database
test cases now resynchronise the sequencers before the tests are run.
PHPBB3-11219
2012-11-18 20:38:58 -06:00
Marc Alexander
8d0c667dce
[feature/avatars] Fix the docs and small naming fixes
...
PHPBB3-10018
2012-11-19 00:30:18 +01:00
Marc Alexander
bea6e845d3
[feature/avatars] Use https for gravatar
...
PHPBB3-10018
2012-11-19 00:27:22 +01:00
Marc Alexander
7521c077a9
[feature/avatars] Miscellaenous template fixes
...
PHPBB3-10018
2012-11-18 23:16:37 +01:00
Marc Alexander
c2ba24558f
[feature/avatars] Fix local and upload avatar in the ACP
...
PHPBB3-10018
2012-11-18 23:11:40 +01:00
Marc Alexander
959bc183bf
[feature/avatars] Handle deletion of avatars
...
Previously this wasn't handled correctly if at all.
PHPBB3-10018
2012-11-18 23:09:09 +01:00
David King
e2bf66d065
[feature/controller] Add documentation about input being HTML-escaped
...
PHPBB3-10864
2012-11-18 15:58:47 -05:00
David King
0f4f81b096
[feature/controller] Create Symfony Request in new function
...
PHPBB3-10864
2012-11-18 15:52:35 -05:00
David King
2f50d65648
[feature/controller] Remove unused language strings
...
PHPBB3-10864
2012-11-18 15:51:32 -05:00
David King
60c0a1dd2a
[feature/controller] Don't use $user->lang() before container compilation
...
PHPBB3-10864
2012-11-18 15:51:05 -05:00
Marc Alexander
d8510356d6
[feature/avatars] Add subsilver2 support
...
This implementation might not be perfect though.
PHPBB3-10018
2012-11-18 20:47:29 +01:00
Marc Alexander
1c3b3621db
[feature/avatars] Add missing assign_block_vars() for avatar options
...
This is needed for selecting the gallery avatar while using subsilver2.
PHPBB3-10018
2012-11-18 20:45:51 +01:00
Oleg Pudeyev
7ec94208c4
[ticket/11202] Fix comment char, use more descriptive comment.
...
PHPBB3-11202
2012-11-18 14:32:48 -05:00
Oleg Pudeyev
440c66267e
[ticket/11202] Add response assertions to file upload functional test.
...
PHPBB3-11202
2012-11-18 14:15:23 -05:00
David King
50a96a2a2d
[feature/controller] Update routing documentation for using query string
...
PHPBB3-10864
2012-11-18 13:40:24 -05:00
David King
53caf83233
[feature/controller] Remove now-unused code
...
PHPBB3-10864
2012-11-18 13:35:04 -05:00
David King
09d7367dfc
[feature/controller] Remove url rewriting until we use pathinfo in controllers
...
PHPBB3-10864
2012-11-18 13:32:54 -05:00
David King
7a3d9ed85d
[feature/controller] Fix functional tests to use query string for controllers
...
PHPBB3-10864
2012-11-18 13:11:24 -05:00
Oleg Pudeyev
f4fedfe95b
Merge PR #1098 branch 'igorw/ticket/11213' into develop
...
* igorw/ticket/11213:
[ticket/11213] Add missing global in install_update.php
2012-11-18 10:20:59 -05:00
David King
4d6f6351dd
[feature/controller] Allow injecting Symfony Request into controllers
...
PHPBB3-10864
2012-11-17 18:05:32 -05:00
David King
8913b2c7c4
[feature/controller] Use query string, not path info, for controller access
...
This is hopefully just temporary until we can fix the relative path issue.
PHPBB3-10864
2012-11-17 17:48:20 -05:00
Oleg Pudeyev
47a90f815d
[feature/template-events] Changes per imkingdavid's review.
...
PHPBB3-9550
2012-11-17 16:43:40 -05:00
Oleg Pudeyev
da7d888448
[feature/template-events] Make style names private on template.
...
PHPBB3-9550
2012-11-17 16:43:38 -05:00
Oleg Pudeyev
d42d71b47d
[feature/template-events] Test for event that is defined in parent style only.
...
PHPBB3-9550
2012-11-17 16:42:44 -05:00
Oleg Pudeyev
5f88bbbef3
[feature/template-events] Specify style names, add inheritance tests.
...
PHPBB3-9550
2012-11-17 16:42:44 -05:00
Oleg Pudeyev
21a244543d
[feature/template-events] Normalize expected directory trees.
...
PHPBB3-9550
2012-11-17 16:42:43 -05:00
Oleg Pudeyev
0e6d12dfc4
[feature/template-events] Allow dataset to be correctly selectable.
...
PHPBB3-9550
2012-11-17 16:42:43 -05:00
Oleg Pudeyev
99d93a3f0f
[feature/template-events] Dataset for template event testing with inheritance.
...
PHPBB3-9550
2012-11-17 16:42:43 -05:00
Oleg Pudeyev
af47779f51
[feature/template-events] Use style names array in template filter.
...
This provides a straightforward way of iterating over all styles
looking for templates in extensions.
PHPBB3-9550
2012-11-17 16:42:43 -05:00
Oleg Pudeyev
729eeef2bf
[feature/template-events] Generate style names array in set_style.
...
PHPBB3-9550
2012-11-17 16:42:43 -05:00
Oleg Pudeyev
44d6dc4c4c
[feature/template-events] Convert a single style name to array of them.
...
This allows template code to know the entire style hierarchy for
templates being rendered.
PHPBB3-9550
2012-11-17 16:42:40 -05:00
Oleg Pudeyev
0a29312d83
[feature/template-events] Chase dependency injection for template context.
...
PHPBB3-9550
2012-11-17 16:40:01 -05:00
Oleg Pudeyev
9a7c8721ce
[feature/template-events] Adjust template events test to use the dataset.
...
PHPBB3-9550
2012-11-17 16:40:00 -05:00
Oleg Pudeyev
48adf8c5de
[feature/template-events] Create a dataset for template event tests.
...
Having all files in one directory is too much of a mess.
PHPBB3-9550
2012-11-17 16:40:00 -05:00
Nathan Guse
0141154ceb
[feature/template-events] Indentation fix.
...
PHPBB3-9550
2012-11-17 16:40:00 -05:00
Oleg Pudeyev
6c7f1f7bde
[feature/template-events] Cosmetic changes.
...
PHPBB3-9550
2012-11-17 16:40:00 -05:00
Nathan Guse
4ed9e4124e
[feature/template-events] Wording: wrongly -> improperly.
...
PHPBB3-9550
2012-11-17 16:40:00 -05:00
Nathan Guse
2fb4006056
[feature/template-events] Indentation fix.
...
PHPBB3-9550
2012-11-17 16:40:00 -05:00
Oleg Pudeyev
9c31a0ffc7
[feature/template-events] Rename template_name to style_name.
...
"Style name" makes a lot more sense and should be in line with
recent style/template changes.
PHPBB3-9550
2012-11-17 16:39:59 -05:00
Oleg Pudeyev
0df0c6199b
[feature/template-events] Switch template event test to data providers.
...
PHPBB3-9550
2012-11-17 16:39:59 -05:00
Oleg Pudeyev
667f8d581f
[feature/template-events] Add a universal template event test.
...
Also drop the irrelevant includejs code and add a simple
template event test. The simple test is not working yet however
due to the template engine not correctly tracking which template
it is rendering.
PHPBB3-9550
2012-11-17 16:39:59 -05:00
Oleg Pudeyev
09b4cf2f4c
[feature/template-events] Report when templates cannot be compiled.
...
PHPBB3-9550
2012-11-17 16:39:59 -05:00
Oleg Pudeyev
4b28b413f2
[feature/template-events] Update EVENT tag documentation.
...
It should now fairly closely reflect what actually happens.
PHPBB3-9550
2012-11-17 16:39:59 -05:00
Oleg Pudeyev
faf96a1b40
[feature/template-events] Delete old comments/test code.
...
PHPBB3-9550
2012-11-17 16:39:59 -05:00
Oleg Pudeyev
bd63b17d00
[feature/template-events] Move comment to the function docblock.
...
PHPBB3-9550
2012-11-17 16:39:59 -05:00
Oleg Pudeyev
1b36fc3a60
[feature/template-events] Handle user access correctly.
...
Pass through $user from template to filter.
Allow $user to be null for standalone usage of the template engine.
PHPBB3-9550
2012-11-17 16:39:59 -05:00
Oleg Pudeyev
45a1219886
[feature/template-events] Always commit suicide for invalid event names.
...
Note: suicide happens for syntactically invalid event names,
e.g. event names containing punctuation.
Event names for which there are no events are silently dropped.
PHPBB3-9550
2012-11-17 16:39:58 -05:00
Oleg Pudeyev
f46f48a2cf
[feature/template-events] Chase template/style renames and changes.
...
PHPBB3-9550
2012-11-17 16:39:58 -05:00