Commit graph

20403 commits

Author SHA1 Message Date
Marc Alexander
d43542a434 [ticket/11997] Use $phpbb_filesystem->clean_path() for proper redirect paths
PHPBB3-11997
2013-11-12 00:46:43 +01:00
Marc Alexander
e380eed78e [ticket/11912] Remove obsolete variable $mimetype from content_guesser
PHPBB3-11912
2013-11-12 00:35:52 +01:00
Matt Friedman
e74f1c1790 [ticket/12014] Template Event index_body.html before forumlist
Add content above the forums list (on forum index only)

PHPBB3-12014
2013-11-11 15:28:18 -08:00
Nils Adermann
e567f82d72 [ticket/11998] Make phpbbcli executable and add shebang
PHPBB3-11998
2013-11-12 00:12:34 +01:00
Nils Adermann
592c8b7566 Merge pull request #1849 from bantu/ticket/11998
[ticket/11998] Introduction of the phpBB Console
2013-11-11 15:02:03 -08:00
Marc Alexander
95b22819a7 [ticket/11912] Use inverted $overload for setting function_exists in tests
PHPBB3-11912
2013-11-11 21:59:47 +01:00
Marc Alexander
2d0fb4d166 [ticket/11997] Rename root_dirs_size to superordinate_dirs_count
This variable name better fits what is done with it. A comment explaining
why 2 has to be subtracted from the size of root_dirs has also been added

PHPBB3-11997
2013-11-11 21:55:21 +01:00
Marc Alexander
9d4893b047 [ticket/11912] Remove IN_PHPBB checks from mimetype guesser files
PHPBB3-11912
2013-11-11 21:29:11 +01:00
Marc Alexander
81caa35955 [ticket/11912] Remove obsolete $file_info from plupload
PHPBB3-11912
2013-11-11 21:24:44 +01:00
Marc Alexander
bef6a5a640 [ticket/11912] Introduce guesser priority to mimetype guessers
The mimetype guesser priority can now be set through the service definition.
Mimetypes will be guessed from the guesser with the highest priority to
the one with the lowest priority. Standard priority types have been added
to the service definition file. Any integer value can be used though.
Standard mimetype guessers that do not have the methods get_priority
and set_priority implemented, like the standard MimeTypeGuessers of symfony,
will have the default priority with the value of 0. Lower priority guessers
have values lower than 0 while high priority ones can be added with values
higher than 0.

PHPBB3-11912
2013-11-11 21:18:23 +01:00
Marc Alexander
b1719db47d [ticket/11912] Add extension_guesser for guessing mimetype by extension
The content_guesser now only guesses the mimetype with the function
mime_content_type() while the guessing by extension is done using the
extension_guesser.

PHPBB3-11912
2013-11-11 20:15:28 +01:00
Nathan Guse
d69f35d450 Merge pull request #1853 from nickvergessen/ticket/11927
[ticket/11927] Correctly add new files on update
2013-11-11 09:40:50 -08:00
Joas Schilling
cfb0a41030 Merge remote-tracking branch 'EXreaction/ticket/11943' into develop
* EXreaction/ticket/11943:
  [ticket/11943] New line at EOF for define_error.html
  [ticket/11943] Forgot template file for test
  [ticket/11943] Throw an exception if DEFINE is setup improperly
  [ticket/11943] Split fix_inline_variable_tokens into 3 steps
  [ticket/11943] Require stricter DEFINE statements for templates
  [ticket/11943] Do not quote the value when it is exactly true, false, or null
  [ticket/11943] Add test for DEFINE $VAR = false
2013-11-11 18:23:37 +01:00
Nathan Guse
4bd078e00f Merge pull request #1862 from nickvergessen/ticket/11949
[ticket/11949] Do not prepend leading backslash to cache class name
2013-11-11 09:14:48 -08:00
Nathan Guse
fea933e2e9 Merge pull request #1855 from nickvergessen/ticket/12002
Ticket/12002 Add link hash to extension manager links
2013-11-11 09:08:32 -08:00
Nathan Guse
47e364ae68 [ticket/11943] New line at EOF for define_error.html
PHPBB3-11943
2013-11-11 10:59:17 -06:00
Marc Alexander
0ec644532d Merge pull request #3 from nickvergessen/marc/ticket/11525
Marc/ticket/11525 Part 2
2013-11-10 15:05:59 -08:00
Joas Schilling
a74c560eca [ticket/11525] Fix expected value of group avatar test
PHPBB3-11525
2013-11-11 00:02:12 +01:00
Joas Schilling
32ba402c34 [ticket/11525] Compare correct array to expected value
PHPBB3-11525
2013-11-11 00:01:31 +01:00
Marc Alexander
4468525ee3 Merge pull request #2 from nickvergessen/marc/ticket/11525
Marc/ticket/11525
2013-11-10 14:25:58 -08:00
Joas Schilling
aa84f7de04 [ticket/11525] Prefix id parameter with 'g' again when its a group avatar
PHPBB3-11525
2013-11-10 23:20:48 +01:00
Joas Schilling
47f2caff6b [ticket/11525] Fix doc blocks
PHPBB3-11525
2013-11-10 22:20:15 +01:00
Marc Alexander
6bb9bce40e [ticket/11997] Remove obsolete if statement in phpbb_own_realpath()
PHPBB3-11997
2013-11-10 12:56:09 +01:00
Marc Alexander
95c2b12bf7 [ticket/11896] Add functional tests for marking all notifications read
PHPBB3-11896
2013-11-09 20:35:37 +01:00
Marc Alexander
29d3b08d50 [ticket/11896] Add ability to define expected message after posting
This change will add the ability to define the expected message after a
topic or post has been submitted with the methods create_post() and
create_topic(). If the expected message is not 'POST_STORED', we will not
try to get the topic and post id.

PHPBB3-11896
2013-11-09 20:33:01 +01:00
Marc Alexander
252b5fe4f7 [ŧicket/11896] Set form_time with time() when marking all notifications read
form_time is only set if is passed via the form. Since the mark notifications
read link does not use the form, it will default to 0 causing the mark
notifications logic to only mark notifications read if their time is smaller
or equal to 0. This patch will change ucp_notifications to correctly set
form_time for the confirm_box.

PHPBB3-11896
2013-11-09 20:28:24 +01:00
Nathan Guse
64ed46e682 [ticket/11943] Forgot template file for test
PHPBB3-11943
2013-11-09 11:39:35 -06:00
Nathan Guse
2e5117a71e [ticket/11943] Throw an exception if DEFINE is setup improperly
PHPBB3-11943
2013-11-09 11:14:55 -06:00
Joas Schilling
31e60f0c8d [ticket/11949] Do not prepend leading backslash to cache class name
The container seems to prepend the leading \ itself, so we get an
InvalidArgumentException with message '"'\\phpbb\\cache\\driver\\file'" is
not a valid class name for the "cache.driver" service.'

PHPBB3-11949
2013-11-09 17:06:38 +01:00
Joas Schilling
7344024b10 Merge remote-tracking branch 'dhruv/ticket/12007' into develop
* dhruv/ticket/12007:
  [ticket/12007] Default last_result to 0 instead of false
2013-11-09 15:53:29 +01:00
Nathan Guse
3b68540cee Merge pull request #1857 from nickvergessen/ticket/11922
[ticket/11922] Drop all keys before trying to delete columns to avoid issues
2013-11-08 20:33:18 -08:00
Nathan Guse
6370970f13 [ticket/11943] Split fix_inline_variable_tokens into 3 steps
DEFINE shouldn't add/remove surrounding quotes, but must have the inline
variable tokens fixed

PHPBB3-11943
2013-11-08 22:30:58 -06:00
Cesar G
069cd4a195 [ticket/12010] Make the navbar icons clickable.
PHPBB3-12010
2013-11-08 18:41:59 -08:00
Nathan Guse
da332aa0a5 [ticket/11943] Require stricter DEFINE statements for templates
PHPBB3-11943
2013-11-08 19:55:16 -06:00
Marc Alexander
60dda5577d [ticket/11997] Correctly redirect to front controllers
We currently do a lot of checks in order to prevent users from getting to
a 404 page. However, this logic relies on checking if a file or folder exists.
Due to the front controllers and the URL rewriting in 3.1, it is no longer
possible to rely on existing files for redirecting. This patch will take
care of properly redirecting users to front controller files. An incorrect
link will cause users to get a 404 error though.

PHPBB3-11997
2013-11-08 23:12:42 +01:00
Lukasz
a353673e7c [ticket/12005] Remove PM popup module from DB
PHPBB3-12005
2013-11-08 21:57:12 +01:00
Lukasz
9328d42809 [ticket/12005] Delete templates files
PHPBB3-12005
2013-11-08 21:57:11 +01:00
Lukasz
d5ffb30025 [ticket/12005] Remove language vars used by PM popup
PHPBB3-12005
2013-11-08 21:57:09 +01:00
Lukasz
65fbf87ce7 [ticket/12005] Remove PM popup
PHPBB3-12005
2013-11-08 21:57:08 +01:00
Lukasz
0499c30b2b [ticket/12005] Remove PM popup UCP module
PHPBB3-12005
2013-11-08 21:57:06 +01:00
Lukasz
166e27566a [ticket/12005] Remove PM popup from converter
PHPBB3-12005
2013-11-08 21:57:05 +01:00
Lukasz
57ec9ee49e [ticket/12005] Remove PM popup setting from user preferences
PHPBB3-12005
2013-11-08 21:57:03 +01:00
Dhruv
1173adfe87 [ticket/12007] Default last_result to 0 instead of false
PostgreSQL does not map null/false to 0 and thus this variable causes
an error.

PHPBB3-12007
2013-11-08 23:34:49 +05:30
Joas Schilling
6f33954757 [ticket/11922] Drop all keys before trying to delete columns to avoid issues
On MSSQL columns that have an index can not be dropped.

PHPBB3-11922
2013-11-08 17:45:48 +01:00
Cesar G
253f8d7593 [ticket/12001] Ensure that form data is sent to server in AJAX requests.
PHPBB3-12001
2013-11-08 06:13:55 -08:00
Joas Schilling
7a8a440895 [ticket/12002] Change functional test to use link hash
PHPBB3-12002
2013-11-08 14:08:55 +01:00
Joas Schilling
a6c73ea0c8 [ticket/12002] Add link hash to extension manager links
PHPBB3-12002
2013-11-08 14:08:02 +01:00
David King
082a467cc8 Merge pull request #1845 from nickvergessen/ticket/11994
[ticket/11994] Make extension manager UI less misleading
2013-11-07 17:46:58 -08:00
Joas Schilling
bf7eab423e [ticket/11994] Fix functional tests
PHPBB3-11994
2013-11-08 01:20:04 +01:00
Joas Schilling
d17bf9aa27 [ticket/11994] "Delete data" is only available for disabled extensions
PHPBB3-11994
2013-11-08 01:20:03 +01:00