makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-18 09:18:52 +00:00
Code Issues Projects Releases Packages Wiki Activity
20403 commits 18 branches 192 tags 207 MiB
Commit graph

20403 commits

This branch
This branch
All branches
Author SHA1 Message Date
Dhruv
e4977b714e [ticket/11271] Use absolute path for displaying inline attachments in feeds 
PHPBB3-11271
 2013-09-15 20:40:32 +05:30
Dhruv
41282c5065 [ticket/11735] Display disabled checkbox when notification is already read 
PHPBB3-11735
 2013-09-15 20:29:45 +05:30
erangamapa
1450d29aba [ticket/11271] Changed executable bit. 
Changed executable bit value from 755 to 644.

PHPBB3-11271
 2013-09-15 15:42:55 +05:30
erangamapa
08fdd30917 [ticket/11271] Formatting code and removing null assignment. 
Formatted code and replaced null assignment with empty array
assignment to attachments parameter in method 'feed_generate_content'.

PHPBB3-11271
 2013-09-15 15:42:51 +05:30
erangamapa
31957abeb1 [ticket/11271] Removing unnecessary database object 
Removed unnecessary global database object from 'feed_generate_content'
Method.

PHPBB3-11271
 2013-09-15 15:42:37 +05:30
erangamapa
86d83f2bb2 [ticket/11271] Separated attachment fetching query 
Removed external query used to fetch related attachments.
Added attachments fetching method with database query to
post based feed.

PHPBB3-11271
 2013-09-15 15:42:24 +05:30
erangamapa
098fdf95ae [ticket/11271] Fetched feed attachments before loop. 
Fetched feed attachments before looping through feed items and
send them to method 'feed_generate_content' for each feed item.

PHPBB3-11271
 2013-09-15 15:42:09 +05:30
erangamapa
224c863377 [ticket/11271] Removed in-line attachment comments properly. 
Added a new regex to remove in-line attachment comments.

PHPBB3-11271
 2013-09-15 15:41:52 +05:30
erangamapa
72b92f70f1 [ticket/11271] Displaying in-line attached images in ATOM feed. 
In-line attached images are not displaying as they are not parsing.
Included 'parse_attachments' column name for data fetching queries
in feed.php. Checked weather feeds have in-line attachments and
parsed them by using parse_attachments() method.

PHPBB3-11271
 2013-09-15 15:41:36 +05:30
Dhruv
6ce5a72c55 Merge remote-tracking branch 'Prosk8er/ticket/11844' into develop 
# By Prosk8er
# Via Prosk8er
* Prosk8er/ticket/11844:
  [ticket/11844] update acp/authentication language var
 2013-09-15 11:18:01 +05:30
Prosk8er
30a26f23a4 [ticket/11844] update acp/authentication language var 
the language var ACP_AUTH_SETTINGS_EXPLAIN in language/en/acp/board.php

PHPBB3-11844
 2013-09-14 15:28:04 -04:00
Nathan Guse
939174eac8 Merge pull request #1666 from cyberalien/ticket/11795 
Move JS from html files to forum_fn.js
 2013-09-14 12:17:41 -07:00
Marc Alexander
beafef0000 [feature/passwords] Add missing function documentation 
Additionally, a new line has been added to make the code look nicer.

PHPBB3-11610
 2013-09-14 14:17:14 +02:00
Marc Alexander
19512b2595 [feature/passwords] Rename "crypto" files to "passwords" files 
PHPBB3-11610
 2013-09-14 14:04:48 +02:00
Marc Alexander
b810957c4b [feature/passwords] Properly set convert_flag and add test for it 
PHPBB3-11610
 2013-09-14 13:55:53 +02:00
Marc Alexander
8b9370c6a9 [feature/passwords] Define default hashing algorithm in container file 
The default hashing algorithm type is defined as a parameter in the service
definition file for the password hashing system. This will allow us to change
this in the future but it will also prevent unexperienced admins from changing
the hashing algorithm.

PHPBB3-11610
 2013-09-14 13:55:45 +02:00
Marc Alexander
58755c4972 [feature/passwords] Add get_name() method to drivers 
This will allow us to actually properly differentiate between the available
drivers.

PHPBB3-11610
 2013-09-14 13:55:39 +02:00
Marc Alexander
df8e5f4c3c [feature/passwords] Move migrations file to phpbb folder 
PHPBB3-11610
 2013-09-14 13:55:34 +02:00
Marc Alexander
9b24fda5cd [feature/passwords] Move files after namespacing changes 
PHPBB3-11610
 2013-09-14 13:55:28 +02:00
Marc Alexander
2e453eb2cb [feature/passwords] Add legacy support for md5 passwords 
PHPBB3-11610
 2013-09-14 13:55:23 +02:00
Marc Alexander
bd4664807f [feature/passwords] Increase code coverage in bcrypt driver 
PHPBB3-11610
 2013-09-14 13:55:18 +02:00
Marc Alexander
3a776ed0af [feature/passwords] Increase test coverage of salted_md5 driver 
PHPBB3-11610
 2013-09-14 13:55:13 +02:00
Marc Alexander
05a5ac282d [feature/passwords] Fix incorrect call to helper instead of $this 
The driver helper method unique_id is called inside the helper. Therefore,
it shouldn't be called via $this->helper but rather via $this.

PHPBB3-11610
 2013-09-14 13:55:06 +02:00
Marc Alexander
b6473a515b [feature/passwords] Increase manager test coverage to cover all methods 
All methods in the manager are now fully covered.

PHPBB3-11610
 2013-09-14 13:55:00 +02:00
Marc Alexander
a4b0a8ceb9 [feature/passwords] Do not use specific errors but just return false 
The authentication system should handle the possible errors for now.
Additional error returns can be added later on if they are needed.

PHPBB3-11610
 2013-09-14 13:54:53 +02:00
Marc Alexander
dbd6d33e9f [feature/passwords] NULL should be null according to coding guidelines 
PHPBB3-11610
 2013-09-14 13:54:48 +02:00
Marc Alexander
8f863d1d49 [feature/passwords] Do not check if type_map is empty 
If the type map is empty the service container is incomplete or broken.
There is no need to check this as other components would probably be broken
at the same time.

PHPBB3-11610
 2013-09-14 13:54:39 +02:00
Marc Alexander
fcb7130823 [feature/passwords] Use randomly generated password for tests 
The password will start with 'foobar' and then continue with random
characters that will be appended every iteration.

PHPBB3-11610
 2013-09-14 13:54:33 +02:00
Marc Alexander
ddc207fae8 [feature/passwords] Fix tests on PHP versions < 5.3.7 
PHPBB3-11610
 2013-09-14 13:54:27 +02:00
Marc Alexander
cfbd858bd7 [feature/passwords] Properly treat duplicates in combined hashes 
PHPBB3-11610
 2013-09-14 13:54:21 +02:00
Marc Alexander
556048177f [feature/passwords] Make method get_hashing_public_algorithm public 
Combined hashing requires it for checking the supplied password hash for
its hashing algorithm.

PHPBB3-11610
 2013-09-14 13:54:13 +02:00
Marc Alexander
6f33ca85a2 [feature/passwords] Add tests for combined hashing of passwords 
PHPBB3-11610
 2013-09-14 13:54:06 +02:00
Marc Alexander
dc76146cef [feature/passwords] Add combined hashing method to helper 
This will allow to hash a previously hashed password with another hashing
method, i.e. as upgrade path from phpBB 3.0 to 3.1.

PHPBB3-11610
 2013-09-14 13:53:58 +02:00
Marc Alexander
c67f7dba60 [feature/passwords] Add function for obtaining only the hash to helper 
This is also needed for combined hashing of passwords.

PHPBB3-11610
 2013-09-14 13:53:52 +02:00
Marc Alexander
16e5d0dc35 [feature/passwords] Fix minor code limitations in helper 
These limitations caused it to only allow a specific input to combined
hashes.

PHPBB3-11610
 2013-09-14 13:53:44 +02:00
Marc Alexander
ab068799b1 [feature/passwords] Pass phpbb_container to passwords helper 
PHPBB3-11610
 2013-09-14 13:53:31 +02:00
Marc Alexander
e4a5aacf2a [feature/passwords] Use correct prefix for salt in salted_md5 
PHPBB3-11610
 2013-09-14 13:53:26 +02:00
Marc Alexander
857b90057b [feature/passwords] Add method for obtaining the hash settings only 
This is needed for combined hashing of passwords.

PHPBB3-11610
 2013-09-14 13:53:19 +02:00
Marc Alexander
dae4327cfc [feature/passwords] Add schema changes for new hash types 
PHPBB3-11610
 2013-09-14 13:53:14 +02:00
Marc Alexander
4b81b93d10 [feature/passwords] Make sure hash has the required length 
Also added tests to make sure that crypto drivers are enforcing the hash
length.

PHPBB3-11610
 2013-09-14 13:53:08 +02:00
Marc Alexander
7ddf004489 [feature/passwords] Make method get_hashing_algorithm() protected 
There is currently no use for it being public.

PHPBB3-11610
 2013-09-14 13:53:03 +02:00
Marc Alexander
e7b3daeb29 [feature/passwords] Add tests for manager check_hash() method 
Tests cover all supported hashing algorithms.

PHPBB3-11610
 2013-09-14 13:52:57 +02:00
Marc Alexander
13d25e6a32 [feature/passwords] Fix tests for PHP version < 5.3.7 
PHPBB3-11610
 2013-09-14 13:52:52 +02:00
Marc Alexander
3f70699aa3 [feature/passwords] Use common salt generation function for all types 
We will be using the same method inside the driver helper class for all hash
types. This is the same function that has been used for the salted md5 hash
of phpBB 3.0.

PHPBB3-11610
 2013-09-14 13:52:43 +02:00
Marc Alexander
5574b2a8e9 [feature/passwords] Add driver helper class file 
PHPBB3-11610
 2013-09-14 13:52:38 +02:00
Marc Alexander
33725f6e2f [feature/passwords] Include driver helper in manager_test 
PHPBB3-11610
 2013-09-14 13:52:33 +02:00
Marc Alexander
61e98fbd63 [feature/passwords] Add driver helper class for additional functions 
Functions for the helper class might be used in other drivers as well and
therefore shouldn't be limited to just one driver.

PHPBB3-11610
 2013-09-14 13:52:25 +02:00
Marc Alexander
c9fafcefd3 [feature/passwords] Add basic passwords manager test file 
PHPBB3-11610
 2013-09-14 13:52:15 +02:00
Marc Alexander
f8bcf99c7f [feature/passwords] Do not support 8-bit characters with $2a$ bcrypt 
8-bit unicode characters might reduce the security of the password hash
when using the $2a$ bcrypt prefix. Those types of characters are usually
not used in passwords but we should prevent this possible issue anyway.

PHPBB3-11610
 2013-09-14 13:52:09 +02:00
Marc Alexander
8795fe9c77 [feature/passwords] Add convert flag for converting to default 
PHPBB3-11610
 2013-09-14 13:52:04 +02:00