Igor Wiedler
b5e069f879
Merge remote-tracking branch 'p/ticket/10933' into develop
...
* p/ticket/10933:
[ticket/10933] Prose for get_first_file_location.
[ticket/10933] Remaining documentation for added functions in resource locator
[ticket/10933] Update template locator test to use style resource locator.
[ticket/10933] Dispose of locate function in template class.
[ticket/10933] Add mutators for template_path to style resource locator.
[ticket/10933] Delete template_path assignment.
[ticket/10933] Delete template_path from template class.
[ticket/10933] Add get_first_template_location.
2012-11-17 19:49:03 +01:00
Oleg Pudeyev
e07db8fb8c
Merge PR #1097 branch 'igorw/ticket/11212' into develop
...
* igorw/ticket/11212:
[ticket/11212] Cosmetic surgery done right
[ticket/11212] Cosmetics
[ticket/11212] Rename get_http_version to phpbb_request_http_version()
[ticket/11212] Allow dispatcher to be absent during garbage_collection()
[ticket/11212] Do not rely on $request in send_status_line()
2012-11-17 12:24:15 -05:00
Igor Wiedler
b8cf74217a
[ticket/11212] Cosmetic surgery done right
...
PHPBB3-11212
2012-11-17 05:29:49 +01:00
Igor Wiedler
1affc35be9
[ticket/11212] Cosmetics
...
PHPBB3-11212
2012-11-17 05:29:49 +01:00
Igor Wiedler
b534a7a579
[ticket/11212] Rename get_http_version to phpbb_request_http_version()
...
PHPBB3-11212
2012-11-17 05:29:49 +01:00
Igor Wiedler
98921e0b87
[ticket/11213] Add missing global in install_update.php
...
PHPBB3-11213
2012-11-17 05:27:36 +01:00
Igor Wiedler
9cdef7984f
[ticket/11212] Allow dispatcher to be absent during garbage_collection()
...
PHPBB3-11212
2012-11-17 01:17:23 +01:00
Igor Wiedler
5fad4006e1
[ticket/11212] Do not rely on $request in send_status_line()
...
PHPBB3-11212
2012-11-17 01:15:50 +01:00
David King
4efbb893b7
[feature/controller] Fix line endings and permissions, and check responses
...
PHPBB3-10864
2012-11-16 17:36:39 -05:00
David King
abf2575bdb
[feature/controller] Remove URL rewriting by default
...
PHPBB3-10864
2012-11-16 17:06:02 -05:00
David King
5b013ddf5c
[feature/controller] Add controller functional test with template
...
PHPBB3-10864
2012-11-16 17:06:01 -05:00
David King
ba1acdca03
[feature/controller] Use warning instead of echo for copy() and unlink()
...
PHPBB3-10864
2012-11-16 17:06:00 -05:00
David King
1952a4f276
[feature/controller] Flip method parameters, require $message
...
PHPBB3-10864
2012-11-16 17:06:00 -05:00
David King
d41b1146e8
[feature/controller] Rename $root_path class property to $phpbb_root_path
...
PHPBB3-10864
2012-11-16 17:05:59 -05:00
David King
c2f352ab35
[feature/controller] Fix param block for controller callable
...
PHPBB3-10864
2012-11-16 17:05:58 -05:00
David King
0c75d3d7da
[feature/controller] Add test for missing argument in controller class
...
PHPBB3-10864
2012-11-16 17:05:57 -05:00
David King
230897723c
[feature/controller] Reword comment for clarification
...
PHPBB3-10864
2012-11-16 17:05:57 -05:00
David King
e516680859
[feature/controller] Use sizeof() instead of count() as per guidelines
...
PHPBB3-10864
2012-11-16 17:05:56 -05:00
David King
120267e580
[feature/controller] Correctly access user object
...
PHPBB3-10864
2012-11-16 17:05:55 -05:00
David King
74bc460493
[feature/controller] Rename improperly named controller exception class
...
PHPBB3-10864
2012-11-16 17:05:55 -05:00
David King
7691755883
[feature/controller] Adapt functional tests given new controller framework
...
PHPBB3-10864
2012-11-16 17:05:54 -05:00
David King
c9588572c9
[feature/controller] Add period before $phpEx
...
PHPBB3-10864
2012-11-16 17:05:53 -05:00
David King
a87a5dd566
[feature/controller] Fix tests
...
PHPBB3-10864
2012-11-16 17:05:53 -05:00
David King
b2598662af
[feature/controller] Clarify working paths after enabling rewriting
...
PHPBB3-10864
2012-11-16 17:05:52 -05:00
David King
f42b36185c
[feature/controller] Better explanation of the Options +FollowSymLinks line
...
PHPBB3-10864
2012-11-16 17:05:51 -05:00
David King
45b3ab8e81
[feature/controller] Move Response definition into a variable
...
PHPBB3-10864
2012-11-16 17:05:51 -05:00
David King
235b0194f1
[feature/controller] Update wording in .htaccess documentation comments
...
PHPBB3-10864
2012-11-16 17:05:50 -05:00
David King
14f44c17ad
[feature/controller] phpbb_controller_exception instead of RuntimeException
...
PHPBB3-10864
2012-11-16 17:05:49 -05:00
David King
d0269629dc
[feature/controller] Documentation about Symlinks in .htaccess
...
PHPBB3-10864
2012-11-16 17:05:49 -05:00
David King
db071d6854
[feature/controller] Fix use of $this in global scope
...
PHPBB3-10864
2012-11-16 17:05:48 -05:00
David King
91ce6e8b16
[feature/controller] Turn off URL rewriting by default, add comments for usage
...
PHPBB3-10864
2012-11-16 17:05:47 -05:00
David King
8e480a8725
[feature/controller] Move include to app.php
...
PHPBB3-10864
2012-11-16 17:05:46 -05:00
David King
db1d49d559
[feature/controller] Rename get_paths to import_paths_from_finder
...
Also removed unused variable from url_matcher function
PHPBB3-10864
2012-11-16 17:05:46 -05:00
David King
b4eff4f06a
[feature/controller] Remove URL Base from helper class
...
I had forgotten that the container sends the same instance of objects to all
services that request it, so in this case all controllers would share the same
base url path, which is not desired.
PHPBB3-10864
2012-11-16 17:05:45 -05:00
David King
aead33432a
[feature/controller] Remove dumped container when cache is purged
...
PHPBB3-10864
2012-11-16 17:05:44 -05:00
David King
c54c3ee422
[feature/controller] A few minor nitpickings
...
PHPBB3-10864
2012-11-16 17:05:44 -05:00
David King
fa43edd877
[feature/controller] Further separate url matcher functionality
...
PHPBB3-10864
2012-11-16 17:05:43 -05:00
David King
4cb9ec522c
[feature/controller] Separate Kernel listeners into their own classes
...
PHPBB3-10864
2012-11-16 17:05:42 -05:00
David King
196c2d4bc3
[feature/controller] Move new functions to their own file
...
PHPBB3-10864
2012-11-16 17:05:41 -05:00
David King
269a56e2c3
[feature/controller] Undo removal of period in ext.finder service definition
...
PHPBB3-10864
2012-11-16 17:05:41 -05:00
David King
d3aa8823b2
[feature/controller] Use a dumped url matcher class to improve performance
...
PHPBB3-10864
2012-11-16 17:05:40 -05:00
David King
5877bf1b1b
[feature/controller] Update helper service given constructor change
...
PHPBB3-10864
2012-11-16 16:47:32 -05:00
David King
46cb0fb068
[feature/controller] Removed another empty construct method
...
PHPBB3-10864
2012-11-16 16:47:32 -05:00
David King
c6a5699325
[feature/controller-new] Fix line endings
...
PHPBB3-10864
2012-11-16 16:47:31 -05:00
David King
2e59450459
[feature/controller] Use assign_display() instead of return_display()
...
The latter was deemed unnecessary at the moment.
PHPBB3-10864
2012-11-16 16:47:30 -05:00
David King
6900456e90
[feature/controller] Revert changes to template class
...
As per IRC, assign_display() effectively does what return_display() was added
to do, so no change was needed.
PHPBB3-10864
2012-11-16 16:47:29 -05:00
David King
ef46af8298
[feature/controller] Don't attempt to assign if no variable is give
...
PHPBB3-10864
2012-11-16 16:47:29 -05:00
David King
b5255d4ea4
[feature/controller] Fix syntax error in template code
...
PHPBB3-10864
2012-11-16 16:47:28 -05:00
David King
1c5a82c411
[feature/controller] Remove empty __construct() method
...
PHPBB3-10864
2012-11-16 16:47:27 -05:00
David King
79bcbd3691
[feature/controller] Add _controller attribute to Request after instantiation
...
PHPBB3-10864
2012-11-16 16:47:26 -05:00
