Andreas Fischer
fea118cf0d
Merge remote-tracking branch 'unknownbliss/ticket/111642' into develop-olympus
...
* unknownbliss/ticket/111642:
[ticket/11164] Update composer.phar
2012-11-05 15:17:55 -05:00
Unknown Bliss
0dbd569385
[ticket/11164] Update composer.phar
...
PHPBB3-11164
2012-11-04 20:34:31 +00:00
Oleg Pudeyev
7fdab9c5d7
[ticket/10933] Prose for get_first_file_location.
...
Also rewrite get_first_template_location prose a little to be
less repetitive with get_first_file_location.
PHPBB3-10933
2012-11-02 19:45:02 -04:00
Oleg Pudeyev
bf66c47650
[ticket/10933] Remaining documentation for added functions in resource locator
...
PHPBB3-10933
2012-11-02 19:39:07 -04:00
Oleg Pudeyev
b878d5daa9
[ticket/10933] Update template locator test to use style resource locator.
...
There is no reason for it to go through a template instance to test
resource locator functionality.
PHPBB3-10933
2012-11-02 19:39:07 -04:00
Oleg Pudeyev
0dd981071b
[ticket/10933] Dispose of locate function in template class.
...
It had no callers other than the test suite.
PHPBB3-10933
2012-11-02 19:39:07 -04:00
Oleg Pudeyev
09794c6821
[ticket/10933] Add mutators for template_path to style resource locator.
...
template_path is now private.
Change semantics of passing false for template path - now this resets
template path to default which I think makes sense.
PHPBB3-10933
2012-11-02 19:39:05 -04:00
Oleg Pudeyev
6295b014d3
[ticket/10933] Delete template_path assignment.
...
template_path is now only present in style resource locator and
should not be assigned to.
PHPBB3-10933
2012-11-02 19:37:53 -04:00
Oleg Pudeyev
97e53103c3
[ticket/10933] Delete template_path from template class.
...
template_path is now only present in style resource locator.
PHPBB3-10933
2012-11-02 19:37:52 -04:00
Oleg Pudeyev
615d5ef628
[ticket/10933] Add get_first_template_location.
...
This localizes template_path to style resource locator.
locate function on template will be removed in a subsequent commit.
PHPBB3-10933
2012-11-02 19:37:52 -04:00
Igor Wiedler
816c546666
Merge remote-tracking branch 'p/ticket/10933-lite' into develop
...
* p/ticket/10933-lite:
[ticket/10933] Use inheritDoc, eliminate copy pasted docblocks.
[ticket/10933] Dependency inject template context.
[ticket/10933] Expanded prose documentation for phpbb_extension_provider.
[ticket/10933] Specify empty template path for absolute includephp test.
[ticket/10933] Useful documentation for template locate function
[ticket/10933] Typo fixes
[ticket/10933] Initialize template context when template is constructed.
2012-11-03 00:34:51 +01:00
Oleg Pudeyev
c063e3a52c
[ticket/10933] Use inheritDoc, eliminate copy pasted docblocks.
...
PHPBB3-10933
2012-11-02 19:28:32 -04:00
Oleg Pudeyev
767d09227b
[ticket/10933] Dependency inject template context.
...
PHPBB3-10933
2012-11-02 18:51:35 -04:00
Oleg Pudeyev
d7a626c70b
[ticket/10933] Expanded prose documentation for phpbb_extension_provider.
...
PHPBB3-10933
2012-11-02 18:07:00 -04:00
Oleg Pudeyev
c3fb0f359c
[ticket/10933] Specify empty template path for absolute includephp test.
...
This was probably necessary all along, and the test happened to work
because state was not correctly reset between test runs and
a previous test set an empty template path.
PHPBB3-10933
2012-11-02 18:06:21 -04:00
Oleg Pudeyev
766353fe5c
[ticket/10933] Useful documentation for template locate function
...
PHPBB3-10933
2012-11-02 18:03:52 -04:00
Oleg Pudeyev
0c18f92c0a
[ticket/10933] Typo fixes
...
PHPBB3-10933
2012-11-02 18:03:52 -04:00
Oleg Pudeyev
8528d8ff34
[ticket/10933] Initialize template context when template is constructed.
...
There is no apparent reason for either initializing or clearing
the context in set_style/set_custom_style.
Initially the initialization there was added in
0501640d5d
, for reasons that
presently I do not see.
This permits making context property back private.
PHPBB3-10933
2012-11-02 18:03:52 -04:00
Oleg Pudeyev
000bbfd5b3
Merge pull request #1028 from bantu/ticket/11099
...
[ticket/11099] Mark acp_ban::display_ban_options() as static.
2012-11-01 19:39:03 -07:00
Andreas Fischer
969369254f
[ticket/10875] Add comment about cache's sql_load() method.
...
PHPBB3-10875
2012-10-31 18:14:52 -04:00
Andreas Fischer
4e83cd461c
[ticket/10875] Fix logic in phpbb_cache_driver_file::sql_save().
...
Previously (develop-olympus) $query_result was passed via reference into
sql_save(). Now the (possibly changed) result is returned by value.
Adjust logic to take this change into account correctly.
PHPBB3-10875
2012-10-30 18:50:26 -04:00
Andreas Fischer
59af4d68fc
[ticket/10875] Fix phpbb_mock_cache::sql_save() to return $query_result.
...
PHPBB3-10875
2012-10-30 18:50:26 -04:00
Andreas Fischer
e28f0aa336
[ticket/10875] Fix return value of phpbb_cache_driver_null::sql_save().
...
phpbb_cache_driver_null::sql_save() has to return $query_result as is instead
of null.
PHPBB3-10875
2012-10-30 18:50:25 -04:00
Andreas Fischer
4f65a00334
[ticket/10875] Remove useless assignment from phpbb_cache_driver_memory.
...
sql_save() no longer takes $query_result as a reference, thus this assignment
is a no-op.
PHPBB3-10875
2012-10-30 18:50:25 -04:00
Andreas Fischer
a1524a69d6
[ticket/11099] Mark acp_ban::display_ban_options() as static.
...
It is called statically from mcp_ban.
PHPBB3-11099
2012-10-30 18:43:00 -04:00
Andreas Fischer
1f248dab6f
Merge remote-tracking branch 'p/ticket/11157' into develop
...
* p/ticket/11157:
[ticket/11157] static public is the currently approved order.
[ticket/11157] Fix remaining captcha spam.
[ticket/11157] get_captcha_types is an instance method.
2012-10-30 18:19:44 -04:00
Andreas Fischer
e0e3622ba9
Merge remote-tracking branch 'p/ticket/11159-develop' into develop
...
* p/ticket/11159-develop:
[ticket/11159] static public is the currently approved order.
2012-10-30 18:16:16 -04:00
Andreas Fischer
c9ad0c6f25
Merge branch 'develop-olympus' into develop
...
* develop-olympus:
[ticket/11158] Require acl_u_sig for ucp signature module.
[ticket/11158] Revert old fix in PHPBB3-10186.
Conflicts:
phpBB/install/database_update.php
phpBB/ucp.php
2012-10-29 15:16:59 -04:00
Andreas Fischer
88b100d818
Merge remote-tracking branch 'p/ticket/11158' into develop-olympus
...
* p/ticket/11158:
[ticket/11158] Require acl_u_sig for ucp signature module.
[ticket/11158] Revert old fix in PHPBB3-10186.
2012-10-29 15:13:33 -04:00
Oleg Pudeyev
5f5d395c62
[ticket/11158] Require acl_u_sig for ucp signature module.
...
PHPBB3-11158
2012-10-29 14:58:25 -04:00
Oleg Pudeyev
88bd7292f1
[ticket/11158] Revert old fix in PHPBB3-10186.
...
Revert "[ticket/10186] UCP signature panel displays when not authed
for signatures"
This reverts commit f6fa52540c
.
PHPBB3-10186
PHPBB3-11158
2012-10-29 14:58:19 -04:00
Oleg Pudeyev
31781adf0c
[ticket/11159] static public is the currently approved order.
...
PHPBB3-11159
2012-10-29 14:57:27 -04:00
Oleg Pudeyev
d602f13d7f
[ticket/11157] static public is the currently approved order.
...
PHPBB3-11157
2012-10-29 14:54:54 -04:00
Oleg Pudeyev
14a6e5ec73
[ticket/11157] Fix remaining captcha spam.
...
PHPBB3-11157
2012-10-29 14:48:43 -04:00
Oleg Pudeyev
60d9538b14
[ticket/11157] get_captcha_types is an instance method.
...
It is specific to a particular captcha factory implementation,
instantiate a captcha factory to invoke it.
PHPBB3-11157
2012-10-29 14:48:42 -04:00
Oleg Pudeyev
dc8052b5c0
Merge PR #1021 branch 'p/ticket/11156' into develop
...
* p/ticket/11156:
[ticket/11156] Delete "Misc" tab of forum based permissions + move items
2012-10-29 08:10:56 -04:00
RMcGirr83
a9b59bfe03
[ticket/11156] Delete "Misc" tab of forum based permissions + move items
...
PHPBB3-11156
2012-10-29 08:01:16 -04:00
Oleg Pudeyev
6bf60ac5cb
Merge PR #971 branch 'nickvergessen/ticket/11018' into develop
...
* nickvergessen/ticket/11018:
[ticket/11014] Fix old pagination assignment
[ticket/11018] Fix several paginations in ACP
[ticket/11014] Fix IF statements for new template pagination
[ticket/11014] Fix text for previous/next links in Subsilver2
[ticket/11023] Fix additional whitespaces that were added by PHPBB3-10968
[ticket/11018] Always display previous/next links if we can display one
[ticket/11014] Restore template vars for next/previous links
[ticket/11018] Swap prev/next links on pagination to the old order
[ticket/11067] Copy prosilver CSS to adm, so the pagination looks the same
[ticket/11018] Fix minor issues with CSS in prosilver
[ticket/11018] Attempt to fix li.pagination alignment issue
2012-10-22 17:44:34 -04:00
Andreas Fischer
b3fdf8a046
Merge remote-tracking branch 'EXreaction/ticket/8796' into develop
...
* EXreaction/ticket/8796:
[ticket/8796] Prevent setting post_time greater than time() in markread
[ticket/8796] Fix a few issues with the previous commits
[ticket/8796] Mark read links updated to include time() in url
[ticket/8796] Revert changes to $user->data['lastmark']
[ticket/8796] Make function markread obey the $post_time argument
2012-10-18 16:43:46 +02:00
Andreas Fischer
4f3f4a40d6
Merge branch 'develop-olympus' into develop
...
* develop-olympus:
[ticket/10848] Move include up.
[ticket/10848] Add phpbb_ prefix.
[ticket/10848] Redirect from adm to installer correctly.
Conflicts:
phpBB/includes/functions.php
2012-10-18 16:34:59 +02:00
Andreas Fischer
c84268d2f9
Merge remote-tracking branch 'p/ticket/10848' into develop-olympus
...
* p/ticket/10848:
[ticket/10848] Move include up.
[ticket/10848] Add phpbb_ prefix.
[ticket/10848] Redirect from adm to installer correctly.
2012-10-18 16:26:54 +02:00
Oleg Pudeyev
b283df8241
[ticket/10848] Move include up.
...
PHPBB3-10848
2012-10-17 22:35:36 -04:00
Oleg Pudeyev
0a260f80af
Merge PR #918 branch 'develop-olympus' into develop
...
* develop-olympus:
[ticket/10568] adding MESSAGE_EDITED to ucp.php and compose_pm
2012-10-17 22:31:35 -04:00
Oleg Pudeyev
bd44088757
Merge PR #918 branch 'Senky/ticket/10568' into develop-olympus
...
* Senky/ticket/10568:
[ticket/10568] adding MESSAGE_EDITED to ucp.php and compose_pm
2012-10-17 22:10:49 -04:00
Joas Schilling
b0bfe724fb
[ticket/11014] Fix old pagination assignment
...
PHPBB3-11014
2012-10-17 23:34:37 +02:00
Joas Schilling
99dd73aac7
[ticket/11018] Fix several paginations in ACP
...
PHPBB3-11018
2012-10-17 23:34:37 +02:00
Joas Schilling
7ce43d49d8
[ticket/11014] Fix IF statements for new template pagination
...
PHPBB3-11014
2012-10-17 23:34:37 +02:00
Joas Schilling
7675d72622
[ticket/11014] Fix text for previous/next links in Subsilver2
...
PHPBB3-11014
2012-10-17 23:34:37 +02:00
Joas Schilling
ceb5a40eec
[ticket/11023] Fix additional whitespaces that were added by PHPBB3-10968
...
PHPBB3-11023
2012-10-17 23:34:37 +02:00
Joas Schilling
ada2d4c91b
[ticket/11018] Always display previous/next links if we can display one
...
PHPBB3-11018
2012-10-17 23:33:19 +02:00