$delta was always an int - so, this test would sometimes fail if you
happened to call time() /very/ close to a 1s boundary.
Found by HHVM's continuous testing.
PHPBB3-12996
* develop-ascraeus:
[ticket/12822] Fix test runs of avatar manager_test
[ticket/12822] Add method for deleting avatars and use confirm_box
[ticket/12822] Remove "None" option from avatar select boxes
Conflicts:
phpBB/styles/subsilver2/template/ucp_groups_manage.html
phpBB/styles/subsilver2/template/ucp_profile_avatar.html
* github-marc1706/ticket/12822:
[ticket/12822] Fix test runs of avatar manager_test
[ticket/12822] Add method for deleting avatars and use confirm_box
[ticket/12822] Remove "None" option from avatar select boxes
* develop-ascraeus:
[ticket/12932] Remove set_datetime_class method from user class
[ticket/12932] Fix tests and calls to create_datetime
[ticket/12932] Add method for getting the datetime class and allow overriding
Conflicts:
phpBB/config/services.yml
[ticket/12932] Add method for allowing override of \phpbb\datetime class
* marc1706/ticket/12932:
[ticket/12932] Remove set_datetime_class method from user class
[ticket/12932] Fix tests and calls to create_datetime
[ticket/12932] Add method for getting the datetime class and allow overriding
[ticket/12794] Properly validate google+ field against valid character set
* marc1706/ticket/12794:
[ticket/12794] Properly validate google+ field against valid character set
* develop-ascraeus:
[ticket/12671] Possibility to use NOT LIKE expression
[ticket/12671] Possibility to use NOT LIKE expression
[ticket/12671] Possibility to use NOT LIKE expression
[ticket/12671] Possibility to use NOT LIKE expression
[ticket/12671] Possibility to use NOT LIKE expression
Ticket/12671 Possibility to use NOT LIKE expression
* Geolim4/ticket/12671:
[ticket/12671] Possibility to use NOT LIKE expression
[ticket/12671] Possibility to use NOT LIKE expression
[ticket/12671] Possibility to use NOT LIKE expression
[ticket/12671] Possibility to use NOT LIKE expression
[ticket/12671] Possibility to use NOT LIKE expression
* develop-ascraeus:
[ticket/12938] Remove functional tests for 'Download all attachments'.
[ticket/12938] Remove the 'Download all attachments' feature.
[ticket/12938] Remove the 'Download all attachments' feature.
* bantu/ticket/12938:
[ticket/12938] Remove functional tests for 'Download all attachments'.
[ticket/12938] Remove the 'Download all attachments' feature.
* develop-ascraeus:
[ticket/12718] Use a separate variable for sql query
[ticket/12718] Fix spacing and type casting
[ticket/12718] Fix docblocks
[ticket/12718] Add tests to check user_posts on post deletion
[ticket/12718] Update docblock
[ticket/12718] Use remove_topic_from_statistic() for delete_topic
[ticket/12718] Use remove_topic_from_statistic() for delete_topic
* dhruvgoel92/ticket/12718:
[ticket/12718] Use a separate variable for sql query
[ticket/12718] Fix spacing and type casting
[ticket/12718] Fix docblocks
[ticket/12718] Add tests to check user_posts on post deletion
[ticket/12718] Update docblock
[ticket/12718] Use remove_topic_from_statistic() for delete_topic
* develop-ascraeus:
[ticket/12710] Fix missing closing bracket
[ticket/12710] Prefix column so it does not start with a number
[ticket/12710] Pass the original column data to the create function
[ticket/12710] Fix foreach generation
[ticket/12710] Compare to uppercase version
[ticket/12710] Do not try to match the uniqueness in the query
[ticket/12710] Remove table_name from index_name before deleting and recreating them
[ticket/12710] Can not use upper in oracles where claus
[ticket/12710] Correctly select index name and compare to column name
[ticket/12710] Fix "ORA-00972: identifier is too long [972]" on oracle
[ticket/12710] Fix problems with creating unique indexes on oracle
[ticket/12710] Correctly fetch unique and normal indexes only in MSSQL
[ticket/12710] Fix changing the column type on oracle
[ticket/12710] Prepare get_existing_indexes() for other DBMS
* github-nickvergessen/ticket/12710:
[ticket/12710] Fix missing closing bracket
[ticket/12710] Prefix column so it does not start with a number
[ticket/12710] Pass the original column data to the create function
[ticket/12710] Fix foreach generation
[ticket/12710] Compare to uppercase version
[ticket/12710] Do not try to match the uniqueness in the query
[ticket/12710] Remove table_name from index_name before deleting and recreating them
[ticket/12710] Can not use upper in oracles where claus
[ticket/12710] Correctly select index name and compare to column name
[ticket/12710] Fix "ORA-00972: identifier is too long [972]" on oracle
[ticket/12710] Fix problems with creating unique indexes on oracle
[ticket/12710] Correctly fetch unique and normal indexes only in MSSQL
[ticket/12710] Fix changing the column type on oracle
[ticket/12710] Prepare get_existing_indexes() for other DBMS
* develop-ascraeus:
[ticket/12841] Make config position default to after
[ticket/12841] Update comments in tests making after default
[ticket/12841] prefix function name with phpbb_
[ticket/12841] Add a tests for the new function
[ticket/12841] Fix white space issues reported by sniffer
[ticket/12841] Allow extensions to position new config vars
[ticket/12841] Allow extensions to position new config vars
* VSEphpbb/ticket/12841:
[ticket/12841] Make config position default to after
[ticket/12841] Update comments in tests making after default
[ticket/12841] prefix function name with phpbb_
[ticket/12841] Add a tests for the new function
[ticket/12841] Fix white space issues reported by sniffer
[ticket/12841] Allow extensions to position new config vars
The method will take care of the actual deletion process in the avatar manager.
Additionally, we'll be using a confirm box while deleting the avatar to prevent
users from accidentally deleting their avatars.
PHPBB3-12822
