Commit graph

21140 commits

Author SHA1 Message Date
Dhruv Goel
a50b0faf4a [feature/sphinx-fulltext-search] MOD by naderman installed in phpbb
PHPBB3-10946
2012-07-12 17:27:22 +05:30
Joas Schilling
c4c95fddaa [ticket/10982] Correctly check, whether data-overlay is set
PHPBB3-10982
2012-07-11 15:06:44 +02:00
Joas Schilling
4aabe0cd4d [ticket/10982] Remove overlay on first up/down move of forums in ACP
PHPBB3-10982
2012-07-11 14:54:31 +02:00
Joas Schilling
95298de5ae [ticket/10982] Allow setting dimming control overlay also as data-overlay
PHPBB3-10982
2012-07-11 14:53:50 +02:00
Joas Schilling
d883535b10 [ticket/10950] Remove deleted entries in tests instead of commenting them out
PHPBB3-10950
2012-07-11 13:05:36 +02:00
Joas Schilling
e68c1fb9e4 [ticket/10950] Use database count() and group by instead of doing that in php
PHPBB3-10950
2012-07-11 12:58:57 +02:00
Nathan
b25efd744d [ticket/8323] Only disable administrative deactivated accounts from receiving PMs
Allow other types of inactive accounts to receive PMs. Remove the banned PM error message and use the string saying they do not have permission (less translation)

PHPBB3-8323
2012-07-10 17:41:27 -05:00
Nathan
08bdebb0b5 [ticket/8323] Allow temporarily banned users to receive PMs, but not a notification
PHPBB3-8323
2012-07-10 16:38:07 -05:00
Nathan
33852e6251 [ticket/8323] Correct PM notification settings (only notify those who can receive them)
Also correcting the way it was setup for users to be able to receive PMs (do not allow administrators/moderators to send to banned, inactive, or non-standard users, that just doesn't make sense)

PHPBB3-8323
2012-07-10 16:07:12 -05:00
Nathan
07b9c1e2fd [ticket/8323] Cleanup viewtopic code (not sure how this mess happened)
PHPBB3-8323
2012-07-10 12:34:40 -05:00
Nathan
362ba43f18 [ticket/8323] Allow sending PMs to temporarily banned users
Added an argument to the phpbb_get_banned_user_ids() function to allow specifying a banned end time (default true for current functionality, false for only permanent bans, timestamp to find banned until a specified time)

PHPBB3-8323
2012-07-10 12:34:40 -05:00
Nathan
0f4956b280 [ticket/8323] Do not allow sending PMs to Inactive users
PHPBB3-8323
2012-07-10 12:34:39 -05:00
Nathan
6f4538c676 [ticket/8323] Hide the Send PM link if users cannot receive the PM
Updated memberlist/viewtopic to the new rules

PHPBB3-8323
2012-07-10 12:34:39 -05:00
Nathan
e6d4e9bbb9 [ticket/8323] Correcting the comment
PHPBB3-8323
2012-07-10 12:34:38 -05:00
Nathan
c38bb4254a [ticket/8323] Do not allow sending of Private Messages to users who are banned
PHPBB3-8323
2012-07-10 12:34:38 -05:00
Nathan
c53d7f0b62 [ticket/8323] Remove code used for testing
PHPBB3-8323
2012-07-10 12:34:38 -05:00
Nathan
05452b9ec0 [ticket/8323] Do not allow sending of Private Messages to users who do not have permission to read private messages
PHPBB3-8323
2012-07-10 12:34:37 -05:00
Patrick Webster
dd6955f833 [ticket/10978] Fix typo in prosilver ucp_groups_membership.html
PHPBB3-10978
2012-07-09 19:29:17 -05:00
Andreas Fischer
348d9b8829 Merge remote-tracking branch 'Fyorl/ticket/10941' into develop
* Fyorl/ticket/10941: (30 commits)
  [ticket/10941] Removed superfluous array
  [ticket/10941] File 'txt' now too big so changed tests to reflect that
  [ticket/10941] Added a comment to ensure tags stay uppercase
  [ticket/10941] Modified tearDown to use DirectoryIterator instead of glob
  [ticket/10941] Added tests/upload/fixture/copies to tracking
  [ticket/10941] Fixed form test test_too_large
  [ticket/10941] Replaced use of English with language system
  [ticket/10941] Renamed classes and filenames so that tests run
  [ticket/10941] Moved comment into markTestIncomplete parameter
  [ticket/10941] Removed manual includes of mock classes
  [ticket/10941] Added subdirectory for file operations
  [ticket/10941] Added some comments for clarification
  [ticket/10941] Fixed a failing test
  [ticket/10941] Rearranged tests into their own classes or methods
  [ticket/10941] Removed the incomplete mark as is_image is fixed
  [ticket/10941] Refactored tearDown to stop iterating over the directory.
  [ticket/10941] Refactored init_filespec to return new object.
  [ticket/10941] Minor typo fixes
  [ticket/10941] Changed assertTrue to assertEquals
  [ticket/10941] Now actually checks for the value of errors.
  ...
2012-07-09 15:10:36 +02:00
Fyorl
65d7aae2f3 [ticket/10941] Removed superfluous array
PHPBB3-10941
2012-07-09 14:08:21 +01:00
Fyorl
d046b25124 [ticket/10941] File 'txt' now too big so changed tests to reflect that
PHPBB3-10941
2012-07-09 14:08:21 +01:00
Fyorl
1b3589aae8 [ticket/10941] Added a comment to ensure tags stay uppercase
PHPBB3-10941
2012-07-09 14:08:21 +01:00
Fyorl
f470eee8ab [ticket/10941] Modified tearDown to use DirectoryIterator instead of glob
PHPBB3-10941
2012-07-09 14:08:21 +01:00
Fyorl
ae9b642b81 [ticket/10941] Added tests/upload/fixture/copies to tracking
PHPBB3-10941
2012-07-09 14:08:21 +01:00
Fyorl
c8059cf7e7 [ticket/10941] Fixed form test test_too_large
PHPBB3-10941
2012-07-09 14:08:20 +01:00
Fyorl
8d43a6e851 [ticket/10941] Replaced use of English with language system
PHPBB3-10941
2012-07-09 14:08:20 +01:00
Fyorl
e0b63df6a4 [ticket/10941] Renamed classes and filenames so that tests run
Also fixed some minor issues that weren't flagged before because
the tests were being ignored.

PHPBB3-10941
2012-07-09 14:08:20 +01:00
Fyorl
6a1c686025 [ticket/10941] Moved comment into markTestIncomplete parameter
PHPBB3-10941
2012-07-09 14:08:20 +01:00
Fyorl
9f3a02d475 [ticket/10941] Removed manual includes of mock classes
Also marked a test as incomplete even though this appears to be
ignored when actually running the tests.

PHPBB3-10941
2012-07-09 14:08:20 +01:00
Fyorl
580cec619b [ticket/10941] Added subdirectory for file operations
Also removed common.php as it was unnecessary.

PHPBB3-10941
2012-07-09 14:08:20 +01:00
Fyorl
d89af53f63 [ticket/10941] Added some comments for clarification
PHPBB3-10941
2012-07-09 14:08:20 +01:00
Fyorl
af8020b388 [ticket/10941] Fixed a failing test
Since the is_image change, the filespec class no longer trusts the
browser's reported mimetype and instead checks the file itself. Thus
pretending a text file had the mimetype of an image will no longer
fail, the file will simply not be treated as an image.

PHPBB3-10941
2012-07-09 14:08:20 +01:00
Fyorl
b65f08dd95 [ticket/10941] Rearranged tests into their own classes or methods
PHPBB3-10941
2012-07-09 14:08:19 +01:00
Fyorl
a4717ef525 [ticket/10941] Removed the incomplete mark as is_image is fixed
Had to remove one of the tests due to a small limitation with the
functional testing framework. May mark the test as incomplete again
pending further comments.

PHPBB3-10941
2012-07-09 14:08:19 +01:00
Fyorl
682757c1cb [ticket/10941] Refactored tearDown to stop iterating over the directory.
PHPBB3-10941
2012-07-09 14:08:19 +01:00
Fyorl
ff7e5d73f7 [ticket/10941] Refactored init_filespec to return new object.
Removed $filespec as a property of the filespec test and instead
just instantiate new objects.

PHPBB3-10941
2012-07-09 14:08:19 +01:00
Fyorl
61d74007a4 [ticket/10941] Minor typo fixes
Removed superfluous $user = null; that was left over from refactoring.

PHPBB3-10941
2012-07-09 14:08:19 +01:00
Fyorl
1bb64ab23e [ticket/10941] Changed assertTrue to assertEquals
PHPBB3-10941
2012-07-09 14:08:19 +01:00
Fyorl
19405a7f47 [ticket/10941] Now actually checks for the value of errors.
Uses phpbb_mock_lang to return the key used when setting errors to
allow that key to be checked for during tests rather than just checking
if any error was set.

PHPBB3-10941
2012-07-09 14:08:19 +01:00
Fyorl
943af957e6 [ticket/10941] Re-arranged dataProvidor methods to be near their callers
PHPBB3-10941
2012-07-09 14:08:19 +01:00
Fyorl
59a7b10f14 [ticket/10941] Added a comment explaining the incomplete test
PHPBB3-10941
2012-07-09 14:08:18 +01:00
Fyorl
f2bbbdaafa [ticket/10941] tearDown() now uses explicit file list
Instances of $it also renamed for clarity.

PHPBB3-10941
2012-07-09 14:08:18 +01:00
Fyorl
82ca2c8b08 [ticket/10941] Minor adjustments as per PR comments
Added some comments clarifying globals and lowercased fixture filenames

PHPBB3-10941
2012-07-09 14:08:18 +01:00
Fyorl
1233544c4a [ticket/10941] Marked broken test as incomplete
PHPBB3-10941
2012-07-09 14:08:18 +01:00
Fyorl
5693036bf9 [ticket/10941] Added functional tests for the fileupload class
NOTE: test_form_upload() is broken. Uploading files via Symfony fails to
retain $_FILES['fileupload']['type'] even if it set explicitely. This appears
to be a bug in Symfony. Since the current version of filespec::is_image()
relies on the mimetype, these tests will __fail__. filespec::is_image() has
been fixed in https://github.com/phpbb/phpbb3/pull/833 however.

PHPBB3-10941
2012-07-09 14:08:17 +01:00
Fyorl
dfef80f267 [ticket/10941] Unit tests for fileupload class added
PHPBB3-10941
2012-07-08 23:59:11 +01:00
Fyorl
fe4056c599 [ticket/10941] Finished filespec tests
PHPBB3-10941
2012-07-08 23:59:11 +01:00
Fyorl
d6bd8928b5 [ticket/10941] Minor adjustments as per PR comments
Switched from dirname(__FILE__) to just __DIR__.
Removed static definition from data provider methods.

PHPBB3-10941
2012-07-08 23:59:11 +01:00
Fyorl
33a13002af [ticket/10941] Unit tests for filespec class
PHPBB3-10941
2012-07-08 23:59:11 +01:00
Nils Adermann
9f0259c473 Merge remote-tracking branch 'github-bantu/ticket/10973' into develop
* github-bantu/ticket/10973:
  [ticket/10973] Drop all require_once for mocks. Use autoloading.
  [ticket/10973] Add autoloader for autoloading phpbb_mock_ in tests.

Conflicts:
	tests/bbcode/url_bbcode_test.php
	tests/text_processing/censor_text_test.php
2012-07-08 23:12:22 +02:00