Commit graph

3890 commits

Author SHA1 Message Date
Oleg Pudeyev
89c9c9d4b0 [ticket/10205] Cosmetic changes.
PHPBB3-10205
2012-12-04 21:22:33 -05:00
Andreas Fischer
d9f554fe03 Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/10716] Collect standard error from executed php process.
  [ticket/10716] Skip test if php is not in PATH.
  [ticket/10716] Exclude our dependencies from linting.
  [ticket/10716] Only lint on php 5.3+.
  [ticket/10716] php parse all php files as part of the test suite.
2012-12-05 01:20:01 +01:00
Oleg Pudeyev
29c4da6162 [ticket/10205] Add some columns to the empty fixture file for mssqlnative.
Supposedly it choked on the version without any columns thusly:

phpbb_dbal_connect_test::test_failing_connect
PDOException: SQLSTATE[HY090]: [Microsoft][ODBC Driver Manager] Invalid string or buffer length

PHPBB3-10205
2012-12-04 19:00:42 -05:00
Oleg Pudeyev
fb261e19ff [ticket/10716] Collect standard error from executed php process.
php executes everything via a shell. The standard error of this
top level shell is not captured by exec/shell_exec/popen/etc.
and there is no way to capture it. proc_open might work but it
is a nightmare to use and without multiplexing reads from
standard error and standard output it can deadlock.

Thus the solution in this commit. Put the command into a subshell
and redirect standard error to standard output for the subshell.

PHPBB3-10716
2012-12-04 18:52:27 -05:00
Oleg Pudeyev
8ea52b5619 [ticket/10716] Skip test if php is not in PATH.
PHPBB3-10716
2012-12-04 17:43:36 -05:00
Oleg Pudeyev
38d2868ba8 [ticket/10491] Move board installation into setup before class.
Functional posting test already assumed that board is installed
once per test case and not once per test.

PHPBB3-10491
2012-12-04 17:37:46 -05:00
Oleg Pudeyev
bdc3ddf2bc [ticket/10491] Set up functional tests sensibly.
PHPBB_FUNCTIONAL_URL goes into setup before class.

Drop PHPBB_FUNCTIONAL_URL check in board installation and
silent return if it is not set.

Take board installation out of constructor.

Install board in setup method.

PHPBB3-10491
2012-12-04 17:19:25 -05:00
Oleg Pudeyev
8897efe087 [ticket/10716] Exclude our dependencies from linting.
PHPBB3-10716
2012-12-04 16:42:58 -05:00
Oleg Pudeyev
2d3882c412 [ticket/10205] Delete stray return.
PHPBB3-10205
2012-12-04 16:32:57 -05:00
Oleg Pudeyev
f3c043a569 [ticket/10205] Test failed connection attempts.
PHPBB3-10205
2012-12-04 16:29:37 -05:00
Andreas Fischer
2fdd039e52 Merge remote-tracking branch 'p/ticket/10103' into develop
* p/ticket/10103:
  [ticket/10103] New and improved wording.
  [ticket/10103] Assert with messages.
  [ticket/10103] assertLessThan/assertGreaterThan.
  [ticket/10103] Inline assignment is bad?
  [ticket/10103] $rv had too few characters.
  [ticket/10103] Correct flock class documentation.
  [ticket/10103] Try a longer sleep for travis.
  [ticket/10103] Convert the rest of the tree to flock class.
  [ticket/10103] Test for flock lock class, with concurrency no less.
  [ticket/10103] Use flock lock class in messenger.
  [ticket/10103] Factor out flock lock class.
2012-12-04 20:26:43 +01:00
Oleg Pudeyev
4133fae99e [ticket/10716] Only lint on php 5.3+.
PHPBB3-10716
2012-12-04 13:58:14 -05:00
Oleg Pudeyev
e22dd7dfad [ticket/10103] Assert with messages.
PHPBB3-10103
2012-12-04 13:50:35 -05:00
Oleg Pudeyev
285feb49f8 [ticket/10103] assertLessThan/assertGreaterThan.
PHPBB3-10103
2012-12-04 13:47:57 -05:00
Oleg Pudeyev
a553cfbc30 [ticket/10103] Inline assignment is bad?
PHPBB3-10103
2012-12-04 13:46:01 -05:00
Marc Alexander
fb139a8820 [feature/avatars] Fix behavior of avatar manager and variables
The $force_all variable was only partially removed and the behavior was
not consistent in all files.

PHPBB3-10018
2012-12-04 15:12:04 +01:00
Andreas Fischer
d7a23df2d9 Merge remote-tracking branch 'p/ticket/9983' into develop
* p/ticket/9983:
  [ticket/9983] Make sql cache test into a black box.
2012-12-04 14:06:15 +01:00
Oleg Pudeyev
74093d0fd3 [ticket/11015] Fix functional test case.
PHPBB3-11015
2012-12-04 04:32:37 -05:00
Oleg Pudeyev
3687febdac [ticket/11015] Change more docblocks.
PHPBB3-11015
2012-12-04 04:29:31 -05:00
Oleg Pudeyev
af2887f3a7 [ticket/10716] php parse all php files as part of the test suite.
PHPBB3-10716
2012-12-04 03:34:51 -05:00
Oleg Pudeyev
cf3080b83e [ticket/9983] Correct incorrect markTestSkipped call.
PHPBB3-9983
2012-12-04 02:39:50 -05:00
Oleg Pudeyev
fc410e1cd0 [ticket/10103] Try a longer sleep for travis.
Apparently travis takes longer than half a second to fork php.

PHPBB3-10103
2012-12-04 02:38:57 -05:00
Oleg Pudeyev
f72e435759 [ticket/10103] Test for flock lock class, with concurrency no less.
PHPBB3-10103
2012-12-04 02:21:53 -05:00
Oleg Pudeyev
d93f582b04 [ticket/9983] Make sql cache test into a black box.
This makes it non-driver-specific and also makes it possible
to make prefix variable private on drivers.

PHPBB3-9983
2012-12-03 21:47:29 -05:00
Marc Alexander
fc4069f81d [feature/avatars] Use seperate function for retrieving all drivers
PHPBB3-10018
2012-12-04 00:59:37 +01:00
Andreas Fischer
db6b11a390 [ticket/9983] Also check generic APC enable/disable.
PHPBB3-9983
2012-12-03 14:37:57 +01:00
Andreas Fischer
2e851baab9 [ticket/9983] Use APC instead of apc in error messages.
PHPBB3-9983
2012-12-03 14:29:02 +01:00
Andreas Fischer
0b4b7e68a7 [ticket/9983] Skip tests if APC is not enabled for CLI.
PHPBB3-9983
2012-12-03 14:29:02 +01:00
Oleg Pudeyev
f2bee4b383 [ticket/9983] Test for apc cache driver.
PHPBB3-9983
2012-12-03 00:18:52 -05:00
Oleg Pudeyev
7d09b9b4bb [ticket/9983] Add phpbb prefix to global variables.
PHPBB3-9983
2012-12-02 23:57:37 -05:00
Oleg Pudeyev
df78c616aa [ticket/9983] Indeed, it is <?php.
PHPBB3-9983
2012-12-02 23:54:59 -05:00
Patrick Webster
720ef233b1 [ticket/11219] Only update sequences that are affected by a fixture
PHPBB3-11219
2012-12-01 22:34:03 -06:00
Marc Alexander
ce653db491 [feature/avatars] Remove unnecessary "implements" from foobar avatar
PHPBB3-10018
2012-12-02 01:22:42 +01:00
Marc Alexander
232fa5b588 [feature/avatars] Do not use gravatar avatar in tests
PHPBB3-10018
2012-12-02 01:19:10 +01:00
Oleg Pudeyev
dd36b128e8 [ticket/9983] Add a test for destroy.
PHPBB3-9983
2012-12-01 18:59:28 -05:00
Oleg Pudeyev
8595b1f560 [ticket/9983] Exercise exists also.
PHPBB3-9983
2012-12-01 18:57:09 -05:00
Oleg Pudeyev
d9e636fab0 [ticket/9983] Add a purge test.
PHPBB3-9983
2012-12-01 18:55:13 -05:00
Oleg Pudeyev
90bd7858fd [ticket/9983] Rename test methods.
PHPBB3-9983
2012-12-01 18:52:04 -05:00
Oleg Pudeyev
c3d1408c52 [ticket/9983] get/put cache test moved to a base class.
PHPBB3-9983
2012-12-01 18:49:27 -05:00
Marc Alexander
d771453b52 [feature/avatars] Add tests for avatar manager
PHPBB3-10018
2012-12-01 21:37:57 +01:00
Oleg Pudeyev
829b75e5c8 [ticket/9983] Create driver in setup in null driver test.
PHPBB3-9983
2012-12-01 15:06:32 -05:00
Oleg Pudeyev
1e3dff83b3 [ticket/9983] Split cache test into per-driver files.
PHPBB3-9983
2012-12-01 15:03:44 -05:00
Oleg Pudeyev
c852044d6e [ticket/9983] Add redis cache driver tests.
In order to not overwrite data in default redis store, at least
one of redis host or post must be explicitly specified.

Redis cache driver constructor has been modified to accept
host and port as parameters. This was not added to public API
as there are more parameters being passed via global constants.

PHPBB3-9983
2012-12-01 00:48:21 -05:00
Oleg Pudeyev
3a702084e4 Merge PR #974 branch 'bantu/ticket/10875' into develop
* bantu/ticket/10875:
  [ticket/10875] tests/cache/cache_test.php: Use single quotes where possible.
  [ticket/10875] Test for null cache driver and sql cache.
  [ticket/10875] Revise sql cache test.
  [ticket/10875] Must return query result on failure.
  [ticket/10875] More documentation.
  [ticket/10875] Spelling fix.
  [ticket/10875] Add docblocks for phpbb_cache_driver_interface
  [ticket/10875] Add comment about cache's sql_load() method.
  [ticket/10875] Fix logic in phpbb_cache_driver_file::sql_save().
  [ticket/10875] Fix phpbb_mock_cache::sql_save() to return $query_result.
  [ticket/10875] Fix return value of phpbb_cache_driver_null::sql_save().
  [ticket/10875] Remove useless assignment from phpbb_cache_driver_memory.
2012-11-30 20:44:51 -05:00
Andreas Fischer
e4d2ad6b27 [ticket/10875] tests/cache/cache_test.php: Use single quotes where possible.
PHPBB3-10875
2012-12-01 00:36:34 +01:00
Oleg Pudeyev
0c06ac466f [ticket/10875] Test for null cache driver and sql cache.
PHPBB3-10875
2012-11-30 12:28:13 -05:00
Oleg Pudeyev
7bba09811c [ticket/10875] Revise sql cache test.
Delete data from database before retrieving it from cache,
ensuring results come from cache.

PHPBB3-10875
2012-11-30 12:18:33 -05:00
Oleg Pudeyev
3e907265d5 [ticket/11095] Docs and tests for phpbb_build_hidden_fields_for_query_params.
PHPBB3-11095
2012-11-29 14:42:06 -05:00
Andreas Fischer
aa9aa28fa2 Merge remote-tracking branch 'p/ticket/11202' into develop
* p/ticket/11202:
  [ticket/11202] Fix comment char, use more descriptive comment.
  [ticket/11202] Add response assertions to file upload functional test.
2012-11-29 20:01:44 +01:00
Oleg Pudeyev
9c0a03f1d5 [ticket/11095] Python quoteattr port.
PHPBB3-11095
2012-11-29 12:05:52 -05:00