Commit graph

18570 commits

Author SHA1 Message Date
Michael Cullum
3a5843959c [ticket/10631] Fixing some extension admin issues found
PHPBB3-10631
2012-09-01 15:04:50 +01:00
Michael Cullum
e768d0066d [ticket/10631] Update extensions language file for some issues found
PHPBB3-10631
2012-09-01 15:04:48 +01:00
Michael Cullum
9cd0e09f5d [ticket/10631] Rename language file to extensions.php
PHPBB3-10631
2012-09-01 15:04:47 +01:00
Michael Cullum
913b3fb0c1 [ticket/10631] Changing Ext Admin List to conform to standards
PHPBB3-10631
2012-09-01 15:04:45 +01:00
Michael Cullum
85e871e902 [ticket/10631] Removing ?> at end of customisations language file
PHPBB3-10631
2012-09-01 15:04:43 +01:00
Michael Cullum
a51ef44447 [ticket/10631] Some rewording of extensions admin language
PHPBB3-10631
2012-09-01 15:04:41 +01:00
Michael Cullum
305b5fe939 [ticket/10631] Fixing some issues spotted in extensions admin
Removing whitespace, cast the items from the json file straight into template vars (not via variables) and fixing some double quotes to single quotes.

PHPBB3-10631
2012-09-01 15:04:39 +01:00
Michael Cullum
29a9f3e70d [ticket/10631] Update extensions admin language
Added details page information, added a new line at end of file and removed some whitespace.

PHPBB3-10631
2012-09-01 15:04:37 +01:00
Michael Cullum
8824ccb392 [ticket/10631] Add an extension details page
PHPBB3-10631
2012-09-01 15:04:35 +01:00
Michael Cullum
5e6b4c7192 [ticket/10631] Adding an extensions admin
PHPBB3-10631
2012-09-01 15:04:33 +01:00
Fyorl
1520130b27 [ticket/11045] Replaced __DIR__ with dirname(__FILE__)
PHPBB3-11045
2012-09-01 09:45:11 +08:00
Joas Schilling
3bc3cf6e00 [feature/soft-delete] Update column names in update script and add permissions
PHPBB3-9657
2012-08-30 23:05:28 +02:00
Joas Schilling
c03d692a98 [feature/soft-delete] Fix some more usages of _approved column names
PHPBB3-9657
2012-08-30 22:57:00 +02:00
Joas Schilling
625e7ef58a [feature/soft-delete] Update development scripts with new column names
PHPBB3-9657
2012-08-30 22:54:24 +02:00
Joas Schilling
a6d3432f8b [feature/soft-delete] Update search to use $post_visibility
Todo: Sphinx currently does not respect this setting at all.

PHPBB3-9657
2012-08-30 22:20:52 +02:00
Joas Schilling
5b54ec2d64 [feature/soft-delete] Try to fix search.php
at least it's running now, but the performance is not very good.

PHPBB3-9657
2012-08-30 19:47:16 +02:00
Joas Schilling
1c043254c0 [feature/soft-delete] Add get_visibility_sql_forums based on global
The resulting query is 4-times faster, as the forum_id IN () arrays are
smaller and we need less AND/OR to build the hole query. The main difference
between those two functions is, that this one takes an array of included ids and
the _global one takes an array of excluded ids.

PHPBB3-9657
2012-08-30 18:07:00 +02:00
Joas Schilling
df83f22b71 [feature/soft-delete] Fix copy-paste fail for database update on the index
PHPBB3-9657
2012-08-30 16:21:27 +02:00
Joas Schilling
a1e0690b6b [feature/soft-delete] Simplification part2: user can see all item visibilities
If the user can see all visibilities, we can simply leave out the query part,
instead of adding a bunch of ANDs.

PHPBB3-9657
2012-08-29 22:12:33 +02:00
Joas Schilling
44ed05f567 [feature/soft-delete] Simplify the query output if the user has m_restore
PHPBB3-9657
2012-08-29 19:30:33 +02:00
Joas Schilling
36c9f6aa87 [feature/soft-delete] Update posts and topics table with database_update.php
PHPBB3-9657
2012-08-29 19:11:33 +02:00
Joas Schilling
8a036fa3e4 [feature/soft-delete] Update restoring feature to use ajax if requested.
Also fixes the mcp as a hole:
- displayes a success message
- gives a link to the post, if only one was restored

PHPBB3-9657
2012-08-29 18:42:14 +02:00
Joas Schilling
b774c09c7f [feature/soft-delete] Use the variable which holds the correct item status
PHPBB3-9657
2012-08-29 17:50:14 +02:00
Joas Schilling
d9a93a9cdc [feature/soft-delete] Fix missing AND in query
PHPBB3-9657
2012-08-29 17:50:14 +02:00
Joas Schilling
910f1602cd [feature/soft-delete] Fix displaying of "deleted post" note in viewtopic
PHPBB3-9657
2012-08-29 17:50:14 +02:00
Joas Schilling
9300ff4c6e [feature/soft-delete] Remove imageset/ which was created by merge conflict
We don't have imagesets in 3.1 anymore.

PHPBB3-9657
2012-08-29 17:50:13 +02:00
Joas Schilling
9abfba5191 [feature/soft-delete] Fix the schema files to the correct line ends again
PHPBB3-9657
2012-08-29 17:50:13 +02:00
Joas Schilling
1935568c3e [feature/soft-delete] Fix typo in column name topic_visibility
PHPBB3-9657
2012-08-29 17:50:13 +02:00
Joas Schilling
5ff35ccf72 [feature/soft-delete] Use autoloading for content_visibility class
PHPBB3-9657
2012-08-29 17:50:12 +02:00
Josh Woody
1ab41f8dc6 [feature/soft-delete] Fix some small bugs
To wit: using non-existing constant POST_DELETED in posting.php; first test
post was initially unapproved; soft delete checkbox appeared at post time
Links pointing to the wrong place.

PHPBB3-9657
2012-08-29 17:50:12 +02:00
Josh Woody
f570558a8d [feature/soft-delete] Add a processor for action == restore in mcp_queue.php
Restoring a post within mcp_queue.php didn't do anything before this commit.  Now it does, by way of a function which is very similar to approve_post.

PHPBB3-9657
2012-08-29 17:50:12 +02:00
Josh Woody
a80cfafdd9 [feature/soft-delete] Rename phpbb_visibility class to phpbb_content_visibility
Rename the class to more accurately reflect what it does.

PHPBB3-9657
2012-08-29 17:50:11 +02:00
Josh Woody
6739375135 [feature/soft-delete] Add unit tests for the phpbb_visibility class
Add unit tests for the phpbb_visibility class.  Adjust the phpbb_visibility class to pass those unit tests.  The changes are pretty small, actually.

PHPBB3-9657
2012-08-29 17:50:11 +02:00
Josh Woody
fb13ab83e4 [feature/soft-delete] Implement the ability to soft-delete and restore posts
The soft delete feature seems to work.  Tests are pending.  A real icon is pending.  Add the permissions and the interface to soft-delete posts.  Also able to restore posts via the MCP queue

PHPBB3-9657
2012-08-29 17:50:11 +02:00
Josh Woody
c32d760806 [feature/soft-delete] I told you I was going to rename the class!
Rename topic_visibility class to phpbb_visibility. Also a bit of work to the class itself, mostly cleanup and adding the comments that I'd previously written.

PHPBB3-9657
2012-08-29 17:49:38 +02:00
Josh Woody
244f6e2ddc [feature/soft-delete] Correct some mistakes in e8d47
Notably: Uncomment the die() in create_schema_files, and add the class that makes everything tick.

PHPBB3-9657
2012-08-29 17:49:37 +02:00
Josh Woody
b8c55291ed [feature/soft-delete] Lay the groundwork for a soft-delete feature
So far, I've added no new functionality.  The biggest change here is adjusting the DB column names to "visibility" rather than "approved".  Some things here are pretty likely to change, for example the name and location of the topic_visibility class. Happy birthday phpBB :)

PHPBB3-9657
2012-08-29 17:49:37 +02:00
Fyorl
94c9d70298 [ticket/11045] Opening brace on its own line
PHPBB3-11045
2012-08-28 09:34:01 +01:00
Fyorl
83a5326077 [ticket/11045] Explicitely check for zlib and bz2
PHPBB3-11045
2012-08-28 09:33:40 +01:00
Fyorl
570502e4a3 [ticket/11045] Added tests for file conflicts
PHPBB3-11045
2012-08-28 09:33:31 +01:00
Fyorl
012c281743 [ticket/11045] Added unit tests for the compress class
PHPBB3-11045
2012-08-28 09:33:19 +01:00
Andreas Fischer
1128ff1e58 Merge remote-tracking branch 'mvinny/ticket/11065' into develop
* mvinny/ticket/11065:
  [ticket/11065] Close li tag on topic display options at MCP
2012-08-27 01:35:46 +02:00
Vinny
7cf49a810f [ticket/11065] Close li tag on topic display options at MCP
PHPBB3-11065
2012-08-26 20:24:53 -03:00
David King
02644c02b9 [feature/add_events] Added core.posting_modify_template_vars
Can be used to set template variables and such, as the template assignment
methods are not available to the modify_posting_paramters event.

PHPBB3-9550
2012-08-26 15:09:50 -04:00
Andreas Fischer
d0ce637251 Merge remote-tracking branch 'Fyorl/feature/attach-dl' into develop
* Fyorl/feature/attach-dl: (75 commits)
  [feature/attach-dl] Removed the use of some abbreviations
  [feature/attach-dl] Changed $files_added checks
  [feature/attach-dl] Renamed $post_id to $post_msg_id
  [feature/attach-dl] Fixed a comment
  [feature/attach-dl] Optimised an sql query
  [feature/attach-dl] Fixed the logic in an sql statement
  [feature/attch-dl] $forum_id cast to int
  [feature/attach-dl] Fixed $file_added to $files_added
  [feature/attach-dl] Moved definition of $archive_name
  [feature/attach-dl] Swapped the order of an if statement
  [feature/attach-dl] Cast variables to int
  [feature/attach-dl] Added $archive_path
  [feature/attach-dl] Used COMMA_SEPARATOR instead of actual comma
  [feature/attach-dl] Renamed $count to $files_added
  [feature/attach-dl] Removed sprintf() use
  [feature/attach-dl] Removed need for array_keys()
  [feature/attach-dl] Added multiple attachment downloads to PMs
  [feature/attach-dl] Removed reliance on current($row)
  [feature/attach-dl] Renamed to phpbb_download_handle_forum_auth
  [feature/attach-dl] Moved PM authentication handling into own function
  ...
2012-08-26 18:56:09 +02:00
Andreas Fischer
c83ca457a0 [ticket/11069] Add closing span back to credit line in subsilver2 simple footer
Regression from 0ceb77fb99.

PHPBB3-11069
2012-08-26 17:20:45 +02:00
Nils Adermann
18039cfa6a Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/11066] Remove debug code error_reporting(E_ALL) from mssqlnative.php
2012-08-26 15:22:12 +02:00
Nils Adermann
4db4731fff Merge remote-tracking branch 'github-bantu/ticket/11066' into develop-olympus
* github-bantu/ticket/11066:
  [ticket/11066] Remove debug code error_reporting(E_ALL) from mssqlnative.php
2012-08-26 15:22:04 +02:00
Nils Adermann
90d26bb946 Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/11060] Backport ca4cee86af to olympus.

Conflicts:
	.travis.yml
2012-08-26 15:20:04 +02:00
Nils Adermann
a3d87a1443 Merge remote-tracking branch 'github-bantu/ticket/11060' into develop-olympus
* github-bantu/ticket/11060:
  [ticket/11060] Backport ca4cee86af to olympus.
2012-08-26 15:16:08 +02:00