Commit graph

2553 commits

Author SHA1 Message Date
Joas Schilling
5f56804a96 [ticket/11277] Correctly remove user_dst column on database update
The db_tools is running in "return statement" mode, so the queries to
modify the data are not executed, but just returned.

PHPBB3-11277
2012-12-21 15:29:54 +01:00
Joas Schilling
e34b8ed094 Merge branch 'develop' of https://github.com/phpbb/phpbb3 into feature/softdelete-1-permission-rebase
* 'develop' of https://github.com/phpbb/phpbb3: (544 commits)
  [feature/events] Fix improperly named event in documentation
  [feature/events] Fix alphabetization of events
  [feature/events] Put events in alphabetical order
  [feature/events] Make EVENTS.md lowercase
  [ticket/11285] Use more granularity in dependency checks in compress test
  [ticket/10880] The m_approve permisson no longer implies f_noapprove.
  [ticket/10803] Show failure message until user dismisses it
  [ticket/10954] Add missing semi-colon
  [ticket/10954] Make sure to mark subforums unread and add small fixes
  [feature/events] Use ` to escape HTML tags in markdown
  [feature/events] Remove HTML tags from markdown so they don't get parsed
  [ticket/10954] Miscellaneous coding fixes
  [feature/events] Remove extraneous space
  [feature/events] Add markdown template event documentation file
  [feature/events] forumlist_body_last_post_title_after -> _prepend (subsilver2)
  [feature/events] Fix overall_footer_end -> overall_footer_after (subsilver2)
  [feature/events] Fix typo in event name
  [ticket/10763] Use self when calling get_extension() in filespec class
  [feature/events] Fix more subsilver2 events
  [feature/events] Fix some subsilver2 events
  ...

Conflicts:
	phpBB/install/database_update.php
	phpBB/posting.php
2012-12-20 22:51:38 +01:00
Joas Schilling
70a409d4b5 [feature/soft-delete] Remove *_restore permissions from the update/install
We decided to use only m_approve for now.

PHPBB3-9657
2012-12-20 22:39:38 +01:00
Joas Schilling
f0c780a453 [ticket/11278] Fix not running queries from db tools in database update
The db_tools class is running in return mode, which means that the queries
are not run, but just returned. Therefor the broken tables were not
removed from the database.

PHPBB3-11278
2012-12-19 13:38:16 +01:00
Joas Schilling
6028068841 [feature/soft-delete] Actually run schema changing queries in database update
$db_tools is running in return statement mode, so all queries are not
actually run, but just created.

PHPBB3-9657
2012-12-19 12:33:00 +01:00
Joas Schilling
73e59ac544 [feature/soft-delete] Make update file runnable again
This should not really be a problem, as if the column does not exist, all
topics should be localised before anyway. If not, the user created an
old global announcement, after updating it.

PHPBB3-9657
2012-12-19 11:47:08 +01:00
Nathan Guse
8dc2f69e8a [ticket/11103] remove is_enabled
PHPBB3-11103
2012-12-15 22:08:10 -06:00
Nathan Guse
eeb4018195 [ticket/11103] data -> notification_data
PHPBB3-11103
2012-12-15 22:08:10 -06:00
Nathan Guse
fad6bc5a7e [ticket/11103] unread -> notification_read
PHPBB3-11103
2012-12-15 22:06:32 -06:00
Nathan Guse
47bed33216 [ticket/11103] time -> notification_time
PHPBB3-11103
2012-12-15 22:02:16 -06:00
Nathan Guse
f47e51d6de [ticket/11103] Move is_enabled to a separate table for better performance
PHPBB3-11103
2012-12-15 19:18:26 -06:00
Oleg Pudeyev
5c496674f6 [ticket/10758] Dependency inject parameters into cache_moderators.
Also add phpbb prefix since the signature is being changed anyway.

PHPBB3-10758
2012-12-15 16:50:28 -05:00
Nathan Guse
25895bd5c3 [ticket/11103] Fix missing ), in database_update.php
PHPBB3-11103
2012-12-13 23:19:10 -06:00
Nathan Guse
bec05a11f3 [ticket/11103] Add constants for the tables
PHPBB3-11103
2012-12-13 19:56:39 -06:00
Nathan Guse
1cdb0ecbf2 [ticket/11103] Add global $table_prefix
I have no idea how this worked previously...

PHPBB3-11103
2012-12-13 19:32:11 -06:00
Nathan Guse
d64eb0e575 Merge branch 'develop' of github.com:phpbb/phpbb3 into ticket/11103
# By Oleg Pudeyev (21) and others
# Via Andreas Fischer (7) and others
* 'develop' of github.com:phpbb/phpbb3: (56 commits)
  [ticket/11015] Move comment in the right place.
  [ticket/11015] Correctly transform 'mysqli' etc. in phpbb_convert_30_dbms_to_31
  [ticket/11015] Fix 3.0 to 3.1 dbms conversion for mysqli.
  [ticket/11015] Change permission adding in database updater to new style.
  [ticket/11015] Change more docblocks to phpbb_db_driver.
  [ticket/11015] Installer still needs 3.0-style dbms name.
  [ticket/11262] Add .lock in cache directory to .gitignore
  [ticket/11015] Include functions.php because it is not always included.
  [ticket/11265] Add assertions for board installation success.
  [ticket/11263] Fix PHP Notice: Undefined variable: extension_manager
  [ticket/11015] Convert database drivers to new spelling in post setup sync.
  [ticket/11015] Convert connect test to the new syntax.
  [ticket/11015] Restore whitespace to avoid conflict when merging develop.
  [ticket/10975] Add a test for viewing a profile.
  [ticket/10975] Test restricting by first character.
  [ticket/10975] Avoid rewriting global config twice.
  [ticket/10975] Test memberlist, not user creation.
  [ticket/10975] Some quick tests to check the memberlist behaviour
  [ticket/10491] Make recreate_database static.
  [ticket/11088] Pass required objects in as arguments
  ...

Conflicts:
	phpBB/install/database_update.php
2012-12-13 19:21:29 -06:00
Oleg Pudeyev
1a1ae1b663 [ticket/11015] Change permission adding in database updater to new style.
PHPBB3-11015
2012-12-13 18:00:29 -05:00
Oleg Pudeyev
aae7a81270 Merge remote-tracking branch 'upstream/develop' into ticket/11015
* upstream/develop: (101 commits)
  [ticket/10491] Make recreate_database static.
  [ticket/11088] Pass required objects in as arguments
  [ticket/11088] Globalize objects in new permission function
  [ticket/11088] Move permission creation to a function
  [ticket/11088] Copy a_styles permission for a_extensions
  [ticket/11088] Remove extraneous word from sentence in comment
  [ticket/11088] Changed "file extensions" to "attachment extensions"
  [ticket/11088] Fix the database updater to correctly manipulate the modules
  [ticket/11088] Put language pack module move below extension module creation
  [ticket/11088] Untested, progress on update script
  [ticket/11088] Fix typo (period instead of comma)
  [ticket/11088] Untested progress for update script
  [ticket/11088] Added missing comma
  [ticket/11088] Removed added space
  [ticket/11088] Move style, extension and language pack management to customise
  [ticket/11243] Show download all link on all pages of topic with attachments
  [feature/template-events] Pass arguments in correct order.
  [feature/template-events] Pass arguments in correct order.
  [ticket/10491] Install board once per test run.
  [ticket/11257] Do not require set_name() method to exist
  ...
2012-12-13 07:56:40 -05:00
David King
a5783211c9 [ticket/11088] Pass required objects in as arguments
PHPBB3-11088
2012-12-12 20:19:06 -05:00
David King
5fc6752178 [ticket/11088] Globalize objects in new permission function
PHPBB3-11088
2012-12-12 20:04:20 -05:00
David King
13f8e64a33 [ticket/11088] Move permission creation to a function
PHPBB3-11088
2012-12-12 20:01:58 -05:00
David King
8e4c1526fc [ticket/11088] Copy a_styles permission for a_extensions
PHPBB3-11088
2012-12-12 19:39:48 -05:00
David King
61adfa5026 [ticket/11088] Remove extraneous word from sentence in comment
PHPBB3-11088
2012-12-12 19:37:39 -05:00
Nathaniel Guse
7ae5b62fc6 Merge branch 'develop' of git://github.com/phpbb/phpbb3 into ticket/11103 2012-12-12 16:30:50 -06:00
David King
70aea6fd7c [ticket/11088] Fix the database updater to correctly manipulate the modules
PHPBB3-11088
2012-12-12 12:48:27 -05:00
David King
80f68c358f [ticket/11088] Put language pack module move below extension module creation
PHPBB3-11088
2012-12-12 11:40:47 -05:00
David King
30c64f6a01 [ticket/11088] Untested, progress on update script
This should rename Styles category to Customise, move language packs, and add extension management

PHPBB3-11088
2012-12-12 11:40:46 -05:00
David King
72d1a210de [ticket/11088] Fix typo (period instead of comma)
PHPBB3-11088
2012-12-12 11:40:43 -05:00
David King
e58c6536f0 [ticket/11088] Untested progress for update script
PHPBB3-11088
2012-12-12 11:39:17 -05:00
David King
e2aef2bfd1 [ticket/11088] Added missing comma
PHPBB3-11088
2012-12-12 11:39:16 -05:00
David King
4980d8b011 [ticket/11088] Move style, extension and language pack management to customise
Instead of being separated, these related ACP modules are now grouped
intuitively.

PHPBB3-11088
2012-12-12 11:39:14 -05:00
Nathan Guse
61391f648c [ticket/11259] htmlspecialchars($phpbb_admin_path)
PHPBB3-11259
2012-12-10 21:16:08 -06:00
David King
a9db155c28 Merge remote-tracking branch 'p/feature/template-events' into develop
# By Oleg Pudeyev (36) and others
# Via Oleg Pudeyev
* p/feature/template-events: (47 commits)
  [feature/template-events] Pass arguments in correct order.
  [feature/template-events] Order extensions in mock extension manager.
  [feature/template-events] Changes per imkingdavid's review.
  [feature/template-events] Make style names private on template.
  [feature/template-events] Test for event that is defined in parent style only.
  [feature/template-events] Specify style names, add inheritance tests.
  [feature/template-events] Normalize expected directory trees.
  [feature/template-events] Allow dataset to be correctly selectable.
  [feature/template-events] Dataset for template event testing with inheritance.
  [feature/template-events] Use style names array in template filter.
  [feature/template-events] Generate style names array in set_style.
  [feature/template-events] Convert a single style name to array of them.
  [feature/template-events] Chase dependency injection for template context.
  [feature/template-events] Adjust template events test to use the dataset.
  [feature/template-events] Create a dataset for template event tests.
  [feature/template-events] Indentation fix.
  [feature/template-events] Cosmetic changes.
  [feature/template-events] Wording: wrongly -> improperly.
  [feature/template-events] Indentation fix.
  [feature/template-events] Rename template_name to style_name.
  ...
2012-12-10 14:09:10 -05:00
Nathan Guse
30de17f69f [ticket/11259] adm_relative_path -> phpbb_adm_relative_path
We can assume they properly format their config settings, right?

PHPBB3-11259
2012-12-09 19:29:51 -06:00
Nathan Guse
6dee253941 [ticket/11259] Make phpbb_admin_path available everywhere
PHPBB3-11259
2012-12-09 17:01:08 -06:00
Marc Alexander
1aae72961a Merge branch 'develop' into feature/avatars
Conflicts:
	phpBB/install/database_update.php
2012-12-09 21:02:31 +01:00
Nathan Guse
0d6c8f46ff [ticket/11103] Update indexes on notifications/user notifications tables
PHPBB3-11103
2012-12-08 14:12:25 -06:00
Nathan Guse
0042f07147 Merge branch 'develop' of github.com:EXreaction/phpbb3 into ticket/11103
Conflicts:
	phpBB/install/database_update.php
	phpBB/styles/prosilver/template/ucp_prefs_personal.html
	phpBB/styles/subsilver2/template/ucp_prefs_personal.html
2012-12-07 21:14:39 -06:00
Bruno Ais
9eecaa21e3 [ticket/11171] Moved the DB schema changes to its place
Moved the db changes schema to the place where all the other
schema changes are.

PHPBB3-11171
2012-12-07 15:05:07 +00:00
Joas Schilling
c23d2457e9 [ticket/10679] Update module basename, we added the xcp_ prefix in 3.1
PHPBB3-10679
2012-12-07 12:50:21 +01:00
Bruno Ais
25780c17a4 [ticket/11171] DB changes for the update
These are the changes to database_update.php required for
this ticket.

PHPBB3-11171
2012-12-07 08:52:14 +00:00
Oleg Pudeyev
26fd70d9cd Merge remote-tracking branch 'upstream/develop' into ticket/11015
* upstream/develop: (196 commits)
  [ticket/11219] Coding guidelines and naming consistency changes
  [ticket/10841] Revert more whitespace changes.
  [ticket/10841] Revert whitespace changes.
  [ticket/10841] adding space after if
  [ticket/10841] removing unnecessary spacing
  [ticket/10841] changing affectedrows check to COUNT in sql
  [ticket/10841] Modifying style and language selectors in UCP
  [ticket/11247] Fix wrong property reference in flock class.
  [ticket/10602] Avoid a race condition.
  [ticket/10602] Use last_queue_run for its intended purpose.
  [ticket/10716] Collect standard error from executed php process.
  [ticket/10716] Skip test if php is not in PATH.
  [ticket/10716] Exclude our dependencies from linting.
  [ticket/10103] New and improved wording.
  [ticket/10716] Only lint on php 5.3+.
  [ticket/10103] Assert with messages.
  [ticket/10103] assertLessThan/assertGreaterThan.
  [ticket/10103] Inline assignment is bad?
  [ticket/10103] $rv had too few characters.
  [ticket/10103] Correct flock class documentation.
  ...

Conflicts:
	phpBB/includes/functions.php
	tests/cache/cache_test.php
2012-12-06 21:49:24 -05:00
Joas Schilling
2f490293e4 [ticket/10679] Use module_auth to limit access to the module
PHPBB3-10679
2012-12-06 16:33:12 +01:00
Joas Schilling
4103c99a86 [ticket/10679] Add new permission for changing profile field information
The setting is copied from "Can use signature"

PHPBB3-10679
2012-12-06 15:10:29 +01:00
Joas Schilling
b4db972840 Merge branch 'develop' of https://github.com/phpbb/phpbb3 into ticket/10411-2
* 'develop' of https://github.com/phpbb/phpbb3: (204 commits)
  [ticket/11219] Coding guidelines and naming consistency changes
  [ticket/10841] Revert more whitespace changes.
  [ticket/10841] Revert whitespace changes.
  [ticket/10841] adding space after if
  [ticket/10841] removing unnecessary spacing
  [ticket/10841] changing affectedrows check to COUNT in sql
  [ticket/10841] Modifying style and language selectors in UCP
  [ticket/11247] Fix wrong property reference in flock class.
  [ticket/10602] Avoid a race condition.
  [ticket/10602] Use last_queue_run for its intended purpose.
  [ticket/10716] Collect standard error from executed php process.
  [ticket/10716] Skip test if php is not in PATH.
  [ticket/10716] Exclude our dependencies from linting.
  [ticket/10103] New and improved wording.
  [ticket/10716] Only lint on php 5.3+.
  [ticket/10103] Assert with messages.
  [ticket/10103] assertLessThan/assertGreaterThan.
  [ticket/10103] Inline assignment is bad?
  [ticket/10103] $rv had too few characters.
  [ticket/10103] Correct flock class documentation.
  ...

Conflicts:
	phpBB/config/services.yml
	phpBB/includes/groupposition/legend.php
2012-12-06 14:26:14 +01:00
Bruno Ais
9b018bd460 [ticket/11171] DB additions for these changes
Made the required changes to develop/create_schema_files.php
and this is what resulted of that.

PHPBB3-11171
2012-12-05 16:39:29 +00:00
Oleg Pudeyev
21caf6db6f Merge PR #545 branch 'brunoais/ticket/10601' into develop
* brunoais/ticket/10601:
  [ticket/10601] The ORDER BY is only taking space there
  [ticket/10601] New approach in the update algorithm
  [ticket/10601] Comment to help understanding the code
  [ticket/10601] Requested code changes
  [ticket/10601] Cosmetic code changes
  [ticket/10601] Database updating code v2
  [ticket/10601] Database updating code
  [ticket/10601] Comment explaning the basename applied to categories
  [ticket/10601] Correctly access class property
  [ticket/10601]Move Inbox the default in private messages module
2012-12-01 15:09:38 -05:00
Bruno Ais
1ce0671181 [ticket/10601] The ORDER BY is only taking space there
PHPBB3-10601
2012-12-01 10:05:20 +00:00
Oleg Pudeyev
7a77edf25e Merge PR #893 branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/10184] Query bots table to get the user_ids of the bots
  [ticket/10184] Disable receiving pms for bots by default
2012-12-01 04:55:48 -05:00
Joas Schilling
ad2d560f3f [ticket/10184] Query bots table to get the user_ids of the bots
PHPBB3-10184
2012-12-01 10:54:26 +01:00