Commit graph

2829 commits

Author SHA1 Message Date
marc1706
98aebabd73 [ticket/12071] Add test that covers not available fileinfo
The newly added test case will also emulate a non-existing fileinfo
in order to check if the mimetype guesser is properly working when
fileinfo is not available.

PHPBB3-12071
2014-01-03 16:40:12 +01:00
marc1706
f111a9262f [ticket/12071] Get rid of unneeded cast to boolean in tests
PHPBB3-12071
2014-01-03 13:45:38 +01:00
marc1706
8ebf5bb8d1 [ticket/12071] Skip tests that depend on fileinfo and fix expected results
Tests that depend on fileinfo being enabled will now be skipped to prevent
fatal errors while running the test suite. The expected results will be
modified to "application/octet-stream" in test_guess_files() if only the
extension_guesser is available due to the non-existing extension of those
files.

PHPBB3-12071
2014-01-03 13:30:52 +01:00
Nathan Guse
c6491c9078 [ticket/11881] Fix test filename
PHPBB3-11881
2013-12-30 14:27:13 -06:00
Nathan Guse
6ab12c1779 [ticket/12006] Test for ext module auth
PHPBB3-12006
2013-12-30 12:32:48 -06:00
Marc Alexander
382317b135 Merge branch 'develop' of https://github.com/phpbb/phpbb into feature/passwords
Conflicts:
	phpBB/config/services.yml
2013-12-29 13:46:42 +01:00
Marc Alexander
f906fb41e9 [ticket/11997] Use functional test cases that should always work
The previous test cases that tried to redirect to ../index.php and similar
might cause us to try to go to http://localhost/../index.php, which will
result in http://index.php. As this obviously will trigger an error as
intended, we should not put this inside our test cases for the redirect
function.

PHPBB3-11997
2013-12-28 20:40:18 +01:00
Marc Alexander
3e815616c5 [ticket/11997] Fix redirect tests for mod rewrite
Controller routes that are supposed to link to parent directories can't be
tested as the links are incorrectly created depending on enabled mod rewrite
or not.

PHPBB3-11997
2013-12-28 16:50:15 +01:00
Marc Alexander
4c1569dd8a [ticket/11997] Add user's page dir to redirect path and fix unit tests for it
The user's page directory needs to be added to the redirect URL for proper
redirects outside of the forum root. Fix the unit tests accordingly.

PHPBB3-11997
2013-12-28 00:14:12 +01:00
Marc Alexander
68ce16f9b3 [ticket/11997] Use path_helper in in foo/bar extension for redirect URLs
By using path_helper's clean_url() method, we'll be able to properly check
the full URL instead of just parts of the expected URL.

PHPBB3-11997
2013-12-27 17:55:14 +01:00
Marc Alexander
9161816267 [ticket/11997] Do not check if file or dir we redirect to exist
The redirect function will now properly redirect to where we want it to.
It will no longer try to check if the file or directory we redirect to exist.
This will ensure compatibility with the new routes.

PHPBB3-11997
2013-12-27 13:00:22 +01:00
Dhruv
f9c7f0fc19 Merge remote-tracking branch 'nickvergessen/feature/pagination-class' into develop
# By Joas Schilling
# Via Joas Schilling
* nickvergessen/feature/pagination-class:
  [ticket/11849] Fix more function calls
  [ticket/11849] Update more MCP calls to pagination class
  [ticket/11849] Update some ACP modules with new pagination
  [ticket/11849] Update rest of the UCP modules
  [ticket/11849] Update UCP notifications and pm folder
  [ticket/11849] Update search and memberlist
  [ticket/11849] Update pagination in viewonline.php
  [ticket/11849] Remove old pagination test
  [ticket/11849] Update pagination code in viewtopic.php
  [ticket/11849] Replace pagination in viewforum.php with class
  [ticket/11849] Add service definition
  [ticket/11849] Remove pagination functions
  [ticket/11849] Test validate_start and on_page
  [ticket/11849] Move pagination code to class
2013-12-25 00:54:07 +05:30
Marc Alexander
4ced162646 [ticket/11997] Modifiy tests after adding path_helper clean_url method
PHPBB3-11997
2013-12-21 20:08:33 +01:00
Marc Alexander
d9358c26da [ticket/11997] Add clean_url() method to path_helper
This method will get rid of unnecessary . and .. in URLs.

PHPBB3-11997
2013-12-21 20:08:00 +01:00
Marc Alexander
235d2069e0 [ticket/11997] Allow redirects to parent folders like previously
Redirects to parent folders were possible with the previous redirect function.
This change will allow these redirects again.

PHPBB3-11997
2013-12-21 16:31:20 +01:00
Marc Alexander
15913fdf79 [ticket/11997] Move expected redirect returns to controller and output to HTML
The controller will now output the expected redirect returns the same way the
redirect returns are output. The extension controller test will compare those
2 outputs.

PHPBB3-11997
2013-12-20 18:13:53 +01:00
Joas Schilling
a836a107ca [ticket/11849] Remove old pagination test
PHPBB3-11849
2013-12-18 18:35:32 +01:00
Joas Schilling
725c512468 [ticket/11849] Replace pagination in viewforum.php with class
PHPBB3-11849
2013-12-18 18:35:16 +01:00
Joas Schilling
ed16fbd5b7 [ticket/11849] Test validate_start and on_page
PHPBB3-11849
2013-12-18 18:34:49 +01:00
Joas Schilling
268afe20f4 [ticket/11849] Move pagination code to class
PHPBB3-11849
2013-12-18 18:34:13 +01:00
Joas Schilling
4a73ce0933 Merge remote-tracking branch 'prototech/ticket/12009' into develop
* prototech/ticket/12009:
  [ticket/12009] Prevent user from enabling invalid extension through direct URL
  [ticket/12009] Update functional test to check for invalid extensions.
  [ticket/12009] Fix functional tests.
  [ticket/12009] Move valid extensions in tests to correct dir structure.
  [ticket/12009] Do not allow incorrectly structured extensions to be installed.
2013-12-16 10:18:56 +01:00
Cesar G
c42bd28d17 [ticket/12009] Prevent user from enabling invalid extension through direct URL
PHPBB3-12009
2013-12-12 14:40:03 -08:00
Cesar G
2735982c55 [ticket/12009] Update functional test to check for invalid extensions.
PHPBB3-12009
2013-12-12 13:03:04 -08:00
Cesar G
495ded59f3 [ticket/12009] Fix functional tests.
PHPBB3-12009
2013-12-12 12:24:16 -08:00
Cesar G
31234b26d8 [ticket/12009] Move valid extensions in tests to correct dir structure.
PHPBB3-12009
2013-12-12 10:52:51 -08:00
Joas Schilling
4816446c4a Merge remote-tracking branch 'Marc/ticket/11859' into develop
* Marc/ticket/11859:
  [ticket/11859] Add missing get_template_name method to test drivers
  [ticket/11859] Make avatar drivers return template filename
2013-12-12 10:21:36 +01:00
Marc Alexander
47ea6bc9e6 Merge branch 'develop' of https://github.com/phpbb/phpbb into ticket/11997
Conflicts:
	tests/functional/fixtures/ext/foo/bar/config/services.yml
2013-12-07 13:32:19 +01:00
Marc Alexander
f32a30eeca [ticket/11997] Fix tests for path_helper's get_controller_redirect_url()
PHPBB3-11997
2013-12-07 13:28:44 +01:00
Nathan Guse
1d243b78bb Merge pull request #1813 from marc1706/ticket/11912
[ticket/11912] Add mimetype guesser for proper mimetype guessing
2013-12-04 14:12:25 -08:00
Nathan Guse
97bf88dd32 Merge pull request #1879 from Pico88/ticket/12026
[ticket/12026] Correct path for template files
2013-12-04 13:59:59 -08:00
Nathan Guse
e399a52816 Merge pull request #1887 from nickvergessen/ticket/skouat/10910
[ticket/10910] Function build_cfg_template() allow $size for $tpl_type = select
2013-12-04 09:48:10 -08:00
Joas Schilling
b474917ba3 Merge remote-tracking branch 'Marc/ticket/11842' into develop
* Marc/ticket/11842:
  [ticket/11842] Add functional test for creating group
  [ticket/11842] Use avatar_data for obtaining driver that should be deleted
  [ticket/11842] Use type map for updating avatar types in database
  [ticket/11842] Add missing prefix for group id in avatar data
  [ticket/11842] Use only new avatar type in user_delete function
  [ticket/11842] Add migration file for updating avatar type in database
  [ticket/11842] Replace outdated occurences of user and group avatar_type
  [ticket/11842] Use group_id 0 and correct avatar name after creating group
2013-12-04 17:20:20 +01:00
Joas Schilling
fa33abaf0d Merge remote-tracking branch 'bantu/ticket/12056-develop' into develop
* bantu/ticket/12056-develop:
  [ticket/12056] group_user_attributes: Fix "Creating ... from empty value".
  [ticket/12056] Fix "Call to undefined function ...\utf8_normalize_nfc()"
  [ticket/12056] Fix "Call to undefined function ...\utf8_clean_string()"
  [ticket/12056] Fix "Call to a member function trigger_event() on a non-object".
  [ticket/12056] Fix "Call to undefined function phpbb\phpbb_get_plural_form()".
  [ticket/12056] Fix "undefined function phpbb_pcre_utf8_support()".
  [ticket/12056] validate_config_vars: Fix ".. undefined function utf8_strlen()"
  [ticket/12056] validate_config_vars: Fix "Creating ... from empty value".
  [ticket/12056] validate_range: Fix "Creating default object from empty value"
  [ticket/12056] build_select: Fix "Creating default object from empty value"
  [ticket/12056] h_radio test: Fix "Creating default object from empty value"
2013-12-04 16:01:32 +01:00
Marc Alexander
80fa658e8f [ticket/11842] Add functional test for creating group
PHPBB3-11842
2013-12-04 15:58:07 +01:00
Joas Schilling
8087a76c36 Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/12056] Fix failure due to "Creating default object from empty value".
2013-12-04 15:57:25 +01:00
Marc Alexander
abb2def48d [ticket/11842] Use avatar_data for obtaining driver that should be deleted
PHPBB3-11842
2013-12-04 15:42:17 +01:00
Andreas Fischer
3a03b01ce0 [ticket/12056] group_user_attributes: Fix "Creating ... from empty value".
PHPBB3-12056
2013-12-04 14:22:33 +01:00
Andreas Fischer
ffc24a507d [ticket/12056] Fix "Call to undefined function ...\utf8_normalize_nfc()"
PHPBB3-12056
2013-12-04 14:16:10 +01:00
Andreas Fischer
d589696827 [ticket/12056] Fix "Call to undefined function ...\utf8_clean_string()"
PHPBB3-12056
2013-12-04 14:13:59 +01:00
Andreas Fischer
b41781ed64 [ticket/12056] Fix "Call to a member function trigger_event() on a non-object".
PHPBB3-12056
2013-12-04 13:51:42 +01:00
Andreas Fischer
d63ac61b19 [ticket/12056] Fix "Call to undefined function phpbb\phpbb_get_plural_form()".
PHPBB3-12056
2013-12-04 13:46:51 +01:00
Andreas Fischer
417fddf710 [ticket/12056] Fix "undefined function phpbb_pcre_utf8_support()".
PHPBB3-12056
2013-12-04 13:44:33 +01:00
Andreas Fischer
7e160e4fc0 [ticket/12056] validate_config_vars: Fix ".. undefined function utf8_strlen()"
PHPBB3-12056
2013-12-04 13:37:56 +01:00
Andreas Fischer
0f41241273 [ticket/12056] validate_config_vars: Fix "Creating ... from empty value".
PHPBB3-12056
2013-12-04 13:36:23 +01:00
Andreas Fischer
70e47bc929 [ticket/12056] validate_range: Fix "Creating default object from empty value"
PHPBB3-12056
2013-12-04 13:33:19 +01:00
Andreas Fischer
c07b44716c [ticket/12056] build_select: Fix "Creating default object from empty value"
PHPBB3-12056
2013-12-04 13:31:12 +01:00
Andreas Fischer
c659fe4cbe [ticket/12056] h_radio test: Fix "Creating default object from empty value"
PHPBB3-12056
2013-12-04 13:29:40 +01:00
Andreas Fischer
e41cd384f5 [ticket/12056] Fix failure due to "Creating default object from empty value".
PHPBB3-12056
2013-12-04 13:22:47 +01:00
Joas Schilling
9fbeae3e0c [ticket/12026] Add functional test for ucp extension module
PHPBB3-12026
2013-12-03 18:10:33 +01:00
Joas Schilling
a8e29f0804 Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/11699] Also exclude the phpBB/cache directory.
  [ticket/11699] Properly exclude the .git directory. Namely missing dot prefix.
  [ticket/11699] Exclude build/new_version and build/old_versions from lint.
2013-12-02 23:33:24 +01:00