Commit graph

5785 commits

Author SHA1 Message Date
Oleg Pudeyev
be23445b8c [feature/event-dispatcher] Add get_data_filtered function to event data.
Its purpose is to discard any keys added by hooks to data stored
in the event, such that only keys that the ledge knows how to handle
are processed.

PHPBB3-9550
2012-03-18 02:48:55 -04:00
Oleg Pudeyev
fbf34f16ab [feature/event-dispatcher] Implement configurable autoloader selection.
The code is in startup.php which should be used by all scripts.

PHPBB3-9550
2012-03-18 02:48:55 -04:00
Callum Macrae
79a987ffcb [ticket/10510] Moved a $user->lang call into the function.
PHPBB3-10510
2012-03-17 18:06:46 +00:00
Callum Macrae
784c9725f3 [ticket/10510] Made a couple improvements to phpbb_add_quickmod_option.
PHPBB3-10510
2012-03-17 18:06:45 +00:00
Callum Macrae
4f59990d90 [ticket/10510] Added phpbb_add_quickmod_option and moved existing to it.
PHPBB3-10510
2012-03-17 18:06:45 +00:00
Oleg Pudeyev
1fa39ea722 Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/8636] Add resync option to topic_view moderation page
2012-03-16 06:18:35 -04:00
Oleg Pudeyev
81eeafbb8d Merge remote-tracking branch 'nickvergessen/ticket/8636' into develop-olympus
* nickvergessen/ticket/8636:
  [ticket/8636] Add resync option to topic_view moderation page
2012-03-16 06:18:29 -04:00
Oleg Pudeyev
ccdd176b72 [task/php54-ascraeus] Bring p_master#module_auth into PHP 5 era.
Split module_auth into a static and a non-static version.

Call the static version statically and the non-static version non-statically.

PHPBB3-10615
2012-03-16 04:56:41 -04:00
Oleg Pudeyev
5efdbfa5e4 [task/php54] Disable E_STRICT in Olympus when running on PHP 5.4.
We cannot use static in Olympus because it must be PHP 4 compatible.

Therefore disable E_STRICT for Olympus.

This commit should be reverted for Ascraeus.

PHPBB3-10615
2012-03-15 22:47:42 -04:00
Oleg Pudeyev
71afba0ded [task/php54] Refactor error_reporting call slightly.
Separate error level assignment into a variable in this commit
so that the only difference between Olympus and Ascraeus
is the addition of logic altering $level.

PHPBB3-10615
2012-03-15 22:46:06 -04:00
Vjacheslav Trushkin
fd96f97dc3 [feature/merging-style-components] Updating style initialization
Changing template initialization to style initialization.

PHPBB3-10632
2012-03-15 21:11:34 +02:00
Vjacheslav Trushkin
1ce4d4c4fc [feature/merging-style-components] Changing style class
Moving functions that deal with styles from template to style class, updating docblocks

PHPBB3-10632
2012-03-15 21:09:49 +02:00
Vjacheslav Trushkin
5b149e93b9 [feature/merging-style-components] Changing template class
Removing functions that are now handled by phpbb_style class, allowing to write $context, updating docblocks

PHPBB3-10632
2012-03-15 21:08:41 +02:00
Vjacheslav Trushkin
0b2abe5250 [feature/merging-style-components] Changing resource locator
Changing "template" to "style" in all functions that deal with styles, changing error messages, updating docblocks

PHPBB3-10632
2012-03-15 21:06:24 +02:00
Vjacheslav Trushkin
c692e0d92d [feature/merging-style-components] Changing path provider
Changing set_templates() to set_style() and removing second parameter, changing get_main_template_path() to get_main_style_path(), removing template_root_for_style(), updating docblocks

PHPBB3-10632
2012-03-15 21:04:27 +02:00
Vjacheslav Trushkin
8b7c2c3c65 [feature/merging-style-components] Renaming style locator
Renaming style locator to style resource locator

PHPBB3-10632
2012-03-15 16:33:13 +02:00
Vjacheslav Trushkin
c83f386c92 [feature/merging-style-components] Changing $style to $style_id
Changing $style to $style_id in user::setup to avoid conflict with new global style variable

PHPBB3-10632
2012-03-15 13:41:23 +02:00
Vjacheslav Trushkin
3997ffac2a [feature/merging-style-components] Creating style class
Creating phpbb_style class, changing template initialization to style initialization

PHPBB3-10632
2012-03-15 13:13:21 +02:00
Oleg Pudeyev
bb461c8daa [feature/new-tz-handling] Sort timezones in selector by offset.
Since the list of timezones is very long, and users are likely
to know their current offset but not necessarily which city
that is nearby is in the timezone database, sort the list of
timezones by offset.

UTC is specially handled to show up before other GMT+0 timezones.

PHPBB3-9558
2012-03-14 22:57:31 -04:00
Chris Smith
f17664a00c [feature/new-tz-handling] Correct a bug preventing multiple formats working.
PHPBB3-9558
2012-03-14 22:57:30 -04:00
Chris Smith
190b019fa2 [feature/new-tz-handling] Remove case mangling, the identifiers are correct.
PHPBB3-9558
2012-03-14 22:57:30 -04:00
Chris Smith
0f320a6c48 [feature/new-tz-handling] Update tz_select() to use the PHP timezone database.
tz_select() now uses the PHP timezone database to generate the timezone
selection box, it tries to use a translated language string otherwise falls
back to a label produced from the timezone identifier. I've done this so
new timezones are available immediately without a new language pack.

PHPBB3-9558
2012-03-14 22:57:30 -04:00
Chris Smith
1665434853 [feature/new-tz-handling] Remove code using legacy timezone properties.
Code accessing the legacy user::$timezone and user::$dst properties
has been removed and replaced with code utilising user::create_datetime().

Changed by Oleg:

in viewtopic, memberlist and index use getTimestamp() + getOffset().

We show members that have birthdays on the specified date.

getTimestamp() returns the current date in UTC. We add getOffset() to
obtain the current local time in the viewing user's timezone.
Then we find members having birthday on this date.

Changed by Oleg again:

Take leap year status out of the datetime object we have, this seems
like it should work as one would expect.

PHPBB3-9558
2012-03-14 22:57:30 -04:00
Chris Smith
6e1278655f [feature/new-tz-handling] Removed line that was missed in cc312d8.
PHPBB3-9558
2012-03-14 22:57:30 -04:00
Chris Smith
e9fe9ea518 [feature/new-tz-handling] Fix bug from 3.0 formatting future dates.
Future dates can get formatted as 'less than a minute ago' if they
occur in the future on the same minute as the current minute.

PHPBB3-9558 PHPBB3-9712
2012-03-14 22:57:30 -04:00
Chris Smith
5dd7916c49 [feature/new-tz-handling] Check the is_short flag stored inside the format array.
Reuse the existing check store in the format array to determine if the date time
format supports relative formatting.

PHPBB3-9558
2012-03-14 22:57:30 -04:00
Chris Smith
8fe46175af [feature/new-tz-handling] Fix undefined variable.
PHPBB3-9558
2012-03-14 22:57:30 -04:00
Chris Smith
f085735ef8 [feature/new-tz-handling] Explained name of phpbb_datetime::getTimestamp()
phpbb_datetime::getTimestamp() exists purely to support PHP 5.2 which
does not implement the method.

PHPBB3-9558
2012-03-14 22:57:30 -04:00
Chris Smith
dba89a5341 [feature/new-tz-handling] Added phpbb_datetime::__toString().
New phpbb_datetime::__toString() magic method that formats the datetime
according to the users default settings.

PHPBB3-9558
2012-03-14 22:57:29 -04:00
Chris Smith
c521ef1591 [feature/new-tz-handling] Comment and optimise phpbb_datetime::format().
- Added comments explaining the complex time computations for rendering
  relative date times.

- Replaced some repeated method invokations with variables.

PHPBB3-9558
2012-03-14 22:57:29 -04:00
Chris Smith
522f65d079 [feature/new-tz-handling] Correct typo in member comment.
PHPBB3-9558
2012-03-14 22:57:29 -04:00
Chris Smith
2e7d9ec805 [feature/new-tz-handling] Fixed bug with signature of user::create_datetime().
First argument to user::create_datetime() should be optional.

PHPBB3-9558
2012-03-14 22:57:29 -04:00
Chris Smith
74be23a098 [feature/new-tz-handling] Added a user::create_datetime() method.
New method which handles instantiating new phpbb_datetime objects in
the context of the current user.

PHPBB3-9558
2012-03-14 22:57:29 -04:00
Chris Smith
6a783b843b [feature/new-tz-handling] Replace user::$timezone with user::$tz.
user::$tz will store the new DateTimeZone object representing the users
timezone instead of the existing user::$timezone and user::$dst combination.

PHPBB3-9558
2012-03-14 22:57:29 -04:00
Chris Smith
9e1812a0ca [feature/new-tz-handling] Remove old user::$dst property
PHPBB3-9558
2012-03-14 22:57:29 -04:00
Chris Smith
b2a812e36b [feature/new-tz-handling] Correct capitalisation of phpbb_datetime.
PHPBB3-9558
2012-03-14 22:57:29 -04:00
Chris Smith
3559d20624 [feature/new-tz-handling] Update user methods to use new date processing class.
user::setup() now stores a DateTimeZone object in user::$timezone representing
the users timezone. For backwards compatibility a numeric value in
user/board_timezone will be converted into one of the legacy Etc/GMT±X
timezones. This will be used until the user updates his/her timezone in the
UCP.

user::format_date() is now basically a legacy wrapper that transforms a UTC
UNIX timestamp into a formatted localised date using phpbb_datetime::format().

PHPBB3-9558
2012-03-14 22:57:29 -04:00
Chris Smith
a5c3ff3769 [feature/new-tz-handling] Renamed old variables and removed extra conditional.
PHPBB3-9558
2012-03-14 22:57:29 -04:00
Chris Smith
e8b60fc3d8 [feature/new-tz-handling] Use phpbb_datetime rather than phpbb_DateTime.
PHPBB3-9558
2012-03-14 22:57:29 -04:00
Chris Smith
6f7d095e3f [feature/new-tz-handling] Wrapper around DateTime for new date time handling.
Wrapped PHP's DateTime with some extensions for supporting phpBB's relative
date formats and provided the DateTime::getTimestamp() method to PHP < 5.3.

PHPBB3-9558
2012-03-14 22:57:28 -04:00
Vjacheslav Trushkin
e35a20f957 [feature/merging-style-components] New acp_styles
New acp_styles, completely rewritten

PHPBB3-10632
2012-03-14 23:47:57 +02:00
Vjacheslav Trushkin
ae7d290a22 [feature/merging-style-components] Updating PHP files
Removing theme and template entries in all files, except for acp styles section

PHPBB3-10632
2012-03-14 23:24:16 +02:00
Vjacheslav Trushkin
234e5d6402 [feature/merging-style-components] Implementing unlimited parent templates
Implementing possibility of unlimited levels of parent templates. Paths are stored in style_parent_tree, entries are separated by /

PHPBB3-10632
2012-03-14 23:22:02 +02:00
Vjacheslav Trushkin
b7d84a586c [feature/merging-style-components] Renaming template classes
Changing template classes prefixes from phpbb_template to phpbb_style (for classes that will work with styles) or phpbb_style_template (for classes that are specific to templates)

PHPBB3-10632
2012-03-14 23:12:11 +02:00
Vjacheslav Trushkin
7d414d04ca [feature/merging-style-components] Moving template classes to style
Moving includes/template/ to includes/style/, adding template_ prefix to classes that deal only with templates

PHPBB3-10632
2012-03-14 22:57:58 +02:00
Joas Schilling
ba6943a6a0 [ticket/10605] Prefix function with phpbb_ and use true instead of 1
PHPBB3-10605
2012-03-12 10:11:52 +01:00
rxu
ff8d523768 [ticket/10684] Rename function phpbb_get_banned_users_ids() parameter
PHPBB3-10684
2012-03-12 01:57:51 +08:00
rxu
da395edbca [ticket/10684] Remove intval mapping for array keys
PHP manual for arrays http://php.net/manual/en/language.types.array.php states
that the following key cast will occur: Strings containing valid integers will
be cast to the integer type. E.g. the key "8" will actually be stored under 8.
Thus, no intval mapping for numeric array keys is needed.

PHPBB3-10684
2012-03-12 01:47:28 +08:00
rxu
321d0d9b56 [ticket/10684] Adjust pm_notifications() to handle stale bans
- Add parameter (array) to the function phpbb_get_banned_users_ids()
- Fix function pm_notification() to handle users with stale bans

PHPBB3-10684
2012-03-12 01:44:00 +08:00
Igor Wiedler
ae984025f0 Merge branch 'develop' into feature/event-dispatcher
* develop: (95 commits)
  [ticket/9084] Explain the logic.
  [ticket/10653] Call get_row_count of base class in mysql get_estimated_row_count
  [ticket/9813] Only get posts table row count if we detected a fulltext index.
  [feature/append_var] Adding test case
  [ticket/7432] Delete redundant reference to "appropriate menu item".
  [ticket/10618] Change phpBB 3 to phpBB 3.1.
  [ticket/10685] Refactor template test defaults for php 5.4 compatibility.
  [feature/append_var] Adding append_var template class function
  [ticket/9813] Also use estimated row count of posts table for fulltext mysql.
  [ticket/10653] Fix parameter to substr() in unit tests. Should be 1, not -1.
  [ticket/10653] Unit tests for get_row_count() and get_estimated_row_count().
  [ticket/10653] Add ability to count table rows to database abstraction layer.
  [ticket/9813] Use table status row count only if greater than 100000 or exact.
  [ticket/9813] Use SHOW TABLE STATUS to get search stats for native on MySQL.
  [ticket/8652] Comment for also updating forum watch table in user_notification.
  [ticket/8652] Sending 2 emails on 2 replies
  [ticket/10680] Add /phpBB/ext/* to .gitignore
  [ticket/10672] Fix total post count language string in statistics and feed
  [ticket/9220] Remove margin on table.table1 so it's centered in the blue box.
  [ticket/10453] Fixing spacing
  ...

Conflicts:
	tests/bootstrap.php
2012-03-11 15:18:33 +01:00