Commit graph

1106 commits

Author SHA1 Message Date
Joas Schilling
665352d0d1 [ticket/11442] Do not suggest an option on ajax confirm box
Reverting commit cb13add269
Also fixing in prosilver and subsilver2

PHPBB3-11442
2013-05-08 00:07:13 +02:00
marc1706
cb13add269 [ticket/11442] Use correct button class for ajaxified confirm_box
In commit 001572f the HTML code for the ajaxified confirm_box was moved
from overall_footer.html to confirm_body.html. While copying, the CSS
class of the "Yes" button was changed from button1 to button2. Due to the
fact that the phpbb.confirm() method uses the class button1 to check if
"Yes" was clicked, this broke the ajaxified confirm box in the ACP. With
this small patch the confirm boxes in the ACP should work properly again.

PHPBB3-11442
2013-04-28 22:54:48 +02:00
Marc Alexander
34cdbd0360 Merge branch 'develop' of https://github.com/phpbb/phpbb3 into ticket/11314
Conflicts:
	phpBB/styles/prosilver/template/timezone.js
2013-03-26 13:18:54 +01:00
Marc Alexander
f0b0978538 [ticket/11314] Modify files to comply with coding standards
PHPBB3-11314
2013-03-26 13:13:33 +01:00
Marc Alexander
4870387f3a [ticket/11314] Fix JSHint issues in adm editor.js
This time without changing the behavior.

PHPBB3-11314
2013-03-26 11:19:03 +01:00
Marc Alexander
36168b311e [ticket/11314] Fix issues mentioned in jshint report
Additionally, the editor.js files are now the same file in both
subsilver2, prosilver, and the acp.

PHPBB3-11314
2013-03-26 10:31:28 +01:00
Joas Schilling
0bbde4c122 Merge branch 'develop' of https://github.com/phpbb/phpbb3 into ticket/11166
* 'develop' of https://github.com/phpbb/phpbb3: (799 commits)
  [ticket/11402] Fix undefined index in post/topic_in_queue
  [ticket/11400] If email is disabled, disable it for notifications
  [ticket/11398] Correctly call permission_set method in permission tool
  [ticket/11394] Relax Migration Tools
  [ticket/11386] Fix missing ;
  [ticket/10714] Get log from container in install, update and download/file
  [feature/avatars] Update module_auth of ucp module and fix small issues
  [ticket/11396] Rename insert_migration to set_migration_state
  [ticket/11395] Prevent acp_modules::get_modules_info from reincluding files
  [ticket/11393] Give more information on database updater
  [ticket/11386] Send list of migrations instead of using load_migrations
  [feature/avatars] Add migrations data file for avatars
  [feature/avatars] Reduce module auth of ucp avatar settings
  [ticket/10714] Use $phpbb_adm_relative_path instead of hardcoded adm/
  [ticket/10714] Logs are disabled for this page call only
  [ticket/6723] Show info that message has been deleted before delivery
  [ticket/11385] Fix issue with migration module tool not getting extension module info
  [ticket/11386] Fix failing tests from constructor changes
  [ticket/11386] Fix circular reference error & serialize error
  [ticket/11386] Remove tests that check if finder cache is working
  ...

Conflicts:
	phpBB/assets/javascript/core.js
2013-03-06 07:35:47 +01:00
Nathaniel Guse
941b7287b7 Merge remote-tracking branch 'remotes/marc/feature/avatars' into develop
# By Marc Alexander (100) and others
# Via Marc Alexander (8) and Igor Wiedler (3)
* remotes/marc/feature/avatars: (138 commits)
  [feature/avatars] Update module_auth of ucp module and fix small issues
  [feature/avatars] Add migrations data file for avatars
  [feature/avatars] Reduce module auth of ucp avatar settings
  [feature/avatars] Auto-clear avatar dimensions when first changing avatars
  [feature/avatars] Use "Main" as category for avatars in root of gallery
  [feature/avatars] Remove trailing whitespace from avatar code
  [feature/avatars] Pass phpbb_user to prepare and process form functions
  [feature/avatars] Document the use of the allowed extensions array
  [feature/avatars] Use array for allowed extensions and implode if needed
  [feature/avatars] Use deprecated for compatibility function
  [feature/avatars] Correct license, copyright and package info
  [feature/avatars] Move list of supported formats to avatar driver class
  [feature/avatars] Add include of functions_display.php in BC function
  [feature/avatars] Add note about when compatibility function was added
  [feature/avatars] Add compatibility function for get_user_avatar()
  [feature/avatars] Move definition of driver_collection to avatars.yml
  [feature/avatars] Remove the obsolete request argument for avatar drivers
  [feature/avatars] Add missing @var to docblocks in avatar manager
  [feature/avatars] Remove not needed inline style
  [feature/avatars] Differentiate tests for get drivers functions
  ...
2013-03-04 13:33:42 -06:00
Marc Alexander
d26ad8ed26 Merge branch 'develop' of https://github.com/phpbb/phpbb3 into feature/avatars
Conflicts:
	phpBB/install/database_update.php
2013-03-04 00:22:15 +01:00
Joas Schilling
001572f764 [ticket/11166] Add ajaxify support to normal ACP confirm_box()
Currently no custom template from the ACP uses AJAX support.

PHPBB3-11166
2013-03-03 17:34:01 +01:00
Joas Schilling
b8b2ede35d [ticket/10411] Remove ajax delete, so the page is refreshed
Otherwise if you delete a group, you can not readd it to the page.

PHPBB3-10411
2013-03-01 12:45:49 +01:00
Marc Alexander
96b1cabcf2 Merge branch 'develop' of https://github.com/phpbb/phpbb3 into ticket/11314 2013-02-27 21:40:02 +01:00
Joas Schilling
ba97303a60 [ticket/10411] Add maxlength to category name input field
PHPBB3-10411
2013-02-26 17:17:31 +01:00
Joas Schilling
8c6a1e50f5 Merge branch 'develop' of https://github.com/phpbb/phpbb3 into ticket/10411-2
* 'develop' of https://github.com/phpbb/phpbb3: (497 commits)
  [ticket/10986] message.id fallback to SERVER_NAME or phpbb.generated
  [ticket/11358] Changed the name of post parameter.
  [ticket/11358] Changed the action parameter value to represent the link.
  [ticket/11358] Enabled link making all users default for a group.
  [ticket/11358] Removed redundant code and referred proper variable.
  [ticket/11358] Success message even without selecting a user.
  [ticket/11355] Referred proper variable when validating selection.
  [ticket/11355] Wrong error message when no user is selected.
  [ticket/10896] Add missing email validation lost in develop merge
  [ticket/7262] Add note about set_config() not updating is_dynamic.
  [ticket/7262] Add $is_dynamic example to set_config() and set_config_count().
  [ticket/7262] Backport set_config() and set_config_count() docs from develop.
  [ticket/11122] Move rxu to 'Former Contributors' section.
  [ticket/11122] Add EXreaction to docs/AUTHORS.
  [ticket/11298] Fix typo in language key; EXTENSIONS -> EXTENSION
  [ticket/11361] Make sure that array passed to strtr() has the proper format.
  [ticket/11342] Fix "unexpected token" syntax error
  [ticket/11179] remove extra & in function call
  [ticket/11179] correct start parameter in sphinx search
  [ticket/11179] correct start parameter in native author search
  ...

Conflicts:
	phpBB/config/services.yml
	phpBB/includes/functions_user.php
	phpBB/install/schemas/firebird_schema.sql
	phpBB/install/schemas/mssql_schema.sql
	phpBB/install/schemas/mysql_40_schema.sql
	phpBB/install/schemas/mysql_41_schema.sql
	phpBB/install/schemas/oracle_schema.sql
	phpBB/install/schemas/postgres_schema.sql
	phpBB/install/schemas/sqlite_schema.sql
2013-02-25 21:03:34 +01:00
Joas Schilling
9ea48dbd45 [ticket/10411] Use template loops instead of defining the html in php files
PHPBB3-10411
2013-02-25 20:24:11 +01:00
Nathaniel Guse
b398fa2050 [feature/migrations] Catch and display errors from the migrator
PHPBB3-11318
2013-02-09 21:09:29 -06:00
Marc Alexander
c56db535b4 Merge branch 'develop' of https://github.com/phpbb/phpbb3 into feature/avatars
Conflicts:
	phpBB/config/services.yml
2013-02-07 00:07:59 +01:00
Andreas Fischer
336187151a [ticket/11201] Revert WLM dropping because it is still used in China.
Windows Live Messenger is still in use in china which accounts for ~20% of world
population. Revert WLM dropping which has been merged under the assumption that
WLM data and features are completely useless.

This commit reverts commits
 - 460470229d
 - 9affd6f7e7
which have been merged by d59431691c.

PHPBB3-11201
2013-02-04 01:31:43 +01:00
Marc Alexander
2f6b072bb1 [ticket/11314] Add missing radix parameters
PHPBB3-11314
2013-01-13 23:00:48 +01:00
Joas Schilling
9affd6f7e7 [ticket/11201] Remove MSN/WLM fields
WLM will be shutdown in March 2013. Skype is the new replacement. But as Skype
uses a different login ID and service, the values in this field are useless.
So we can safely remove the field and the links/functions we create.

PHPBB3-11201
2013-01-11 14:32:44 +01:00
Marc Alexander
c31f489cce [ticket/11314] Add missing "use strict" to timezone.js files
PHPBB3-11314
2013-01-10 11:15:19 +01:00
Marc Alexander
0fc863c68a [ticket/11314] Add missing semi-colons
Omitting the semi-colon is not legal behavior for JavaScript.

PHPBB3-11314
2013-01-10 11:06:05 +01:00
Marc Alexander
7ea0376958 [feature/avatars] Remove not needed inline style
PHPBB3-10018
2013-01-08 22:47:05 +01:00
Marc Alexander
b5cc1ed683 [ticket/10949] Converted missing code to new JS coding guidelines
A few missing semi-colons were also added where needed.

PHPBB3-10949
2013-01-04 22:46:12 +01:00
Marc Alexander
a342e47038 [feature/avatars] Change avatar javascript to conform to new coding guidelines
PHPBB3-10018
2013-01-04 18:13:49 +01:00
Marc Alexander
5d091e2d8f Merge branch 'develop' of https://github.com/phpbb/phpbb3 into feature/avatars
Conflicts:
	phpBB/includes/ucp/ucp_groups.php
2013-01-04 10:49:57 +01:00
Oleg Pudeyev
4dcc8cabae Merge PR #1130 branch 'EXreaction/ticket/11259' into develop
* EXreaction/ticket/11259:
  [ticket/11259] htmlspecialchars($phpbb_admin_path)
  [ticket/11259] adm_relative_path -> phpbb_adm_relative_path
  [ticket/11259] Also make adm_relative_path available in the container
  [ticket/11259] Make phpbb_admin_path available everywhere

Conflicts:
	phpBB/install/index.php
	phpBB/install/install_update.php
2012-12-29 13:45:40 -05:00
Marc Alexander
c9338b38b3 Merge branch 'develop' of github.com:marc1706/phpbb3 into feature/avatars 2012-12-24 14:34:10 +01:00
David King
a686e66c85 [feature/events] Remove extraneous space
PHPBB3-9550
2012-12-17 18:16:39 -05:00
David King
11035eb4c4 [feature/events] Append "_append" to acp_simple_header_head
PHPBB3-9550
2012-12-17 11:37:44 -05:00
David King
4e8ee1e6b9 [feature/events] acp_simple_footer_end -> acp_simple_footer_after
PHPBB3-9550
2012-12-17 11:37:43 -05:00
David King
79ea26409b [feature/events] Append "_append" to acp_overall_header_head
PHPBB3-9550
2012-12-17 11:37:42 -05:00
David King
c0652a7236 [feature/events] Change _end suffix to _after in acp_overall_footer_end
PHPBB3-9550
2012-12-17 11:37:41 -05:00
David King
cdfac59944 [feature/events] Append "_append" to acp_users_overview_options
PHPBB3-9550
2012-12-17 11:37:39 -05:00
David King
530be9106c [feature/events] Fix names of events in adm/style/acp_main.html
PHPBB3-9550
2012-12-17 11:37:38 -05:00
David King
ae93bd4e80 [feature/events] Append "_append" to acp_forums_normal_settings
PHPBB3-9550
2012-12-17 11:37:37 -05:00
Joas Schilling
b20e91b877 [feature/events] Rename event_main_actions to acp_main_actions
PHPBB3-9550
2012-12-17 11:37:35 -05:00
Michael Cullum
3c8fb03785 [feature/events] Adding acp prefix to acp event names
PHPBB3-9550
2012-12-17 11:37:28 -05:00
Michael Cullum
d913a508a2 [feature/events] Adding forums_normal_settings acp template ledge
PHPBB3-9550
2012-12-17 11:37:22 -05:00
Michael Cullum
1f9b662964 [feature/events] Adding simple_footer_end acp template event
PHPBB3-9550
2012-12-17 11:37:21 -05:00
Michael Cullum
6a29de3f1b [feature/events] Adding simple_header_head acp template event
PHPBB3-9550
2012-12-17 11:37:20 -05:00
Michael Cullum
c7b2665160 [feature/events] Add users_overview_options acp template event
PHPBB3-9550
2012-12-17 11:37:19 -05:00
Michael Cullum
9ba18a21f0 [feature/events] Add overall_footer_end acp template event
PHPBB3-9550
2012-12-17 11:37:18 -05:00
Michael Cullum
44afff6b74 [feature/events] Adding overall_header_head acp template event
PHPBB3-9550
2012-12-17 11:37:16 -05:00
Michael Cullum
e6d1b07e2b [feature/events] Add main_actions acp template event
PHPBB3-9550
2012-12-17 11:37:15 -05:00
Michael Cullum
bc99e69f77 [feature/events] Add main_notice ACP template event
PHPBB3-9550
2012-12-17 11:37:14 -05:00
Marc Alexander
2f47c99432 [feature/avatars] Add more consistency to codebase
PHPBB3-10018
2012-12-11 21:02:37 +01:00
David King
a9db155c28 Merge remote-tracking branch 'p/feature/template-events' into develop
# By Oleg Pudeyev (36) and others
# Via Oleg Pudeyev
* p/feature/template-events: (47 commits)
  [feature/template-events] Pass arguments in correct order.
  [feature/template-events] Order extensions in mock extension manager.
  [feature/template-events] Changes per imkingdavid's review.
  [feature/template-events] Make style names private on template.
  [feature/template-events] Test for event that is defined in parent style only.
  [feature/template-events] Specify style names, add inheritance tests.
  [feature/template-events] Normalize expected directory trees.
  [feature/template-events] Allow dataset to be correctly selectable.
  [feature/template-events] Dataset for template event testing with inheritance.
  [feature/template-events] Use style names array in template filter.
  [feature/template-events] Generate style names array in set_style.
  [feature/template-events] Convert a single style name to array of them.
  [feature/template-events] Chase dependency injection for template context.
  [feature/template-events] Adjust template events test to use the dataset.
  [feature/template-events] Create a dataset for template event tests.
  [feature/template-events] Indentation fix.
  [feature/template-events] Cosmetic changes.
  [feature/template-events] Wording: wrongly -> improperly.
  [feature/template-events] Indentation fix.
  [feature/template-events] Rename template_name to style_name.
  ...
2012-12-10 14:09:10 -05:00
Nathan Guse
6dee253941 [ticket/11259] Make phpbb_admin_path available everywhere
PHPBB3-11259
2012-12-09 17:01:08 -06:00
Marc Alexander
1aae72961a Merge branch 'develop' into feature/avatars
Conflicts:
	phpBB/install/database_update.php
2012-12-09 21:02:31 +01:00