Commit graph

2668 commits

Author SHA1 Message Date
Nils Adermann
7320e4a535 Merge pull request #1348 from nickvergessen/ticket/11495
Ticket/11495 Nested Set Implementation
2013-05-02 15:04:19 -07:00
Nathaniel Guse
a4fe72bd53 [ticket/11420] Fix notification options conversion
PHPBB3-11420
2013-05-02 15:40:43 -05:00
Nathaniel Guse
07c972f5d7 [ticket/11413] Remove changes for ticket 11420 from this branch
PHPBB3-11413
2013-05-02 15:39:26 -05:00
Nathaniel Guse
60e3272839 [ticket/11415] Remove migrator dependency from extension manager
PHPBB3-11415
2013-05-01 14:09:08 -05:00
Nathaniel Guse
356bc00a29 [ticket/11435] Mark extension spacing test as incomplete
This test fails until 11435 is fixed

Add newlines at EOF

PHPBB3-11435
2013-04-30 23:21:50 -05:00
Nathaniel Guse
9004676810 [ticket/11413] Include mock class
PHPBB3-11413
2013-04-30 22:02:10 -05:00
Nathaniel Guse
2f2feaa4e8 [ticket/11413] Don't use the database for the convert test
Different databases seem to work slightly differently here and are causing
errors

PHPBB3-11413
2013-04-30 21:38:40 -05:00
Nathaniel Guse
f2e618a05d [ticket/11413] Test get_notification_type_id and _ids functions
PHPBB3-11413
2013-04-30 21:10:04 -05:00
Nathaniel Guse
00ea297b61 [ticket/11413] Create test for notification conversion
PHPBB3-11413
2013-04-30 20:54:01 -05:00
Joas Schilling
d7787682df [ticket/11495] Throw exception when item that should be deleted does not exist
PHPBB3-11495
2013-04-30 22:19:35 +02:00
Dhruv
1d0c8a1fe8 [ticket/10325] use assert_response_success parts
PHPBB3-10325
2013-04-30 23:09:28 +05:30
Dhruv
a5b5e4b31d [ticket/10325] add assert_response_success in test
PHPBB3-10325
2013-04-30 22:29:20 +05:30
Joas Schilling
d1d59dc5cc [ticket/11495] Remove unneccessary values from tests
PHPBB3-11495
2013-04-30 18:33:28 +02:00
Joas Schilling
2f54a63b0f [ticket/11495] Fix more grammar issues in doc blocks
PHPBB3-11495
2013-04-30 18:24:54 +02:00
Joas Schilling
fe02218a2d [ticket/11495] Remove forum_parents from tests where it is not required
PHPBB3-11495
2013-04-30 18:11:24 +02:00
Joas Schilling
39ff3ed15f [ticket/11495] Add proper testing of item_parent to tests
PHPBB3-11495
2013-04-30 18:05:44 +02:00
Joas Schilling
714092ab4e [ticket/11495] Add owns_lock() method to lock classes
PHPBB3-11495
2013-04-30 15:48:29 +02:00
Joas Schilling
863d0c7687 [ticket/11495] Fix some more comments and the package tag
PHPBB3-11495
2013-04-30 14:36:26 +02:00
Joas Schilling
67f2edae17 [ticket/11495] Use descendants and ancestors instead of parents/children
PHPBB3-11495
2013-04-30 13:58:03 +02:00
Joas Schilling
4810c61fd7 [ticket/11495] Remove get_parent_data from interface and rename it
The method is implementation specific and has no use, apart from cache, that is
not covered by get_path_data().

PHPBB3-11495
2013-04-30 10:37:59 +02:00
Joas Schilling
8a4260703f [ticket/11495] Fix some docs and replace branch with other terms
PHPBB3-11495
2013-04-30 10:32:01 +02:00
Nathaniel Guse
878df5f280 [ticket/11413] Fix test fixtures and tests
PHPBB3-11413
2013-04-29 23:10:38 -05:00
Nathaniel Guse
78c22248fa [ticket/11413] Fix some more tests
PHPBB3-11413
2013-04-29 22:41:08 -05:00
Nathaniel Guse
4cd0914f89 [ticket/11413] Fix notification tests
Send types/methods the cache service, not the driver (not sure why the
driver was sent before)

PHPBB3-11413
2013-04-29 22:16:46 -05:00
Dhruv
679183385f [ticket/10820] add unit tests for phpbb_is_greater_ie7
PHPBB3-10820
2013-04-29 02:29:19 +05:30
Joas Schilling
baff4287e5 [ticket/11495] Fix comments and package docs
PHPBB3-11495
2013-04-25 22:39:24 +02:00
Nathan Guse
ab87fe7982 [ticket/11435] Create test to make sure template/event output is equal
PHPBB3-11435
2013-04-25 15:26:59 -05:00
Nathan Guse
6801e36def [ticket/11435] Fix comments in events test
PHPBB3-11435
2013-04-25 15:26:59 -05:00
Dhruv
27aa5e7b71 [ticket/10325] functional tests for forgot password functionality
PHPBB3-10325
2013-04-25 22:58:03 +05:30
Dhruv
2fa5f9591e [ticket/10325] add logout function in functional_test_case
PHPBB3-10325
2013-04-25 22:52:40 +05:30
Joas Schilling
ce07b27765 [ticket/11495] Fix failing unit tests
PHPBB3-11495
2013-04-25 17:27:33 +02:00
Joas Schilling
d4b7708d4b [ticket/11495] Remove tests for add/remove we make them protected later
PHPBB3-11495
2013-04-25 17:19:21 +02:00
Joas Schilling
499dd3a833 [ticket/11495] Move tests to tree/ directory
PHPBB3-11495
2013-04-25 17:13:21 +02:00
Joas Schilling
b334a2ce0f [ticket/11495] Move classes to tree/ as they all implement a tree
PHPBB3-11495
2013-04-25 17:04:37 +02:00
Joas Schilling
94dee77647 [ticket/11495] Replace fixtures content with manual calls
Should be easier to maintain

PHPBB3-11495
2013-04-25 16:50:11 +02:00
Joas Schilling
804f139be0 [ticket/11495] Use default exceptions
PHPBB3-11495
2013-04-25 16:17:58 +02:00
Joas Schilling
fe97915fc9 [ticket/11495] Split get_branch_data into multiple methods
PHPBB3-11495
2013-04-25 14:05:41 +02:00
Joas Schilling
ab7054445f [ticket/11495] Rename set_parent to change_parent()
PHPBB3-11495
2013-04-25 13:48:19 +02:00
Joas Schilling
4bff28a0ee [ticket/11495] Rename fix function to regenerate_left_right_ids()
This method regenerates the left/right ids for the nested set based on the
parent/child relations. This function executes three queries per item, so
it should only be called, when the set has one of the following problems:
- The set has a duplicated value inside the left/right id chain
- The set has a missing value inside the left/right id chain
- The set has items that do not have a left/right is set

When regenerating the items, the items are sorted by parent id and their
current left id, so the current child/parent relationships are kept and
running the function on a working set will not change any orders.

PHPBB3-11495
2013-04-25 13:40:25 +02:00
Nathan Guse
f49993766e [ticket/11335] (more) Make php_ext 'php' not '.php'
PHPBB3-11335
2013-04-24 17:46:00 -05:00
Nathan Guse
c870b9f43b [ticket/11335] (more tests) Make php_ext 'php' not '.php'
PHPBB3-11335
2013-04-24 17:45:56 -05:00
Nathan Guse
e5d032ca21 [ticket/11335] (more class loader) Make php_ext 'php' not '.php'
PHPBB3-11335
2013-04-24 17:45:53 -05:00
Nathan Guse
df518ac131 [ticket/11335] (tests) Make php_ext 'php' not '.php'
PHPBB3-11335
2013-04-24 17:45:51 -05:00
Nils Adermann
b8c2bf6ce4 Merge remote-tracking branch 'github-asperous/ticket/9975' into develop
* github-asperous/ticket/9975:
  [ticket/9975] Moved a few E_USER_ERROR errors to /language

Conflicts:
	phpBB/includes/user.php
2013-04-24 19:16:46 +02:00
Nils Adermann
81daf21dc0 Merge pull request #1324 from nickvergessen/ticket/10844-2
Ticket/10844 Extensions are not located when front-end file has a diffferent phpbb_root_path
2013-04-24 09:52:57 -07:00
Nils Adermann
3e32655c7f Merge pull request #1290 from nickvergessen/ticket/11362
Correctly sanitise the directory path in finder
2013-04-24 09:45:34 -07:00
asperous
9f545a7f6b [ticket/9975] Moved a few E_USER_ERROR errors to /language
There were a few error messages that a user could experience that would, previously, be without any the ability to be localized. There are some more E_USER_ERRORs that I did not change to a constant, for example the error message that is displayed if there aren't any folders in /language.

PHPBB3-9975
2013-04-23 09:55:36 -07:00
Joas Schilling
10781ce9ae [ticket/10844] Increase prefix to not match template/ in finder test
PHPBB3-10844
2013-04-22 00:24:30 +02:00
Joas Schilling
12c432c523 [ticket/10844] Add extension template file to locate
PHPBB3-10844
2013-04-22 00:23:49 +02:00
Joas Schilling
87dc3b1e55 [ticket/11495] Use item ids instead of requiring all data
The data is grabbed again in most cases anyway, so it just makes the system
easier to use.

PHPBB3-11495
2013-04-19 21:07:42 +02:00