Commit graph

6338 commits

Author SHA1 Message Date
Oleg Pudeyev
f46f48a2cf [feature/template-events] Chase template/style renames and changes.
PHPBB3-9550
2012-11-17 16:39:58 -05:00
Erik Frèrejean
7bd5f7641f [feature/template-events] Fix typo (waring -> warning)
PHPBB3-9550
2012-11-17 16:39:58 -05:00
Erik Frèrejean
2add66c0eb [feature/template-events] Add additional space for editors
Use `' ?'. '>'` rather than `' ?>'` as the latter causes problems
in some editors.

PHPBB3-9550
2012-11-17 16:39:58 -05:00
Erik Frèrejean
6fc0c889fd [feature/template-events] Remove comment
Remove comment per Nils in the PR.

PHPBB3-9550
2012-11-17 16:39:58 -05:00
Erik Frèrejean
132bbede2b [feature/template-events] Handle incorrect template event identifiers
If the template event identifier is wrongly formatted phpBB will
triggern an `E_USER_NOTICE` if the `DEBUG` constant is set, otherwise
the location is ignored.

PHPBB3-9550
2012-11-17 16:39:58 -05:00
Erik Frèrejean
f836277638 [feature/template-events] RUNHOOKS -> EVENT
PHPBB3-9550
2012-11-17 16:39:58 -05:00
Nathan Guse
04f55ba306 [feature/template-events] Correct indentation
PHPBB3-9550
2012-11-17 16:39:57 -05:00
Michael Cullum
8d58e69ed3 [feature/template-events] Rename RUNHOOKS to EVENT
Rename the way to add template events

PHPBB3-9550
2012-11-17 16:39:57 -05:00
Oleg Pudeyev
ecdb54fc04 [feature/template-events] PHP does not parse <?php?>, avoid generating it.
PHPBB3-9550
2012-11-17 16:39:57 -05:00
Oleg Pudeyev
bdbb382a26 [feature/template-events] Invoke template hooks that are template-specific.
PHPBB3-9550
2012-11-17 16:39:57 -05:00
Oleg Pudeyev
a6c7fbc59d [feature/template-events] Pass top-level template name to template filter.
This will be used to invoke template-specific hooks.

PHPBB3-9550
2012-11-17 16:39:57 -05:00
Oleg Pudeyev
dd7c5183fb [feature/template-events] Add template_compile to template filter params.
PHPBB3-9550
2012-11-17 16:39:57 -05:00
Oleg Pudeyev
ea094dd91a [feature/template-events] Rename universal to all (for template fragments).
PHPBB3-9550
2012-11-17 16:39:57 -05:00
Oleg Pudeyev
b6f6add9d4 [feature/template-events] Fix property name for extension manager.
PHPBB3-9550
2012-11-17 16:39:57 -05:00
Oleg Pudeyev
66232031e4 [feature/template-events] Really basic template hook implementation.
PHPBB3-9550
2012-11-17 16:39:56 -05:00
Oleg Pudeyev
09aae1ea30 [feature/template-events] Inject template compile into template filter.
This is needed for hooks in order for the filter to compile
template files from extensions.

PHPBB3-9550
2012-11-17 16:39:56 -05:00
Oleg Pudeyev
d6c881d0c6 [feature/template-events] Inject extension manager into template class.
Template class passes extension manager to template compiler.

Template compiler passes extension manager to template filter.

Template filter will use extension manager to locate hooks
as it is compiling templates.

All extension manager arguments are optional. If an extension
manager is not given, template hooks will not be invoked.

PHPBB3-9550
2012-11-17 16:39:54 -05:00
Oleg Pudeyev
ed548ae8ff [feature/template-events] Outline for RUNHOOKS template tag.
Ported to the new develop, hopefully this is still sensible.

PHPBB3-9550
2012-11-17 16:38:25 -05:00
Igor Wiedler
b5e069f879 Merge remote-tracking branch 'p/ticket/10933' into develop
* p/ticket/10933:
  [ticket/10933] Prose for get_first_file_location.
  [ticket/10933] Remaining documentation for added functions in resource locator
  [ticket/10933] Update template locator test to use style resource locator.
  [ticket/10933] Dispose of locate function in template class.
  [ticket/10933] Add mutators for template_path to style resource locator.
  [ticket/10933] Delete template_path assignment.
  [ticket/10933] Delete template_path from template class.
  [ticket/10933] Add get_first_template_location.
2012-11-17 19:49:03 +01:00
Igor Wiedler
b8cf74217a [ticket/11212] Cosmetic surgery done right
PHPBB3-11212
2012-11-17 05:29:49 +01:00
Igor Wiedler
1affc35be9 [ticket/11212] Cosmetics
PHPBB3-11212
2012-11-17 05:29:49 +01:00
Igor Wiedler
b534a7a579 [ticket/11212] Rename get_http_version to phpbb_request_http_version()
PHPBB3-11212
2012-11-17 05:29:49 +01:00
Igor Wiedler
9cdef7984f [ticket/11212] Allow dispatcher to be absent during garbage_collection()
PHPBB3-11212
2012-11-17 01:17:23 +01:00
Igor Wiedler
5fad4006e1 [ticket/11212] Do not rely on $request in send_status_line()
PHPBB3-11212
2012-11-17 01:15:50 +01:00
David King
ca09eb94e3 [ticket/11211] Fix typo in phpbb_realpath() method name
PHPBB3-11211
2012-11-16 14:38:53 -05:00
Oleg Pudeyev
1a2dfa6d4c Merge PR #1074 branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/11192] Merge dataProvider arrays because the test is the same now.
  [ticket/11192] Update $value parameter description to support other types.
  [ticket/11192] Mark negative byte numbers as unsupported.
  [ticket/11192] Test strings not converted to int/float before.
  [ticket/11192] Also test strings, e.g. sums returned by the database.
  [ticket/11192] Also test powers of 10 / 1000.
  [ticket/11192] Add tests.
  [ticket/11192] Add Tebibyte to get_formatted_filesize().
2012-11-16 10:29:22 -05:00
Andreas Fischer
efd6f1df63 [ticket/11192] Update $value parameter description to support other types.
PHPBB3-11192
2012-11-16 14:56:15 +01:00
Andreas Fischer
7cbd440e7a [ticket/11192] Mark negative byte numbers as unsupported.
PHPBB3-11192
2012-11-16 14:56:15 +01:00
Oleg Pudeyev
c30b38ba10 Merge PR #1088 branch 'igorw/ticket/11199' into develop
* igorw/ticket/11199:
  [ticket/11199] Match cache purge container files against container_*
  [ticket/11199] Purge dumped container correctly on cache purge.
2012-11-15 09:07:41 -05:00
Oleg Pudeyev
f2cffd6a6c [ticket/11200] Add a reminder comment.
PHPBB3-11200
2012-11-15 08:50:04 -05:00
Igor Wiedler
31843ecd8c [ticket/11200] Make cache available during container construction
Fixes fatal errors in the dbal.

PHPBB3-11200
2012-11-15 05:00:24 +01:00
Igor Wiedler
a0cc2878a3 [ticket/11199] Match cache purge container files against container_*
Previously it was matching against only container*, checking for the
underscore is consistent with the other checks.

PHPBB3-11199
2012-11-15 02:30:43 +01:00
Igor Wiedler
73ce1a5a97 [ticket/11199] Purge dumped container correctly on cache purge.
This patch changes the dumped container suffix to a prefix instead which
makes the existing code for purging 'cache/container_*' files work
as intended.

PHPBB3-11199
2012-11-15 01:56:33 +01:00
Oleg Pudeyev
30e9d2d600 [ticket/11199] Revert merge of 'marc1706/ticket/11199' into develop
This reverts commit 303fc646ad, reversing
changes made to 9c28470ad7.

The correct fix should be to alter the container file name to start with
container_ prefix.

PHPBB3-11199
2012-11-14 19:07:28 -05:00
Marc Alexander
d982d432eb [ticket/11199] Cache purge does not remove dumped container
PHPBB3-11199
2012-11-14 23:34:28 +01:00
David King
d33aaac199 [ticket/11195] Condense logic, remove improperly formatted if()
PHPBB3-11195
2012-11-12 16:16:40 -05:00
Nils Adermann
09ec65cb9b [ticket/11194] Service tag data is stored in an array so access it correctly
PHPBB3-11194
2012-11-12 01:01:02 +01:00
Nils Adermann
d2a051cdd4 [ticket/11193] Instantiate a single collection_pass for all collections
PHPBB3-11193
2012-11-11 18:39:24 +01:00
Nils Adermann
69845585a2 Merge pull request #1056 from igorw/feature/compiled-dic
[feature/compiled-dic] Compile the DI Container into a cached class
2012-11-11 09:05:15 -08:00
Igor Wiedler
00417fc723 [ticket/11152] Compile the install container
PHPBB3-11152
2012-11-11 17:54:54 +01:00
Igor Wiedler
5616972195 [ticket/11152] Throw error if services.yml is missing
PHPBB3-11152
2012-11-11 17:53:24 +01:00
Igor Wiedler
09781a96bc [ticket/11152] Use realpath in container extensions consistently
PHPBB-11152
2012-11-11 16:34:41 +01:00
Andreas Fischer
c699b88bc5 [ticket/11192] Add Tebibyte to get_formatted_filesize().
PHPBB3-11192
2012-11-11 14:35:31 +01:00
Igor Wiedler
3e4d3761fd [ticket/11152] Rename collection to collection_pass
PHPBB3-11152
2012-11-11 14:18:11 +01:00
Andreas Fischer
e86ecc0f3b Merge remote-tracking branch 'Fyorl/ticket/10939' into develop
* Fyorl/ticket/10939:
  [ticket/10939] Added documentation for phpbb_request::file
  [ticket/10939] Added tests for phpbb_request::file
  [ticket/10939] Modified the default return for $request->file
  [ticket/10939] Modified fileupload tests to deal with new behaviour
  [ticket/10939] Modified mock request class to handle deactivated $_FILES
  [ticket/10939] Modified acp_groups.php to not use $_FILES
  [ticket/10939] Modified ucp_groups.php to not use $_FILES
  [ticket/10939] Modified functions_user.php to not use $_FILES
  [ticket/10939] Modified message_parser.php to not use $_FILES
  [ticket/10939] Modified functions_upload to not use $_FILES
  [ticket/10939] Modified request test slightly to include $_FILES
  [ticket/10939] Added $_FILES handling to phpbb_request
2012-11-10 23:49:29 +01:00
Andreas Fischer
847feb07e7 Merge remote-tracking branch 'EXreaction/ticket/11189' into develop
* EXreaction/ticket/11189:
  [ticket/11189] Replace DEBUG_EXTRA with DEBUG
  [ticket/11189] Always log critical errors when in cron or in image output
2012-11-10 23:39:00 +01:00
Igor Wiedler
bdbf7d5de6 [ticket/11152] Remove @api docblocks
PHPBB3-11152
2012-11-10 23:36:13 +01:00
Igor Wiedler
8851b797fb [ticket/11152] Create separate function for debug-dependent container
PHPBB3-11152
2012-11-10 23:35:52 +01:00
Igor Wiedler
231d743ba9 [ticket/11152] Change phpbb_di_pass_cron to generic phpbb_di_pass_collection
PHPBB3-11152
2012-11-10 23:34:27 +01:00
Nathaniel Guse
bd37f7f6c0 [ticket/11189] Replace DEBUG_EXTRA with DEBUG
PHPBB3-11189
2012-11-10 10:45:02 -06:00