Merge 8d0d6c012c into 1b2ac50cfd

tests/functional/search/base.php

@@ -221,150 +221,6 @@ abstract class phpbb_functional_search_base extends phpbb_functional_test_case
 		$this->delete_topic($topic_multiple_results_count2['topic_id']);
 	}
 
-	public function test_caching_search_results()
-	{
-		$this->purge_cache();
-		$this->login();
-		$this->admin_login();
-
-		$crawler = self::request('GET', 'search.php?author_id=2&sr=posts');
-		$posts_found_text = $crawler->filter('.searchresults-title')->text();
-
-		// Get total user's post count
-		preg_match('!(\d+)!', $posts_found_text, $matches);
-		$posts_count = (int) $matches[1];
-
-		$this->assertStringContainsString("Search found $posts_count matches", $posts_found_text, $this->search_backend);
-		
-		// Set this value to cache less results than total count
-		$sql = 'UPDATE ' . CONFIG_TABLE . '
-			SET config_value = ' . floor($posts_count / 3) . "
-			WHERE config_name = '" . $this->db->sql_escape('search_block_size') . "'";
-		$this->db->sql_query($sql);
-
-		// Temporarily set posts_per_page to the value allowing to get several pages (4+)
-		$crawler = self::request('GET', 'adm/index.php?sid=' . $this->sid . '&i=acp_board&mode=post');
-		$form = $crawler->selectButton('Submit')->form();
-		$values = $form->getValues();
-		$current_posts_per_page = $values['config[posts_per_page]'];
-		$values['config[posts_per_page]'] = floor($posts_count / 10);
-		$form->setValues($values);
-		$crawler = self::submit($form);
-		$this->assertEquals(1, $crawler->filter('.successbox')->count());
-
-		// Now actually test caching search results
-		$this->purge_cache();
-
-		// Default sort direction is 'd' (descending), browse  the 1st page
-		$crawler = self::request('GET', 'search.php?author_id=2&sr=posts');
-		$pagination = $crawler->filter('.pagination')->eq(0);
-		$posts_found_text = $pagination->text();
-
-		$this->assertStringContainsString("Search found $posts_count matches", $posts_found_text, $this->search_backend);
-
-		// Filter all search result page links on the 1st page
-		$pagination = $pagination->filter('li > a')->reduce(
-			function ($node, $i)
-			{
-				return ($node->attr('class') == 'button');
-			}
-		);
-
-		// Get last page number
-		$last_page = (int) $pagination->last()->text();
-
-		// Browse the last search page
-		$crawler = self::$client->click($pagination->selectLink($last_page)->link());
-		$pagination = $crawler->filter('.pagination')->eq(0);
-
-		// Filter all search result page links on the last page
-		$pagination = $pagination->filter('li > a')->reduce(
-			function ($node, $i)
-			{
-				return ($node->attr('class') == 'button');
-			}
-		);
-
-		// Now change sort direction to ascending
-		$form = $crawler->selectButton('sort')->form();
-		$values = $form->getValues();
-		$values['sd'] = 'a';
-		$form->setValues($values);
-		$crawler = self::submit($form);
-
-		$pagination = $crawler->filter('.pagination')->eq(0);
-
-		// Filter all search result page links on the 1st page with new sort direction
-		$pagination = $pagination->filter('li > a')->reduce(
-			function ($node, $i)
-			{
-				return ($node->attr('class') == 'button');
-			}
-		);
-
-		// Browse the rest of search results pages with new sort direction
-		foreach (range(2, $last_page) as $page_number)
-		{
-			$crawler = self::$client->click($pagination->selectLink($page_number)->link());
-			$pagination = $crawler->filter('.pagination')->eq(0);
-			$pagination = $pagination->filter('li > a')->reduce(
-				function ($node, $i)
-				{
-					return ($node->attr('class') == 'button');
-				}
-			);
-		}
-
-		// Get search results cache varname
-		$finder = new \Symfony\Component\Finder\Finder();
-		$finder
-			->name('data_search_results_*.php')
-			->files()
-			->in(__DIR__ . '/../../../phpBB/cache/' . PHPBB_ENVIRONMENT);
-		$iterator = $finder->getIterator();
-		$iterator->rewind();
-		$cache_filename = $iterator->current();
-		$cache_varname = substr($cache_filename->getBasename('.php'), 4);
-
-		// Get cached post ids data
-		$cache = $this->get_cache_driver();
-		$post_ids_cached = $cache->get($cache_varname);
-
-		$post_ids_cached_backup = $post_ids_cached;
-		
-		// Cached data still should have initial 'd' sort direction
-		$this->assertTrue($post_ids_cached[-2] === 'd');
-
-		// Cached search results count should be more than or equal to displayed one
-		$this->assertGreaterThanOrEqual($posts_count, $post_ids_cached[-1]);
-
-		/* Check post ids cached data. Array shouldn't change after removing duplicates and re-sorting.
-		 * That means it shouldn't have any duplicates and it should be properly ordered already
-		 */
-		unset($post_ids_cached[-2], $post_ids_cached[-1]);
-		unset($post_ids_cached_backup[-2], $post_ids_cached_backup[-1]);
-		$post_ids_cached = array_unique($post_ids_cached);
-		rsort($post_ids_cached);
-		$this->assertEquals($post_ids_cached_backup, $post_ids_cached);
-
-		// Restore this value to default
-		$sql = 'UPDATE ' . CONFIG_TABLE . '
-			SET config_value = ' . floor($posts_count / 3) . "
-			WHERE config_name = '" . $this->db->sql_escape('search_block_size') . "'";
-		$this->db->sql_query($sql);
-		$crawler = self::submit($form);
-		$this->assertEquals(1, $crawler->filter('.successbox')->count());
-
-		// Restore posts_per_page value
-		$crawler = self::request('GET', 'adm/index.php?sid=' . $this->sid . '&i=acp_board&mode=post');
-		$form = $crawler->selectButton('Submit')->form();
-		$values = $form->getValues();
-		$values['config[posts_per_page]'] = $current_posts_per_page;
-		$form->setValues($values);
-		$crawler = self::submit($form);
-		$this->assertEquals(1, $crawler->filter('.successbox')->count());
-	}
-
 	protected function create_search_index($backend = null)
 	{
 		$this->add_lang('acp/search');