Merge 3f4be7e3af into d3bb7e5bd3

900 bytes for a clustered index. 1,700 bytes for a nonclustered index.
For SQL Server 2014 (12.x) and earlier, all versions supported 900 bytes
for all index types.

PHPBB-17524

tests/dbal/migrator_test.php

@@ -415,14 +415,16 @@ class phpbb_dbal_migrator_test extends phpbb_database_test_case
 		$this->assertTrue(isset($index_data_row['i_auth']));
 
 		$is_mysql = $this->db->get_sql_layer() === 'mysqli'; // Key 'lengths' option only applies to MySQL indexes
-		$is_mssql = in_array($this->db->get_sql_layer(), ['mssqlnative', 'mssql_odbc']); // MSSQL primary index key has 'clustered' flag
+		// MSSQL primary index key has 'clustered' flag, 'nonclustered' otherwise
+		// See https://learn.microsoft.com/en-us/sql/relational-databases/indexes/clustered-and-nonclustered-indexes-described?view=sql-server-ver17#indexes-and-constraints 
+		$is_mssql = in_array($this->db->get_sql_layer(), ['mssqlnative', 'mssql_odbc']);
 		foreach ($index_data_row as $index_name => $index_data)
 		{
 			switch ($index_name)
 			{
 				case 'i_simple':
 					$this->assertEquals(['user_id', 'endpoint'], $index_data['columns']);
-					$this->assertEquals($is_mssql ? ['clustered'] : [], $index_data['flags']);
+					$this->assertEquals($is_mssql ? ['nonclustered'] : [], $index_data['flags']);
 					$this->assertFalse($index_data['is_primary']);
 					$this->assertFalse($index_data['is_unique']);
 					$this->assertTrue($index_data['is_simple']);
@@ -432,7 +434,7 @@ class phpbb_dbal_migrator_test extends phpbb_database_test_case
 				break;
 				case 'i_uniq':
 					$this->assertEquals(['expiration_time', 'p256dh'], $index_data['columns']);
-					$this->assertEquals($is_mssql ? ['clustered'] : [], $index_data['flags']);
+					$this->assertEquals($is_mssql ? ['nonclustered'] : [], $index_data['flags']);
 					$this->assertFalse($index_data['is_primary']);
 					$this->assertTrue($index_data['is_unique']);
 					$this->assertFalse($index_data['is_simple']);
@@ -442,7 +444,7 @@ class phpbb_dbal_migrator_test extends phpbb_database_test_case
 				break;
 				case 'i_auth':
 					$this->assertEquals(['auth'], $index_data['columns']);
-					$this->assertEquals($is_mssql ? ['clustered'] : [], $index_data['flags']);
+					$this->assertEquals($is_mssql ? ['nonclustered'] : [], $index_data['flags']);
 					$this->assertFalse($index_data['is_primary']);
 					$this->assertFalse($index_data['is_unique']);
 					$this->assertTrue($index_data['is_simple']);