Merge pull request #6616 from danieltj27/ticket/17317

[ticket/17317] Change button text for pm recipient to increase readability
[ticket/17317] Remove unused CSS styling for inputs
2025-07-24 02:48:56 +00:00 · 2024-05-30 08:54:55 +02:00 · 2024-05-23 20:57:36 +02:00 · 2024-05-23 20:57:34 +02:00 · 2024-05-23 20:57:33 +02:00 · 2024-05-23 20:57:31 +02:00
2 changed files with 16 additions and 10 deletions
--- a/phpBB/styles/prosilver/template/posting_pm_header.html
+++ b/phpBB/styles/prosilver/template/posting_pm_header.html
@ -31,7 +31,11 @@
 					<ul class="recipients">
 						<!-- BEGIN to_recipient -->
 						<li>
-							<!-- IF not S_EDIT_POST --><input type="submit" name="remove_{to_recipient.TYPE}[{to_recipient.UG_ID}]" value="x" class="button2" /><!-- ENDIF -->
+							<!-- IF not S_EDIT_POST -->
+								<button type="submit" name="remove_{to_recipient.TYPE}[{to_recipient.UG_ID}]">
+									<i class="icon fa-times icon-red" aria-hidden="true"></i><span class="sr-only">{L_REMOVE}</span>
+								</button>
+							<!-- ENDIF -->
 							<!-- IF to_recipient.IS_GROUP --><a href="{to_recipient.U_VIEW}" style="color: {{ to_recipient.COLOUR }}"><strong>{to_recipient.NAME}</strong></a><!-- ELSE -->{to_recipient.NAME_FULL}<!-- ENDIF -->
 						</li>
 						<!-- END to_recipient -->
@ -48,7 +52,11 @@
 					<ul class="recipients">
 						<!-- BEGIN bcc_recipient -->
 						<li>
-							<!-- IF not S_EDIT_POST --><input type="submit" name="remove_{bcc_recipient.TYPE}[{bcc_recipient.UG_ID}]" value="x" class="button2" /><!-- ENDIF -->
+							<!-- IF not S_EDIT_POST -->
+								<button type="submit" name="remove_{bcc_recipient.TYPE}[{bcc_recipient.UG_ID}]">
+									<i class="icon fa-times icon-red" aria-hidden="true"></i><span class="sr-only">{L_REMOVE}</span>
+								</button>
+							<!-- ENDIF -->
 							<!-- IF bcc_recipient.IS_GROUP --><a href="{bcc_recipient.U_VIEW}" style="color: {{ bcc_recipient.COLOUR }}"><strong>{bcc_recipient.NAME}</strong></a><!-- ELSE -->{bcc_recipient.NAME_FULL}<!-- ENDIF -->
 						</li>
 						<!-- END bcc_recipient -->
@ -69,8 +77,12 @@
 						<ul class="recipients">
 							<!-- BEGIN to_recipient -->
 							<li>
-								<!-- IF to_recipient.IS_GROUP --><a href="{to_recipient.U_VIEW}"><strong>{to_recipient.NAME}</strong></a><!-- ELSE -->{to_recipient.NAME_FULL}<!-- ENDIF -->&nbsp;
-								<!-- IF not S_EDIT_POST --><input type="submit" name="remove_{to_recipient.TYPE}[{to_recipient.UG_ID}]" value="x" class="button2" /><!-- ENDIF -->
+								<!-- IF not S_EDIT_POST -->
+									<button type="submit" name="remove_{to_recipient.TYPE}[{to_recipient.UG_ID}]">
+										<i class="icon fa-times icon-red" aria-hidden="true"></i><span class="sr-only">{L_REMOVE}</span>
+									</button>
+								<!-- ENDIF -->
+								<!-- IF to_recipient.IS_GROUP --><a href="{to_recipient.U_VIEW}"><strong>{to_recipient.NAME}</strong></a><!-- ELSE -->{to_recipient.NAME_FULL}<!-- ENDIF -->
 							</li>
 							<!-- END to_recipient -->
 						</ul>
--- a/phpBB/styles/prosilver/theme/common.css
+++ b/phpBB/styles/prosilver/theme/common.css
@ -780,12 +780,6 @@ fieldset.fields1 dd.recipients {
 	margin-left: 1em;
 }

-fieldset.fields1 ul.recipients  input.button2 {
-	font-size: 0.8em;
-	margin-right: 0;
-	padding: 0;
-}
-
 fieldset.fields1 dl.pmlist > dt {
 	width: auto !important;
 }
Author	SHA1	Message	Date
Marc Alexander	df5fcafcb9	Merge pull request #6616 from danieltj27/ticket/17317 [ticket/17317] Change button text for pm recipient to increase readability	2024-05-30 08:54:55 +02:00
Daniel James	92e545fc26	[ticket/17317] Remove unused CSS styling for inputs PHPBB3-17317	2024-05-23 20:57:36 +02:00
Daniel James	c330500c4d	[ticket/17317] Add new icon for groups and remove CSS change PHPBB3-17317	2024-05-23 20:57:34 +02:00
Daniel James	9fcf956888	[ticket/17317] Replace button with small red fa-icon Updated the button to a small red X using Font Awesome rather than using the default phpBB button with text which adds a better visual distinction in the interface between the username and action. Credit to @iMattPro for the suggestion in the ticket comments. PHPBB3-17317	2024-05-23 20:57:33 +02:00
Daniel James	40ed6c6458	[ticket/17317] Fix padding on button, left and right not top and bottom PHPBB3-17317	2024-05-23 20:57:31 +02:00
Daniel James	cd34cdedee	[ticket/17317] Change button text for pm recipient to increase readability PHPBB3-17317	2024-05-23 20:57:26 +02:00