makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-28 06:08:52 +00:00
Code Issues Projects Releases Packages Wiki Activity
phpBB Development: phpBB is a popular open-source bulletin board written in PHP. This repository also contains the history of version 2.
11123 commits 18 branches 192 tags 207 MiB
PHP 88.1%
HTML 7.3%
JavaScript 2.7%
CSS 1.6%
Shell 0.2%
Find a file
Andreas Fischer ee875c0a43 [ticket/10790] Remove a (kind of) dead code section from submit_pm(). 
The type of $user->data['user_id'] is (almost) guranteed to be integer
since session::session_create() casts it to integer.
The type of $row['user_id'] is only an integer if the DB driver adjusts the
PHP type according to the DB type. This is only done by some of our
not-so-popular DB drivers and is not the case for MySQL.

As such this comparison is (almost) never true and a PM is also sent to the
author itself when it is sent to a group the author is also a member of.

Since this behaviour seems to have been accepted by the communty, the dead
code is removed and current behaviour is kept.

Also, checking this in the loop seems to be a rather bad idea.

Introduced by 78b1c4caaa.

PHPBB3-10790
2012-05-22 02:24:31 +02:00
build Merge remote-tracking branch 'unknownbliss/ticket/9916-olympus' into develop-olympus 2012-01-02 17:35:49 +01:00
git-tools [ticket/10767] Clarify what happens at the end of the hook. 2012-04-17 06:05:33 -04:00
phpBB [ticket/10790] Remove a (kind of) dead code section from submit_pm(). 2012-05-22 02:24:31 +02:00
tests Merge remote-tracking branch 'p/ticket/10891' into develop-olympus 2012-05-13 20:08:49 +02:00
travis [ticket/10492] Skip functional tests on PHP 5.2 on travis 2012-05-11 15:35:57 +02:00
vendor [ticket/10492] Backporting functional tests 2012-04-21 04:37:57 -05:00
.gitignore Merge pull request #668 from unknownbliss/feature/events-dispatcher-olympus 2012-03-30 11:15:54 -07:00
.travis.yml [task/travis] Refactor php version check for dbunit install 2012-03-22 16:09:58 +00:00
phpunit.xml.all [ticket/10492] Backporting functional tests 2012-04-21 04:37:57 -05:00
phpunit.xml.dist [ticket/10492] Backporting functional tests 2012-04-21 04:37:57 -05:00
phpunit.xml.functional [ticket/10492] Backporting functional tests 2012-04-21 04:37:57 -05:00
README.md [task/travis] Fixing some travis issues 2012-03-22 13:32:58 +00:00

README.md

phpBB

ABOUT

phpBB is a free bulletin board written in PHP.

COMMUNITY

Find support and lots more on phpBB.com! Discuss the development on area51.

CONTRIBUTE

  1. Create an account on phpBB.com
  2. Create a ticket (unless there already is one)
  3. Read our Git Contribution Guidelines; if you're new to git, also read the introduction guide
  4. Send us a pull request

AUTOMATED TESTING

We have unit and functional tests in order to prevent regressions. You can view the bamboo continuous integration here or check our travis build below. develop - Build Status develop-olympus - Build Status

LICENSE

GNU General Public License v2