mirror of
https://github.com/phpbb/phpbb.git
synced 2025-06-11 22:08:54 +00:00
f039a3308a
* github-phpbb/develop: [ticket/11832] Correct paths in tests [ticket/11832] Correct ROOT_PATH variable [ticket/11832] get_url() from phpbb_template_asset should return web path [ticket/11832] Fix INCLUDE(JS/CSS) [ticket/11832] Fix constructions of phpbb_filesystem [ticket/11832] Fix smiley paths [ticket/11832] Create phpbb_symfony_request to handle initiating symfony_request [ticket/11832] Fix build_url and the S_LOGIN_ACTION [ticket/11832] Changing comments to say app.php rather than index.php [ticket/11832] We must instantiate the $phpbb_filesystem in common [ticket/11832] Fix the web path corrections [ticket/11832] More extensive testing [ticket/11832] Use dirname(__FILE__) [ticket/11832] Use $phpbb_filesystem instead of the container in append_sid Revert "[ticket/11832] Make $phpbb_container a global initiated by the framework" [ticket/11832] Make $phpbb_container a global initiated by the framework [ticket/11832] Fix log tests [ticket/11832] update_web_root_path helper and tests [ticket/11832] Inject dependencies for phpbb_get_web_root_path (also moving) Conflicts: phpBB/common.php phpBB/config/services.yml phpBB/includes/bbcode.php phpBB/includes/functions.php phpBB/includes/functions_messenger.php phpBB/install/index.php phpBB/phpbb/filesystem.php phpBB/phpbb/template/twig/environment.php phpBB/phpbb/template/twig/node/includeasset.php phpBB/phpbb/template/twig/twig.php tests/controller/helper_url_test.php tests/dbal/migrator_test.php tests/extension/manager_test.php tests/extension/metadata_manager_test.php tests/filesystem/clean_path_test.php tests/mock/extension_manager.php tests/template/template_events_test.php tests/template/template_test_case.php tests/template/template_test_case_with_tree.php tests/test_framework/phpbb_functional_test_case.php
117 lines
5.8 KiB
PHP
117 lines
5.8 KiB
PHP
<?php
|
|
/**
|
|
*
|
|
* @package testing
|
|
* @copyright (c) 2013 phpBB Group
|
|
* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
|
|
*
|
|
*/
|
|
|
|
require_once dirname(__FILE__) . '/../../phpBB/includes/functions.php';
|
|
|
|
class phpbb_controller_helper_url_test extends phpbb_test_case
|
|
{
|
|
|
|
public function helper_url_data_no_rewrite()
|
|
{
|
|
return array(
|
|
array('foo/bar?t=1&f=2', false, true, false, 'app.php/foo/bar?t=1&f=2', 'parameters in url-argument'),
|
|
array('foo/bar', 't=1&f=2', true, false, 'app.php/foo/bar?t=1&f=2', 'parameters in params-argument using amp'),
|
|
array('foo/bar', 't=1&f=2', false, false, 'app.php/foo/bar?t=1&f=2', 'parameters in params-argument using &'),
|
|
array('foo/bar', array('t' => 1, 'f' => 2), true, false, 'app.php/foo/bar?t=1&f=2', 'parameters in params-argument as array'),
|
|
|
|
// Custom sid parameter
|
|
array('foo/bar', 't=1&f=2', true, 'custom-sid', 'app.php/foo/bar?t=1&f=2&sid=custom-sid', 'using session_id'),
|
|
|
|
// Testing anchors
|
|
array('foo/bar?t=1&f=2#anchor', false, true, false, 'app.php/foo/bar?t=1&f=2#anchor', 'anchor in url-argument'),
|
|
array('foo/bar', 't=1&f=2#anchor', true, false, 'app.php/foo/bar?t=1&f=2#anchor', 'anchor in params-argument'),
|
|
array('foo/bar', array('t' => 1, 'f' => 2, '#' => 'anchor'), true, false, 'app.php/foo/bar?t=1&f=2#anchor', 'anchor in params-argument (array)'),
|
|
|
|
// Anchors and custom sid
|
|
array('foo/bar?t=1&f=2#anchor', false, true, 'custom-sid', 'app.php/foo/bar?t=1&f=2&sid=custom-sid#anchor', 'anchor in url-argument using session_id'),
|
|
array('foo/bar', 't=1&f=2#anchor', true, 'custom-sid', 'app.php/foo/bar?t=1&f=2&sid=custom-sid#anchor', 'anchor in params-argument using session_id'),
|
|
array('foo/bar', array('t' => 1, 'f' => 2, '#' => 'anchor'), true, 'custom-sid', 'app.php/foo/bar?t=1&f=2&sid=custom-sid#anchor', 'anchor in params-argument (array) using session_id'),
|
|
|
|
// Empty parameters should not append the &
|
|
array('foo/bar', false, true, false, 'app.php/foo/bar', 'no params using bool false'),
|
|
array('foo/bar', '', true, false, 'app.php/foo/bar', 'no params using empty string'),
|
|
array('foo/bar', array(), true, false, 'app.php/foo/bar', 'no params using empty array'),
|
|
);
|
|
}
|
|
|
|
/**
|
|
* @dataProvider helper_url_data_no_rewrite()
|
|
*/
|
|
public function test_helper_url_no_rewrite($route, $params, $is_amp, $session_id, $expected, $description)
|
|
{
|
|
global $phpbb_dispatcher, $phpbb_root_path, $phpEx;
|
|
|
|
$phpbb_dispatcher = new phpbb_mock_event_dispatcher;
|
|
$this->user = $this->getMock('\phpbb\user');
|
|
$phpbb_filesystem = new \phpbb\filesystem(
|
|
new \phpbb\symfony\request(
|
|
new phpbb_mock_request()
|
|
),
|
|
$phpbb_root_path,
|
|
$phpEx
|
|
);
|
|
$this->template = new phpbb\template\twig\twig($phpbb_filesystem, $config, $this->user, new \phpbb\template\context());
|
|
|
|
// We don't use mod_rewrite in these tests
|
|
$config = new \phpbb\config\config(array('enable_mod_rewrite' => '0'));
|
|
$helper = new \phpbb\controller\helper($this->template, $this->user, $config, '', 'php');
|
|
$this->assertEquals($helper->url($route, $params, $is_amp, $session_id), $expected);
|
|
}
|
|
|
|
public function helper_url_data_with_rewrite()
|
|
{
|
|
return array(
|
|
array('foo/bar?t=1&f=2', false, true, false, 'foo/bar?t=1&f=2', 'parameters in url-argument'),
|
|
array('foo/bar', 't=1&f=2', true, false, 'foo/bar?t=1&f=2', 'parameters in params-argument using amp'),
|
|
array('foo/bar', 't=1&f=2', false, false, 'foo/bar?t=1&f=2', 'parameters in params-argument using &'),
|
|
array('foo/bar', array('t' => 1, 'f' => 2), true, false, 'foo/bar?t=1&f=2', 'parameters in params-argument as array'),
|
|
|
|
// Custom sid parameter
|
|
array('foo/bar', 't=1&f=2', true, 'custom-sid', 'foo/bar?t=1&f=2&sid=custom-sid', 'using session_id'),
|
|
|
|
// Testing anchors
|
|
array('foo/bar?t=1&f=2#anchor', false, true, false, 'foo/bar?t=1&f=2#anchor', 'anchor in url-argument'),
|
|
array('foo/bar', 't=1&f=2#anchor', true, false, 'foo/bar?t=1&f=2#anchor', 'anchor in params-argument'),
|
|
array('foo/bar', array('t' => 1, 'f' => 2, '#' => 'anchor'), true, false, 'foo/bar?t=1&f=2#anchor', 'anchor in params-argument (array)'),
|
|
|
|
// Anchors and custom sid
|
|
array('foo/bar?t=1&f=2#anchor', false, true, 'custom-sid', 'foo/bar?t=1&f=2&sid=custom-sid#anchor', 'anchor in url-argument using session_id'),
|
|
array('foo/bar', 't=1&f=2#anchor', true, 'custom-sid', 'foo/bar?t=1&f=2&sid=custom-sid#anchor', 'anchor in params-argument using session_id'),
|
|
array('foo/bar', array('t' => 1, 'f' => 2, '#' => 'anchor'), true, 'custom-sid', 'foo/bar?t=1&f=2&sid=custom-sid#anchor', 'anchor in params-argument (array) using session_id'),
|
|
|
|
// Empty parameters should not append the &
|
|
array('foo/bar', false, true, false, 'foo/bar', 'no params using bool false'),
|
|
array('foo/bar', '', true, false, 'foo/bar', 'no params using empty string'),
|
|
array('foo/bar', array(), true, false, 'foo/bar', 'no params using empty array'),
|
|
);
|
|
}
|
|
|
|
/**
|
|
* @dataProvider helper_url_data_with_rewrite()
|
|
*/
|
|
public function test_helper_url_with_rewrite($route, $params, $is_amp, $session_id, $expected, $description)
|
|
{
|
|
global $phpbb_dispatcher, $phpbb_root_path, $phpEx;
|
|
|
|
$phpbb_dispatcher = new phpbb_mock_event_dispatcher;
|
|
$this->user = $this->getMock('\phpbb\user');
|
|
$phpbb_filesystem = new \phpbb\filesystem(
|
|
new \phpbb\symfony\request(
|
|
new phpbb_mock_request()
|
|
),
|
|
$phpbb_root_path,
|
|
$phpEx
|
|
);
|
|
$this->template = new \phpbb\template\twig\twig($phpbb_filesystem, $config, $this->user, new \phpbb\template\context());
|
|
|
|
$config = new \phpbb\config\config(array('enable_mod_rewrite' => '1'));
|
|
$helper = new \phpbb\controller\helper($this->template, $this->user, $config, '', 'php');
|
|
$this->assertEquals($helper->url($route, $params, $is_amp, $session_id), $expected);
|
|
}
|
|
}
|