[ticket/17457] Remove dir from manifest, it’s not implemented

PHPBB-17457

phpBB/config/default/container/services.yml

@@ -161,7 +161,6 @@ services:
         class: phpbb\manifest
         arguments:
             - '@config'
-            - '@language'
             - '@path_helper'
             - '@event_dispatcher'
             - '@user'

phpBB/phpbb/manifest.php

@@ -16,7 +16,6 @@ namespace phpbb;
 use phpbb\config\config;
 use phpbb\event\dispatcher_interface;
 use phpbb\exception\http_exception;
-use phpbb\language\language;
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\Response;
 
@@ -25,9 +24,6 @@ class manifest
 	/** @var config */
 	protected $config;
 
-	/** @var language */
-	protected $language;
-
 	/** @var path_helper */
 	protected $path_helper;
 
@@ -41,17 +37,15 @@ class manifest
 	 * Constructor for manifest controller
 	 *
 	 * @param config $config
-	 * @param language $language
 	 * @param path_helper $path_helper
 	 * @param dispatcher_interface $phpbb_dispatcher
 	 * @param user $user
 	 */
-	public function __construct(config $config, language $language, path_helper $path_helper, dispatcher_interface $phpbb_dispatcher, user $user)
+	public function __construct(config $config, path_helper $path_helper, dispatcher_interface $phpbb_dispatcher, user $user)
 	{
 		$this->config = $config;
 		$this->path_helper = $path_helper;
 		$this->phpbb_dispatcher = $phpbb_dispatcher;
-		$this->language = $language;
 		$this->user = $user;
 	}
 
@@ -77,7 +71,6 @@ class manifest
 			'short_name'	=> $sitename_short ?: utf8_substr($sitename, 0, 12),
 			'display'		=> 'standalone',
 			'orientation'	=> 'portrait',
-			'dir'			=> $this->language->lang('DIRECTION'),
 			'start_url'		=> $board_path,
 			'scope'			=> $board_path,
 		];

tests/functional/manifest_test.php

@@ -25,7 +25,6 @@ class phpbb_functional_manifest_test extends phpbb_functional_test_case
 			'short_name'	=> 'yourdomain',
 			'display'		=> 'standalone',
 			'orientation'	=> 'portrait',
-			'dir'			=> 'ltr',
 			'start_url'		=> $url_path,
 			'scope'			=> $url_path,
 		];