makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-08 04:18:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/17457] Remove dir from manifest, it’s not implemented

Browse source 
PHPBB-17457
This commit is contained in:
Matt Friedman 2024-12-20 20:18:31 -08:00
parent 3ffdb4cce3
commit b6b0973e9e
No known key found for this signature in database
3 changed files with 1 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
phpBB/config/default/container/services.yml
View file

@ -161,7 +161,6 @@ services:
class: phpbb\manifest class: phpbb\manifest
arguments: arguments:
- '@config' - '@config'
- '@language'
- '@path_helper' - '@path_helper'
- '@event_dispatcher' - '@event_dispatcher'
- '@user' - '@user'

9
phpBB/phpbb/manifest.php
View file

@ -16,7 +16,6 @@ namespace phpbb;
use phpbb\config\config; use phpbb\config\config;
use phpbb\event\dispatcher_interface; use phpbb\event\dispatcher_interface;
use phpbb\exception\http_exception; use phpbb\exception\http_exception;
use phpbb\language\language;
use Symfony\Component\HttpFoundation\JsonResponse; use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\Response; use Symfony\Component\HttpFoundation\Response;
@ -25,9 +24,6 @@ class manifest
/** @var config */ /** @var config */
protected $config; protected $config;
/** @var language */
protected $language;
/** @var path_helper */ /** @var path_helper */
protected $path_helper; protected $path_helper;
@ -41,17 +37,15 @@ class manifest
* Constructor for manifest controller * Constructor for manifest controller
* *
* @param config $config * @param config $config
* @param language $language
* @param path_helper $path_helper * @param path_helper $path_helper
* @param dispatcher_interface $phpbb_dispatcher * @param dispatcher_interface $phpbb_dispatcher
* @param user $user * @param user $user
*/ */
public function __construct(config $config, language $language, path_helper $path_helper, dispatcher_interface $phpbb_dispatcher, user $user) public function __construct(config $config, path_helper $path_helper, dispatcher_interface $phpbb_dispatcher, user $user)
{ {
$this->config = $config; $this->config = $config;
$this->path_helper = $path_helper; $this->path_helper = $path_helper;
$this->phpbb_dispatcher = $phpbb_dispatcher; $this->phpbb_dispatcher = $phpbb_dispatcher;
$this->language = $language;
$this->user = $user; $this->user = $user;
} }
@ -77,7 +71,6 @@ class manifest
'short_name' => $sitename_short ?: utf8_substr($sitename, 0, 12), 'short_name' => $sitename_short ?: utf8_substr($sitename, 0, 12),
'display' => 'standalone', 'display' => 'standalone',
'orientation' => 'portrait', 'orientation' => 'portrait',
'dir' => $this->language->lang('DIRECTION'),
'start_url' => $board_path, 'start_url' => $board_path,
'scope' => $board_path, 'scope' => $board_path,
]; ];

1
tests/functional/manifest_test.php
View file

@ -25,7 +25,6 @@ class phpbb_functional_manifest_test extends phpbb_functional_test_case
'short_name' => 'yourdomain', 'short_name' => 'yourdomain',
'display' => 'standalone', 'display' => 'standalone',
'orientation' => 'portrait', 'orientation' => 'portrait',
'dir' => 'ltr',
'start_url' => $url_path, 'start_url' => $url_path,
'scope' => $url_path, 'scope' => $url_path,
]; ];