Merge pull request #6801 from iMattPro/ticket/17494

[ticket/17494] Handle boolean attributes in checkbox assertions tests
This commit is contained in:
Marc Alexander 2025-04-15 21:07:17 +02:00 committed by GitHub
commit d5ac95f79f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -1236,12 +1236,11 @@ class phpbb_functional_test_case extends phpbb_test_case
* @param string $name * @param string $name
* @param string $message * @param string $message
* *
* @return null * @return void
*/ */
public function assert_checkbox_is_checked($crawler, $name, $message = '') public function assert_checkbox_is_checked($crawler, $name, $message = '')
{ {
$this->assertSame( $this->assertNotNull(
'checked',
$this->assert_find_one_checkbox($crawler, $name)->attr('checked'), $this->assert_find_one_checkbox($crawler, $name)->attr('checked'),
$message ?: "Failed asserting that checkbox $name is checked." $message ?: "Failed asserting that checkbox $name is checked."
); );
@ -1255,7 +1254,7 @@ class phpbb_functional_test_case extends phpbb_test_case
* @param string $name * @param string $name
* @param string $message * @param string $message
* *
* @return null * @return void
*/ */
public function assert_checkbox_is_unchecked($crawler, $name, $message = '') public function assert_checkbox_is_unchecked($crawler, $name, $message = '')
{ {