[git-tools] Some pre-commit enhancements, abolish tempfile

This commit is contained in:
Igor Wiedler 2010-03-11 19:44:21 +01:00
parent 6df10358aa
commit f9192bed79

View file

@ -12,6 +12,8 @@
# ln -s ../../git-tools/hooks/pre-commit \\ # ln -s ../../git-tools/hooks/pre-commit \\
# .git/hooks/pre-commit # .git/hooks/pre-commit
PHP_BIN=php
# necessary check for initial commit # necessary check for initial commit
if git rev-parse --verify HEAD >/dev/null 2>&1 if git rev-parse --verify HEAD >/dev/null 2>&1
then then
@ -27,12 +29,10 @@ error=0
IFS=" " IFS=" "
for file in $(git diff --cached --name-status $against | grep -v -E '^D' | cut -f2 | grep -E '\.php$') for file in $(git diff --cached --name-status $against | grep -v -E '^D' | cut -f2 | grep -E '\.php$')
do do
# store lint result in a temp file # hide output, but show errors
tempfile=$(mktemp -t "$(basename $0).XXXXXX") if ! $PHP_BIN -l "$file" >/dev/null
if ! php -l "$file" >/dev/null 2>"$tempfile"
then then
error=1 error=1
cat "$tempfile"
fi fi
done done
unset IFS unset IFS