makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-28 14:18:52 +00:00
Code Issues Projects Releases Packages Wiki Activity
14113 commits 18 branches 192 tags 207 MiB
Commit graph

14113 commits

This branch
This branch
All branches
Author SHA1 Message Date
Joas Schilling
526721c7db [feature/soft-delete] Fix set_topic_visibility() so it passes the tests 
PHPBB3-9567
 2012-10-05 14:26:52 +02:00
Joas Schilling
b9d363f6cc [feature/soft-delete] Add unit tests for set_topic_visibility() 
PHPBB3-9567
 2012-10-05 14:26:09 +02:00
Joas Schilling
7969cc7319 [feature/soft-delete] Fix docs of set_post_visibility() 
PHPBB3-9567
 2012-10-05 13:31:47 +02:00
Joas Schilling
01a78907bd [feature/soft-delete] Update set_topic_visibility() with some more logic 
By default, when a soft deleted topic is restored. Only posts that were
approved at the time of soft deleting, are being restored. Same applies to
soft deleting. Only approved posts will be marked as soft deleted.

If you want to update all posts, use the force option.

PHPBB3-9567
 2012-10-05 13:30:59 +02:00
Joas Schilling
92c5039af9 [feature/soft-delete] Allow forcing the set_visibility for all posts 
PHPBB3-9567
 2012-10-05 13:18:06 +02:00
Joas Schilling
42bb97a95c [feature/soft-delete] Make use of set_post_visibility() limits when applicable 
PHPBB3-9567
 2012-10-05 13:15:55 +02:00
Joas Schilling
bfa6a50a4f [feature/soft-delete] Extend functionality for updating a hole topic 
Limit the posts to a certain visibility and deletion time
This allows us to only restore posts, that were approved
when the topic got soft deleted. So previous soft deleted
and unapproved posts are still soft deleted/unapproved

PHPBB3-9567
 2012-10-05 13:12:36 +02:00
Joas Schilling
63d11c976b [feature/soft-delete] Fix sync('topic') to match the new logic 
This also fixes set_post_visibility()

PHPBB3-9567
 2012-10-05 12:39:05 +02:00
Joas Schilling
2a81e4b48e [feature/soft-delete] Fix the get functions to match the new logic 
PHPBB3-9567
 2012-10-05 12:06:36 +02:00
Joas Schilling
959525cebe [feature/soft-delete] Merge functionality of m_approve and m_restore 
The problems with having two different permissions are just too big and cause
huge queries, if they are granted differently. Also it's quite hard to decide
what should happen when a moderator has only one permission and the topic has
only posts of the two hidden types. To avoid all this, we merge them so it's a
simple switch: either the user is a moderator, then he can see all posts,
or he is not, then he can only see approved ones.

PHPBB3-9567
 2012-10-05 12:05:22 +02:00
Joas Schilling
b8642d7c8a [feature/soft-delete] Test topic visibility as well 
PHPBB3-9657
 2012-10-05 11:04:56 +02:00
Joas Schilling
5b64ebc11d [feature/soft-delete] Fix a bug in sync() and set_post_visibility() 
PHPBB3-9657
 2012-10-02 15:34:18 +02:00
Joas Schilling
1f8f07b998 [feature/soft-delete] Add unit tests for simple cases of set_post_visibility 
These tests require at least one remaining post.

PHPBB3-9657
 2012-10-02 15:32:12 +02:00
Joas Schilling
c36c69c1d4 [feature/soft-delete] Remove unneeded require_once() 
PHPBB3-9657
 2012-10-02 12:54:47 +02:00
Joas Schilling
a84e4029e4 [feature/soft-delete] Update doc blocks to proper format 
PHPBB3-9657
 2012-10-02 12:51:59 +02:00
Joas Schilling
b629b2cd95 [feature/soft-delete] Add unit tests for get_global_visibility_sql() 
PHPBB3-9657
 2012-10-01 22:44:39 +02:00
Joas Schilling
4a65940e62 [feature/soft-delete] Add unit tests for get_forums_visibility_sql() 
PHPBB3-9657
 2012-10-01 22:14:04 +02:00
Joas Schilling
280619eea9 [feature/soft-delete] Add unit tests for get_visibility_sql() 
PHPBB3-9657
 2012-10-01 17:13:15 +02:00
Joas Schilling
38d83da69e [feature/soft-delete] Remove old unit tests 
PHPBB3-9657
 2012-10-01 16:38:28 +02:00
Joas Schilling
1943de36f3 [feature/soft-delete] Comment out user_posts update for the moment 
It should rely on the permissions of the post not the current user.

PHPBB3-9657
 2012-10-01 16:25:05 +02:00
Joas Schilling
e5377e98c7 [feature/soft-delete] Allow setting the visibility change reason 
PHPBB3-9657
 2012-09-28 16:53:38 +02:00
Joas Schilling
dc2835af78 [feature/soft-delete] Add columns for soft delete details 
PHPBB3-9657
 2012-09-28 16:17:21 +02:00
Joas Schilling
8b2181eb85 [feature/soft-delete] Comment out stuff about f_restore for performance reason 
PHPBB3-9657
 2012-09-28 16:14:44 +02:00
Joas Schilling
3bc3cf6e00 [feature/soft-delete] Update column names in update script and add permissions 
PHPBB3-9657
 2012-08-30 23:05:28 +02:00
Joas Schilling
c03d692a98 [feature/soft-delete] Fix some more usages of _approved column names 
PHPBB3-9657
 2012-08-30 22:57:00 +02:00
Joas Schilling
625e7ef58a [feature/soft-delete] Update development scripts with new column names 
PHPBB3-9657
 2012-08-30 22:54:24 +02:00
Joas Schilling
a6d3432f8b [feature/soft-delete] Update search to use $post_visibility 
Todo: Sphinx currently does not respect this setting at all.

PHPBB3-9657
 2012-08-30 22:20:52 +02:00
Joas Schilling
5b54ec2d64 [feature/soft-delete] Try to fix search.php 
at least it's running now, but the performance is not very good.

PHPBB3-9657
 2012-08-30 19:47:16 +02:00
Joas Schilling
1c043254c0 [feature/soft-delete] Add get_visibility_sql_forums based on global 
The resulting query is 4-times faster, as the forum_id IN () arrays are
smaller and we need less AND/OR to build the hole query. The main difference
between those two functions is, that this one takes an array of included ids and
the _global one takes an array of excluded ids.

PHPBB3-9657
 2012-08-30 18:07:00 +02:00
Joas Schilling
df83f22b71 [feature/soft-delete] Fix copy-paste fail for database update on the index 
PHPBB3-9657
 2012-08-30 16:21:27 +02:00
Joas Schilling
a1e0690b6b [feature/soft-delete] Simplification part2: user can see all item visibilities 
If the user can see all visibilities, we can simply leave out the query part,
instead of adding a bunch of ANDs.

PHPBB3-9657
 2012-08-29 22:12:33 +02:00
Joas Schilling
44ed05f567 [feature/soft-delete] Simplify the query output if the user has m_restore 
PHPBB3-9657
 2012-08-29 19:30:33 +02:00
Joas Schilling
36c9f6aa87 [feature/soft-delete] Update posts and topics table with database_update.php 
PHPBB3-9657
 2012-08-29 19:11:33 +02:00
Joas Schilling
8a036fa3e4 [feature/soft-delete] Update restoring feature to use ajax if requested. 
Also fixes the mcp as a hole:
- displayes a success message
- gives a link to the post, if only one was restored

PHPBB3-9657
 2012-08-29 18:42:14 +02:00
Joas Schilling
b774c09c7f [feature/soft-delete] Use the variable which holds the correct item status 
PHPBB3-9657
 2012-08-29 17:50:14 +02:00
Joas Schilling
d9a93a9cdc [feature/soft-delete] Fix missing AND in query 
PHPBB3-9657
 2012-08-29 17:50:14 +02:00
Joas Schilling
910f1602cd [feature/soft-delete] Fix displaying of "deleted post" note in viewtopic 
PHPBB3-9657
 2012-08-29 17:50:14 +02:00
Joas Schilling
9300ff4c6e [feature/soft-delete] Remove imageset/ which was created by merge conflict 
We don't have imagesets in 3.1 anymore.

PHPBB3-9657
 2012-08-29 17:50:13 +02:00
Joas Schilling
9abfba5191 [feature/soft-delete] Fix the schema files to the correct line ends again 
PHPBB3-9657
 2012-08-29 17:50:13 +02:00
Joas Schilling
1935568c3e [feature/soft-delete] Fix typo in column name topic_visibility 
PHPBB3-9657
 2012-08-29 17:50:13 +02:00
Joas Schilling
5ff35ccf72 [feature/soft-delete] Use autoloading for content_visibility class 
PHPBB3-9657
 2012-08-29 17:50:12 +02:00
Josh Woody
1ab41f8dc6 [feature/soft-delete] Fix some small bugs 
To wit: using non-existing constant POST_DELETED in posting.php; first test
post was initially unapproved; soft delete checkbox appeared at post time
Links pointing to the wrong place.

PHPBB3-9657
 2012-08-29 17:50:12 +02:00
Josh Woody
f570558a8d [feature/soft-delete] Add a processor for action == restore in mcp_queue.php 
Restoring a post within mcp_queue.php didn't do anything before this commit.  Now it does, by way of a function which is very similar to approve_post.

PHPBB3-9657
 2012-08-29 17:50:12 +02:00
Josh Woody
a80cfafdd9 [feature/soft-delete] Rename phpbb_visibility class to phpbb_content_visibility 
Rename the class to more accurately reflect what it does.

PHPBB3-9657
 2012-08-29 17:50:11 +02:00
Josh Woody
6739375135 [feature/soft-delete] Add unit tests for the phpbb_visibility class 
Add unit tests for the phpbb_visibility class.  Adjust the phpbb_visibility class to pass those unit tests.  The changes are pretty small, actually.

PHPBB3-9657
 2012-08-29 17:50:11 +02:00
Josh Woody
fb13ab83e4 [feature/soft-delete] Implement the ability to soft-delete and restore posts 
The soft delete feature seems to work.  Tests are pending.  A real icon is pending.  Add the permissions and the interface to soft-delete posts.  Also able to restore posts via the MCP queue

PHPBB3-9657
 2012-08-29 17:50:11 +02:00
Josh Woody
c32d760806 [feature/soft-delete] I told you I was going to rename the class! 
Rename topic_visibility class to phpbb_visibility. Also a bit of work to the class itself, mostly cleanup and adding the comments that I'd previously written.

PHPBB3-9657
 2012-08-29 17:49:38 +02:00
Josh Woody
244f6e2ddc [feature/soft-delete] Correct some mistakes in e8d47 
Notably: Uncomment the die() in create_schema_files, and add the class that makes everything tick.

PHPBB3-9657
 2012-08-29 17:49:37 +02:00
Josh Woody
b8c55291ed [feature/soft-delete] Lay the groundwork for a soft-delete feature 
So far, I've added no new functionality.  The biggest change here is adjusting the DB column names to "visibility" rather than "approved".  Some things here are pretty likely to change, for example the name and location of the topic_visibility class. Happy birthday phpBB :)

PHPBB3-9657
 2012-08-29 17:49:37 +02:00
Andreas Fischer
1128ff1e58 Merge remote-tracking branch 'mvinny/ticket/11065' into develop 
* mvinny/ticket/11065:
  [ticket/11065] Close li tag on topic display options at MCP
 2012-08-27 01:35:46 +02:00