makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-28 14:18:52 +00:00
Code Issues Projects Releases Packages Wiki Activity
11933 commits 18 branches 192 tags 207 MiB
Commit graph

11933 commits

This branch
This branch
All branches
Author SHA1 Message Date
erangamapa
8191755cca [ticket/11145] Wrong error thrown when uploading a bigger image. 
When attaching an image to a post with a size larger than maximum defined in
php.ini, 'ATTACHED_IMAGE_NOT_IMAGE' error is thrown. $file->is_image() is
returning false value when image size is too large. Therefore, moved
not image test down after image size test.

PHPBB3-11145
 2013-05-25 10:50:43 +05:30
Nathan Guse
4a93560870 Merge remote-tracking branch 'remotes/imkingdavid/ticket/11551' into develop-olympus 
# By David King
# Via David King
* remotes/imkingdavid/ticket/11551:
  [ticket/11551] Fix error in system tab if get_remote_file returns empty string
 2013-05-20 11:54:22 -05:00
David King
901955e452 [ticket/11551] Fix error in system tab if get_remote_file returns empty string 
Currently a debug error is thrown. With this patch, it fails without keeping
the admin from being able to access the rest of the System modules by showing
a nicer error "Failed to obtain latest version information."

PHPBB3-11551
 2013-05-20 12:20:55 -04:00
Marc Alexander
cd1da92d85 [ticket/11538] Add optional switch as argument to hex colour validation 
The value of $optional will decide whether an empty string will be
treated as incorrect input or if it is allowed. The optional argument
will default to false and therefore treat an empty string as incorrect
unless explicitly told to not do so.

PHPBB3-11538
 2013-05-19 17:45:45 +02:00
Andreas Fischer
4fc180ade5 Merge remote-tracking branch 'marc1706/ticket/11537' into develop-olympus 
* marc1706/ticket/11537:
  [ticket/11537] Adjust error message on ucp group manage to fit rest of ucp
 2013-05-19 15:40:04 +02:00
Marc Alexander
e49b4543de [ticket/11538] Modify test colour values 
PHPBB3-11538
 2013-05-19 15:17:47 +02:00
Marc Alexander
7898dd9459 [ticket/11538] Limit comment in acp_groups to 80 characters per line 
PHPBB3-11538
 2013-05-19 15:13:37 +02:00
Marc Alexander
8aea2b382d [ticket/11538] Move group ID into abstract test class and add more test cases 
The group ID is defined in the abstract class now and additional test cases
for hex colour values have been added.

PHPBB3-11538
 2013-05-19 11:44:26 +02:00
Marc Alexander
373e26ca74 [ticket/11538] Merge calls to validate_data() in acp_groups 
PHPBB3-11538
 2013-05-19 11:38:11 +02:00
Marc Alexander
b49ce5eb3a [ticket/11538] Rename phpbb_validate_colour to phpbb_validate_hex_colour 
PHPBB3-11538
 2013-05-19 11:29:11 +02:00
Marc Alexander
0a5988ec1f [ticket/11538] Use abstract class for functional test cases for group colour 
PHPBB3-11538
 2013-05-17 18:31:17 +02:00
Marc Alexander
30e0b694e6 Merge branch 'develop-olympus' of https://github.com/phpbb/phpbb3 into ticket/11538 2013-05-17 12:22:27 +02:00
Andreas Fischer
37a334c187 Merge remote-tracking branch 'bantu/ticket/11547' into develop-olympus 
* bantu/ticket/11547:
  [ticket/11547] Set MySQL charset to UTF8 in database_test_connection_manager.
 2013-05-17 02:27:12 +02:00
Andreas Fischer
2c3e831128 Merge remote-tracking branch 'nickvergessen/ticket/11542-2' into develop-olympus 
* nickvergessen/ticket/11542-2:
  [ticket/11542] Use Czech as example as it contains non-latin characters
 2013-05-17 02:27:05 +02:00
Joas Schilling
1ee2543309 [ticket/11542] Use Czech as example as it contains non-latin characters 
PHPBB3-11542
 2013-05-17 02:13:51 +02:00
Andreas Fischer
555e89755e Merge remote-tracking branch 'marc1706/ticket/11544' into develop-olympus 
* marc1706/ticket/11544:
  [ticket/11544] Add admin_login() method to 3.0 functional test case
 2013-05-17 01:29:47 +02:00
Andreas Fischer
225aba976e [ticket/11547] Set MySQL charset to UTF8 in database_test_connection_manager. 
PHPBB3-11547
 2013-05-17 01:22:22 +02:00
Andreas Fischer
f2fd0031f4 Merge remote-tracking branch 'nickvergessen/ticket/11542' into develop-olympus 
* nickvergessen/ticket/11542:
  [ticket/11542] Add non-existing default value for language select
  [ticket/11542] Add lang_english_name to fixture
  [ticket/11542] Add unit tests for language_select()
 2013-05-17 00:34:35 +02:00
Joas Schilling
92e1e86e5c [ticket/11542] Add non-existing default value for language select 
PHPBB3-11542
 2013-05-16 23:23:10 +02:00
Andreas Fischer
be71701af7 Merge remote-tracking branch 'galaxyAbstractor/ticket/11536' into develop-olympus 
* galaxyAbstractor/ticket/11536:
  [ticket/11536] Fixed incorrect removal of "install" in script_path
 2013-05-16 19:11:55 +02:00
Andreas Fischer
8e3c2ebf8e Merge remote-tracking branch 'nickvergessen/ticket/11545' into develop-olympus 
* nickvergessen/ticket/11545:
  [ticket/11545] Remove DIRECTORY_SEPARATOR dependency from is_absolute
 2013-05-16 17:44:20 +02:00
Joas Schilling
38dbfc17a7 [ticket/11545] Remove DIRECTORY_SEPARATOR dependency from is_absolute 
The given path is an absolute path in general, just not on our current system.

PHPBB3-11545
 2013-05-16 17:30:23 +02:00
Marc Alexander
1715619fda [ticket/11538] Add function phpbb_validate_colour for validating colours 
It will be possible to use this function via the validate_data() function
interface that has already been used previously. Thus, this new function
will extend the capabilities of validate_data() to checking hex color
values.

PHPBB3-11538
 2013-05-16 13:22:43 +02:00
Vjacheslav Trushkin
1ea1247cd5 [ticket/10772] Remove unnecessary comment 
PHPBB3-10772
 2013-05-16 09:34:58 +03:00
Vjacheslav Trushkin
56ac97e819 [ticket/10772] Functional tests for forum style 
PHPBB3-10772
 2013-05-16 09:24:16 +03:00
Joas Schilling
14ab0ba594 [ticket/11542] Add lang_english_name to fixture 
PHPBB3-11542
 2013-05-15 15:18:28 +02:00
Victor Nagy
63f11a8024 [ticket/11536] Fixed incorrect removal of "install" in script_path 
Earlier the script would incorrectly remove the word "install"
from the script_path when trying to remove the last folder in the
path named "/install". This would lead to issues when the path
you are installing phpBB contained "install". For example
"/install_test/install" would become "/_test".

This change gets the parent folder instead of replacing all
"install". $name contains /install_test/install/index.php
from start and running dirname() gives /install_test/install.
Running dirname once more gives the parent folder of install,
/install_test.

PHPBB3-11536
 2013-05-15 14:49:46 +02:00
Andreas Fischer
c6de880cdb Merge remote-tracking branch 'nickvergessen/ticket/11541' into develop-olympus 
* nickvergessen/ticket/11541:
  [ticket/11541] Add unit tests for style_select()
 2013-05-15 14:28:16 +02:00
Andreas Fischer
5c23ed57fe Merge remote-tracking branch 'nickvergessen/ticket/11546' into develop-olympus 
* nickvergessen/ticket/11546:
  [ticket/11546] Fix is_absolute() throws E_NOTICE for empty string
 2013-05-15 14:10:40 +02:00
Joas Schilling
06edf15ac3 [ticket/11546] Fix is_absolute() throws E_NOTICE for empty string 
PHPBB3-11546
 2013-05-15 14:05:56 +02:00
Andreas Fischer
f2bc62ba75 Merge remote-tracking branch 'nickvergessen/ticket/11540' into develop-olympus 
* nickvergessen/ticket/11540:
  [ticket/11540] Add unit tests for is_absolute()
 2013-05-15 13:48:21 +02:00
Marc Alexander
204cdb2164 [ticket/11538] Make sure regex doesn't allow multiple color values 
This will now make sure that 'AAFF00' will be matched but strings like
'AAFF00 AABB00' will not.

PHPBB3-11538
 2013-05-15 12:30:05 +02:00
Marc Alexander
ac8e8a156a [ticket/11544] Add admin_login() method to 3.0 functional test case 
This method is needed in order to be able to properly test acp functions.

PHPBB3-11544
 2013-05-14 22:51:10 +02:00
Marc Alexander
cbe4a3c3b6 [ticket/11538] Add tests for acp group manage page 
This will currently test if the colour check properly works.

PHPBB3-11538
 2013-05-14 22:50:17 +02:00
Marc Alexander
deefe5c0e4 [ticket/11538] Simplify colour value check and remove support for '#' 
The input length for the hex color is now limited to 6 characters and
the support for colors starting with a '#' has been dropped. The allowed
input length of 7 in prosilver seems to have been a relict from old ages
of phpBB3. In order to have proper support for correct checking of the
colour value, the new code was also ported to the ACP groups manage page.
The tests have been modified to reflect the changes to the behavior of
the color check. Tests for the ACP will follow.

PHPBB3-11538
 2013-05-14 22:39:33 +02:00
Marc Alexander
1fae7720e4 [ticket/11538] Fix incorrect regex and test for duplicate # in color string 
PHPBB3-11538
 2013-05-14 21:27:25 +02:00
Joas Schilling
6900e8dae0 [ticket/11542] Add unit tests for language_select() 
PHPBB3-11542
 2013-05-14 20:32:36 +02:00
Joas Schilling
25be16748d [ticket/11541] Add unit tests for style_select() 
PHPBB3-11541
 2013-05-14 20:29:38 +02:00
Marc Alexander
a547ba3f9d [ticket/11538] Use regex for testing color value and improve tests 
We are now using a regex with preg_match() in order to properly check
if the entered color value is in hex color format or not. A proper
error message is triggered if an incorrect color value is entered and
the prepended '#' is removed if necessary.

PHPBB3-11538
 2013-05-14 19:44:55 +02:00
Joas Schilling
3f75534258 [ticket/11540] Add unit tests for is_absolute() 
PHPBB3-11540
 2013-05-14 18:27:09 +02:00
Marc Alexander
b7b0b0ccc3 [ticket/11538] Make sure group color can't exceed maximum of 6 characters 
In order to prevent future issues with this, a basic set of functional
tests for the UCP groups manage page have been added.

PHPBB3-11538
 2013-05-14 13:43:53 +02:00
Marc Alexander
84cfacf1f2 [ticket/11537] Adjust error message on ucp group manage to fit rest of ucp 
The current look highly differed from the rest of the UCP. Additionally,
this caused the error message to be hardly noticeable at all.

PHPBB3-11537
 2013-05-14 12:18:40 +02:00
Nils Adermann
45e014d35d Merge pull request #1403 from bantu/ticket/11105 
[ticket/11105] Add mandatory space to content part of meta http-equiv=re...
 2013-05-12 14:05:53 -07:00
gamerchan
d680aac7c5 [ticket/11105] Added spaces between ; and "url=" to adhere to w3c conventions. 
There was no space between ; and the string "url=". But according to w3c, we
should have atleast one space between them. So, added space characters
accordingly.

PHPBB3-11105
 2013-05-12 22:57:40 +02:00
Vjacheslav Trushkin
170333a6fc [ticket/10772] Use forum specific style for trigger_error 
PHPBB3-10772
 2013-05-11 22:49:42 +03:00
Nils Adermann
b347986923 Merge pull request #1396 from bantu/ticket/11324 
[ticket/11324] PHP 5.5 is in RC state. No longer allow failure on travis...
 2013-05-09 11:14:52 -07:00
Andreas Fischer
d1415676c5 [ticket/11324] PHP 5.5 is in RC stage. No longer allow failure on travis. 
PHPBB3-11324
 2013-05-09 20:10:25 +02:00
Andreas Fischer
f9325bfdeb Merge remote-tracking branch 'naderman/ticket/11529' into develop-olympus 
* naderman/ticket/11529:
  [ticket/11529] Format markdown code correctly
  [ticket/11529] Rename RUNNING_TESTS.txt to RUNNING_TESTS.md
 2013-05-09 20:08:20 +02:00
Nils Adermann
ab3b0df244 [ticket/11529] Format markdown code correctly 
PHPBB3-11529
 2013-05-09 20:06:12 +02:00
Nils Adermann
1c9d36615a [ticket/11529] Rename RUNNING_TESTS.txt to RUNNING_TESTS.md 
PHPBB3-11529
 2013-05-09 19:59:34 +02:00