Commit graph

7143 commits

Author SHA1 Message Date
Oleg Pudeyev
21caf6db6f Merge PR #545 branch 'brunoais/ticket/10601' into develop
* brunoais/ticket/10601:
  [ticket/10601] The ORDER BY is only taking space there
  [ticket/10601] New approach in the update algorithm
  [ticket/10601] Comment to help understanding the code
  [ticket/10601] Requested code changes
  [ticket/10601] Cosmetic code changes
  [ticket/10601] Database updating code v2
  [ticket/10601] Database updating code
  [ticket/10601] Comment explaning the basename applied to categories
  [ticket/10601] Correctly access class property
  [ticket/10601]Move Inbox the default in private messages module
2012-12-01 15:09:38 -05:00
Oleg Pudeyev
c852044d6e [ticket/9983] Add redis cache driver tests.
In order to not overwrite data in default redis store, at least
one of redis host or post must be explicitly specified.

Redis cache driver constructor has been modified to accept
host and port as parameters. This was not added to public API
as there are more parameters being passed via global constants.

PHPBB3-9983
2012-12-01 00:48:21 -05:00
Oleg Pudeyev
ec4343c744 [ticket/11227] @return void -> @return null, per coding guidelines.
PHPBB3-11227
2012-11-30 23:03:06 -05:00
Oleg Pudeyev
3a702084e4 Merge PR #974 branch 'bantu/ticket/10875' into develop
* bantu/ticket/10875:
  [ticket/10875] tests/cache/cache_test.php: Use single quotes where possible.
  [ticket/10875] Test for null cache driver and sql cache.
  [ticket/10875] Revise sql cache test.
  [ticket/10875] Must return query result on failure.
  [ticket/10875] More documentation.
  [ticket/10875] Spelling fix.
  [ticket/10875] Add docblocks for phpbb_cache_driver_interface
  [ticket/10875] Add comment about cache's sql_load() method.
  [ticket/10875] Fix logic in phpbb_cache_driver_file::sql_save().
  [ticket/10875] Fix phpbb_mock_cache::sql_save() to return $query_result.
  [ticket/10875] Fix return value of phpbb_cache_driver_null::sql_save().
  [ticket/10875] Remove useless assignment from phpbb_cache_driver_memory.
2012-11-30 20:44:51 -05:00
Marc Alexander
d439f47710 [feature/avatars] Fix docblocks and minor cosmetic issues
PHPBB3-10018
2012-12-01 00:27:52 +01:00
Marc Alexander
081440f6c4 [feature/avatars] Create setting for enabling avatar in manager
PHPBB3-10018
2012-11-30 23:11:44 +01:00
Oleg Pudeyev
1ebc6eb68b [ticket/10875] Must return query result on failure.
PHPBB3-10875
2012-11-30 12:11:52 -05:00
Oleg Pudeyev
3eb15ab59e [ticket/10875] More documentation.
PHPBB3-10875
2012-11-30 12:04:05 -05:00
Oleg Pudeyev
ee16ed7b76 [ticket/10875] Spelling fix.
PHPBB3-10875
2012-11-30 11:55:13 -05:00
Marc Alexander
33b98dc5ba [feature/avatars] Fix variable names
PHPBB3-10018
2012-11-30 16:46:11 +01:00
Marc Alexander
d5cbedaaa2 [feature/avatars] Let avatar manager handle $ignore_config
The avatar manager already handles if avatars are enabled. It should also
handle ignoring the config settings.

PHPBB3-10018
2012-11-30 15:12:34 +01:00
Marc Alexander
f4ad60e2cf [feature/avatars] Get list of enabled drivers from avatar manager
This shouldn't be done in the avatar drivers. We need to force the
display all avatar drivers in the ACP or it won't be possible to enable
avatars after they have been disabled.

PHPBB3-10018
2012-11-30 01:07:10 +01:00
Andreas Fischer
5d78346453 Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/11227] @return void -> @return null in develop-olympus.
2012-11-29 23:17:58 +01:00
Marc Alexander
81a1a21185 [feature/avatars] Properly implement custom HTML in the interface
Previously the driver class added a variable that defined wether an avatar
driver would return custom HTML. The existence of this variable was
implied in the interface. It's also not needed which is why it has been
removed.

PHPBB3-10018
2012-11-29 23:08:29 +01:00
Oleg Pudeyev
65253a3023 [ticket/11227] @return void -> @return null in develop-olympus.
PHPBB3-11227
2012-11-29 15:37:12 -05:00
Oleg Pudeyev
11ca272692 [ticket/11095] Restore brace on previous line.
PHPBB3-11095
2012-11-29 14:42:56 -05:00
Oleg Pudeyev
3e907265d5 [ticket/11095] Docs and tests for phpbb_build_hidden_fields_for_query_params.
PHPBB3-11095
2012-11-29 14:42:06 -05:00
Oleg Pudeyev
2a39df1a53 [ticket/11095] Forward GET parameters into hidden fields for jumpbox.
PHPBB3-11095
2012-11-29 13:36:00 -05:00
Oleg Pudeyev
9c0a03f1d5 [ticket/11095] Python quoteattr port.
PHPBB3-11095
2012-11-29 12:05:52 -05:00
Bruno Ais
1d98915881 [ticket/10601] Comment to help understanding the code
PHPBB3-10601
2012-11-28 19:37:16 +00:00
Dhruv
c725b02df8 [ticket/11174] include utf_tools in postgres search backend
PHPBB3-11174
2012-11-27 08:49:06 -05:00
Dhruv
6e8f142d39 [ticket/11174] removes unnecessary space from word
PHPBB3-11174
2012-11-27 08:48:15 -05:00
Dhruv
764da97772 [ticket/11174] include utf_tools in mysql backend
when running tests include utf_tools file in the mysql search backend

PHPBB3-11174
2012-11-27 08:48:06 -05:00
Marc Alexander
cb1d98ab7f [feature/avatars] Check for existing functions rather than using _once
PHPBB3-10018
2012-11-26 23:06:38 +01:00
Bruno Ais
24939c8225 [ticket/10601]Move Inbox the default in private messages module
Did exactly as the answer here asked:
http://area51.phpbb.com/phpBB/viewtopic.php?p=234111

PHPBB3-10601
2012-11-26 17:44:41 +00:00
Marc Alexander
f851d763f9 [feature/avatars] Even more fixes to docblocks
PHPBB3-10018
2012-11-25 21:14:05 +01:00
Marc Alexander
6522190ff1 [feature/avatars] Docblock fixes and small change for php_ext
PHPBB3-10018
2012-11-25 20:50:31 +01:00
Marc Alexander
a77fcdb5f9 [feature/avatars] Implement better treatment of avatar errors
PHPBB3-10018
2012-11-25 17:01:21 +01:00
Marc Alexander
f8256ed00f [feature/avatars] Small cosmetic changes
PHPBB3-10018
2012-11-25 16:18:51 +01:00
Marc Alexander
06639729ea [feature/avatars] Add static methods for handling driver names
PHPBB3-10018
2012-11-25 16:05:57 +01:00
Marc Alexander
6d061304af [feature/avatars] Small fixes
PHPBB3-10018
2012-11-25 15:03:35 +01:00
Marc Alexander
67c2e48d15 [feature/avatars] Only create avatar objects if necessary
PHPBB3-10018
2012-11-25 14:33:13 +01:00
Marc Alexander
ce5e2f1677 [feature/avatars] Miscellaneous fixes
PHPBB3-10018
2012-11-25 01:18:27 +01:00
Marc Alexander
ce44e3908e [feature/avatars] Remove unnecessary abbreviations
PHPBB3-10018
2012-11-25 00:54:34 +01:00
Marc Alexander
211abe2ac9 [feature/avatars] Remove obsolete functions from functions_user.php
The removed functions are no longer needed due to the new avatar system.

PHPBB3-10018
2012-11-22 00:39:02 +01:00
Marc Alexander
5289dc52a3 [feature/avatars] Add support for modularized avatars to ucp groups
This seems to be the last component where the new avatars system was still
missing.

PHPBB3-10018
2012-11-22 00:00:45 +01:00
Nathan Guse
c911a34b5b [ticket/11103] Do not prepend notification.(type|method) unless necessary
PHPBB3-11103
2012-11-21 16:04:01 -06:00
Marc Alexander
8a01bc1718 [feature/avatars] Use RecursiveDirectoryIterator for gallery avatar
RecursiveDirectoryIterator is now used for populating the avatar list
array of the gallery avatar.

PHPBB3-10018
2012-11-21 21:42:42 +01:00
Marc Alexander
24ac039336 [feature/avatars] Get rid of array_keys() in gallery avatar
PHPBB3-10018
2012-11-21 20:01:50 +01:00
Marc Alexander
01b313ea26 [feature/avatars] Use isset() instead of in_array()
PHPBB3-10018
2012-11-21 19:20:39 +01:00
Marc Alexander
8c782122c1 [feature/avatars] Use in_array() and fix tabbing
PHPBB3-10018
2012-11-21 17:24:02 +01:00
Marc Alexander
726d1a16d7 [feature/avatars] Move avatar specific settings to drivers
PHPBB3-10018
2012-11-21 17:15:35 +01:00
Marc Alexander
9b61204a17 [feature/avatars] Check if gravatar is within min/max width/height
PHPBB3-10018
2012-11-21 16:27:20 +01:00
Marc Alexander
b7b14f9a05 [feature/avatars] Use constant for URL and fix usage of getimagesize
We now use a constant for the gravatar URL. Additionally the usage of
getimagesize() was reduced. It should only be run if the user didn't
specify both the width and height of the avatar.

PHPBB3-10018
2012-11-21 16:20:14 +01:00
Nathan Guse
61aa53f91a Merge branch 'develop' of git://github.com/phpbb/phpbb3 into ticket/11103
Conflicts:
	phpBB/config/services.yml
	phpBB/index.php
2012-11-20 23:19:51 -06:00
Nathan Guse
570c5ad3c0 [ticket/11103] Some comments
PHPBB3-11103
2012-11-20 23:12:37 -06:00
Nathan Guse
2afb8b9df8 [ticket/11103] Create user loader class, update for DIC
Create a very basic user loader class to handle querying/storing
user data in a centralized location.

Use DIC collection service for notification types/methods.

Cleanup unused dependencies.

Fix some other issues.

PHPBB3-11103
2012-11-20 22:54:16 -06:00
Marc Alexander
858c59279c [feature/avatars] Use protected instead of private
PHPBB3-10018
2012-11-19 23:50:34 +01:00
Igor Wiedler
b453f359ff Merge remote-tracking branch 'imkingdavid/feature/controller-new' into develop
* imkingdavid/feature/controller-new: (67 commits)
  [feature/controller] Fix misnamed route for functional test
  [feature/controller] Fix comments, check against more general HttpException
  [feature/controller] Check for proper status codes from controllers
  [feature/controller] Correctly create Symfony object from globals
  [feature/controller] Add documentation about input being HTML-escaped
  [feature/controller] Create Symfony Request in new function
  [feature/controller] Remove unused language strings
  [feature/controller] Don't use $user->lang() before container compilation
  [feature/controller] Update routing documentation for using query string
  [feature/controller] Remove now-unused code
  [feature/controller] Remove url rewriting until we use pathinfo in controllers
  [feature/controller] Fix functional tests to use query string for controllers
  [feature/controller] Allow injecting Symfony Request into controllers
  [feature/controller] Use query string, not path info, for controller access
  [feature/controller] Fix line endings and permissions, and check responses
  [feature/controller] Remove URL rewriting by default
  [feature/controller] Add controller functional test with template
  [feature/controller] Use warning instead of echo for copy() and unlink()
  [feature/controller] Flip method parameters, require $message
  [feature/controller] Rename $root_path class property to $phpbb_root_path
  ...
2012-11-19 22:28:12 +01:00
David King
01ec608593 [feature/controller] Fix comments, check against more general HttpException
PHPBB3-10864
2012-11-19 12:55:15 -05:00