Commit graph

7143 commits

Author SHA1 Message Date
Igor Wiedler
b8cf74217a [ticket/11212] Cosmetic surgery done right
PHPBB3-11212
2012-11-17 05:29:49 +01:00
Igor Wiedler
1affc35be9 [ticket/11212] Cosmetics
PHPBB3-11212
2012-11-17 05:29:49 +01:00
Igor Wiedler
b534a7a579 [ticket/11212] Rename get_http_version to phpbb_request_http_version()
PHPBB3-11212
2012-11-17 05:29:49 +01:00
Igor Wiedler
0372ecf141 [ticket/11015] Make phpbb_convert_30_dbms_to_31 more future proof
It should allow any class name in the future, as long as that class
exists. And it should give a useful error message otherwise.

PHPBB3-11015
2012-11-17 01:40:35 +01:00
Igor Wiedler
9cdef7984f [ticket/11212] Allow dispatcher to be absent during garbage_collection()
PHPBB3-11212
2012-11-17 01:17:23 +01:00
Igor Wiedler
5fad4006e1 [ticket/11212] Do not rely on $request in send_status_line()
PHPBB3-11212
2012-11-17 01:15:50 +01:00
Marc Alexander
c70cbfac43 [feature/avatars] Fix acp front-end of user and group avatars
Due to the changes to the avatar manager etc. these had to be updated.

PHPBB3-10018
2012-11-17 00:50:23 +01:00
Igor Wiedler
5bc0f4b3d4 [ticket/11015] Move db driver class name fixing to function
PHPBB3-11015
2012-11-17 00:24:32 +01:00
David King
1952a4f276 [feature/controller] Flip method parameters, require $message
PHPBB3-10864
2012-11-16 17:06:00 -05:00
David King
d41b1146e8 [feature/controller] Rename $root_path class property to $phpbb_root_path
PHPBB3-10864
2012-11-16 17:05:59 -05:00
David King
c2f352ab35 [feature/controller] Fix param block for controller callable
PHPBB3-10864
2012-11-16 17:05:58 -05:00
David King
120267e580 [feature/controller] Correctly access user object
PHPBB3-10864
2012-11-16 17:05:55 -05:00
David King
74bc460493 [feature/controller] Rename improperly named controller exception class
PHPBB3-10864
2012-11-16 17:05:55 -05:00
David King
45b3ab8e81 [feature/controller] Move Response definition into a variable
PHPBB3-10864
2012-11-16 17:05:51 -05:00
David King
14f44c17ad [feature/controller] phpbb_controller_exception instead of RuntimeException
PHPBB3-10864
2012-11-16 17:05:49 -05:00
David King
8e480a8725 [feature/controller] Move include to app.php
PHPBB3-10864
2012-11-16 17:05:46 -05:00
David King
db1d49d559 [feature/controller] Rename get_paths to import_paths_from_finder
Also removed unused variable from url_matcher function

PHPBB3-10864
2012-11-16 17:05:46 -05:00
David King
b4eff4f06a [feature/controller] Remove URL Base from helper class
I had forgotten that the container sends the same instance of objects to all
services that request it, so in this case all controllers would share the same
base url path, which is not desired.

PHPBB3-10864
2012-11-16 17:05:45 -05:00
David King
aead33432a [feature/controller] Remove dumped container when cache is purged
PHPBB3-10864
2012-11-16 17:05:44 -05:00
David King
c54c3ee422 [feature/controller] A few minor nitpickings
PHPBB3-10864
2012-11-16 17:05:44 -05:00
David King
fa43edd877 [feature/controller] Further separate url matcher functionality
PHPBB3-10864
2012-11-16 17:05:43 -05:00
David King
4cb9ec522c [feature/controller] Separate Kernel listeners into their own classes
PHPBB3-10864
2012-11-16 17:05:42 -05:00
David King
196c2d4bc3 [feature/controller] Move new functions to their own file
PHPBB3-10864
2012-11-16 17:05:41 -05:00
David King
d3aa8823b2 [feature/controller] Use a dumped url matcher class to improve performance
PHPBB3-10864
2012-11-16 17:05:40 -05:00
Marc Alexander
ac7c3d2b8d [feature/avatars] Check for gravatar when checking the avatar module_auth
PHPBB3-10018
2012-11-16 23:04:09 +01:00
Marc Alexander
ca30135391 [feature/avatars] Add gravatar to avatar settings
PHPBB3-10018
2012-11-16 22:59:29 +01:00
David King
c6a5699325 [feature/controller-new] Fix line endings
PHPBB3-10864
2012-11-16 16:47:31 -05:00
David King
2e59450459 [feature/controller] Use assign_display() instead of return_display()
The latter was deemed unnecessary at the moment.

PHPBB3-10864
2012-11-16 16:47:30 -05:00
David King
6900456e90 [feature/controller] Revert changes to template class
As per IRC, assign_display() effectively does what return_display() was added
to do, so no change was needed.

PHPBB3-10864
2012-11-16 16:47:29 -05:00
David King
ef46af8298 [feature/controller] Don't attempt to assign if no variable is give
PHPBB3-10864
2012-11-16 16:47:29 -05:00
David King
b5255d4ea4 [feature/controller] Fix syntax error in template code
PHPBB3-10864
2012-11-16 16:47:28 -05:00
David King
ac29c7e9d9 [feature/controller] Rework assign_display(), use exceptions instead of return
PHPBB3-10864
2012-11-16 16:47:22 -05:00
David King
4b6d538b06 [feature/controller] Rename kernel pass class properly
PHPBB3-10864
2012-11-16 16:45:29 -05:00
David King
7687f06961 [feature/controller] Inject dependencies instead of container
PHPBB3-10864
2012-11-16 16:45:28 -05:00
David King
4e1f17a87d [feature/controller] includes/functions.php is included by default
PHPBB3-10864
2012-11-16 16:25:15 -05:00
David King
97957d6792 [feature/controller-new] Rename kernel compiler pass class
PHPBB3-10864
2012-11-16 16:25:14 -05:00
David King
5c86a1660d [feature/controller] Don't allow a kernel listener to be added with no method
PHPBB3-10864
2012-11-16 16:25:12 -05:00
David King
067a770730 [feature/controller] Transfer kernel-related stuff from container PR
PHPBB3-10864
2012-11-16 16:25:10 -05:00
David King
06158693c7 [feature/controller] Implement a front controller
PHPBB3-10864
2012-11-16 16:25:09 -05:00
David King
ca09eb94e3 [ticket/11211] Fix typo in phpbb_realpath() method name
PHPBB3-11211
2012-11-16 14:38:53 -05:00
Marc Alexander
517d3f56ac [feature/avatars] Use correct names of input fields
The name of the avatar input fields seem to have been copied from the local
avatar (gallery avatar). Since the input fields have different names in
the template files of the remote and gravatar avatars this will not
properly default to the entered values.
Additionally, the focused driver wasn't correctly filtered causing use to
always default to no avatar.

PHPBB3-10018
2012-11-16 17:39:32 +01:00
Marc Alexander
0a5d54cc9b [feature/avatars] Shorten avatar driver's class name
The addition of "core_" that was used until now would require additional
avatar drivers (e.g. in extensions) to also include that in their class
name which would be incorrect.

PHPBB3-10018
2012-11-16 17:19:04 +01:00
Oleg Pudeyev
1a2dfa6d4c Merge PR #1074 branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/11192] Merge dataProvider arrays because the test is the same now.
  [ticket/11192] Update $value parameter description to support other types.
  [ticket/11192] Mark negative byte numbers as unsupported.
  [ticket/11192] Test strings not converted to int/float before.
  [ticket/11192] Also test strings, e.g. sums returned by the database.
  [ticket/11192] Also test powers of 10 / 1000.
  [ticket/11192] Add tests.
  [ticket/11192] Add Tebibyte to get_formatted_filesize().
2012-11-16 10:29:22 -05:00
Andreas Fischer
efd6f1df63 [ticket/11192] Update $value parameter description to support other types.
PHPBB3-11192
2012-11-16 14:56:15 +01:00
Andreas Fischer
7cbd440e7a [ticket/11192] Mark negative byte numbers as unsupported.
PHPBB3-11192
2012-11-16 14:56:15 +01:00
Marc Alexander
cc86bd9267 [feature/avatars] Shorten needed language variable for avatar title
PHPBB3-10018
2012-11-16 14:29:35 +01:00
Joas Schilling
98092add9e [ticket/10411] Move globals to the top and use array for cache destroy
PHPBB3-10411
2012-11-16 11:48:41 +01:00
Igor Wiedler
fc5385c2a5 [ticket/11015] Allow full dbms class name in config.php
PHPBB3-11015
2012-11-16 01:48:03 +01:00
Igor Wiedler
0d4a289778 [ticket/11015] Remove strange method_exists call
PHPBB3-11015
2012-11-16 01:26:36 +01:00
Igor Wiedler
423c79e106 Merge remote-tracking branch 'upstream/develop' into ticket/11015
* upstream/develop: (22 commits)
  [ticket/11206] Remove includes to non-existent files from download/file.php
  [ticket/11205] Fix merge conflict in readme.html.
  [ticket/11202] Check response success before content assertions.
  [ticket/11204] Reindent.
  [ticket/11198] Remove additional asterix as /** is doc-block only
  [ticket/11200] Add a reminder comment.
  [ticket/11202] Custom message does not make sense here, delete it.
  [ticket/11202] Check response success before content assertions.
  [ticket/11202] Add a heuristic function to check for response success.
  [ticket/11200] Make cache available during container construction
  [ticket/11199] Match cache purge container files against container_*
  [ticket/11199] Purge dumped container correctly on cache purge.
  [ticket/11199] Revert merge of 'marc1706/ticket/11199' into develop
  [ticket/11199] Cache purge does not remove dumped container
  [ticket/11198] Store the swapping partners in vars and simplify the logic
  [ticket/11198] Correctly set links after an item is moved up/down with AJAX
  [ticket/11197] Prefix the css classes for the small arrow with "arrow"
  [ticket/10879] Remove arrow icon from attachment link in editor
  [ticket/11195] Condense logic, remove improperly formatted if()
  [ticket/11190-develop] Functional tests purge cache before running.
  ...

Conflicts:
	tests/test_framework/phpbb_database_test_connection_manager.php
2012-11-16 01:23:24 +01:00