Commit graph

20157 commits

Author SHA1 Message Date
Joas Schilling
d2572888f9 [ticket/12286] Reword section about plurals
PHPBB3-12286
2014-03-28 17:24:59 +01:00
Joas Schilling
c985b018a7 [ticket/12286] Fix spelling of elephant(s) in the sample
PHPBB3-12286
2014-03-28 17:19:03 +01:00
Joas Schilling
99dccc2df8 [ticket/12286] Correctly capitalize PHP
PHPBB3-12286
2014-03-28 17:16:56 +01:00
Joas Schilling
f88e9d1c04 [ticket/12286] Fix nesting of ul inside li element
PHPBB3-12286
2014-03-28 17:14:09 +01:00
Joas Schilling
d7c2c9d472 [ticket/12286] Add note that goto should not be used
PHPBB3-12286
2014-03-21 17:04:58 +01:00
Joas Schilling
6750e19214 [ticket/12286] Add section about plurals to the coding guidelines
PHPBB3-12286
2014-03-18 10:14:11 +01:00
Joas Schilling
244d783865 [ticket/12286] Classes must use the name space
PHPBB3-12286
2014-03-18 09:54:14 +01:00
Joas Schilling
218e04a1e4 [ticket/12286] Remove section about utf8_normalize_nfc()
The request class takes care of this

PHPBB3-12286
2014-03-18 09:36:40 +01:00
Joas Schilling
c68f7671d2 [ticket/12286] Use $request->variable() instead of request_var()
PHPBB3-12286
2014-03-18 09:36:02 +01:00
Joas Schilling
d275a7cf63 [ticket/12286] Function names should be prefixed with phpbb_
PHPBB3-12286
2014-03-18 09:26:59 +01:00
Joas Schilling
30eccacb1d [ticket/12286] Add "Since" to template event docs
PHPBB3-12286
2014-03-18 09:21:30 +01:00
Joas Schilling
45857fe5c9 [ticket/12286] style.php and imagesets dont exist anymore
PHPBB3-12286
2014-03-18 09:18:41 +01:00
Joas Schilling
ac5a808ff3 [ticket/12286] Styles have a phpbb_version and a style_version in 3.1
PHPBB3-12286
2014-03-18 09:17:45 +01:00
Joas Schilling
37eea9fa41 [ticket/12286] Use UTF8 (c) in style.cfg samples
PHPBB3-12286
2014-03-18 09:10:01 +01:00
Joas Schilling
96e5a04001 Merge remote-tracking branch 'rxu3/ticket/12278' into develop
* rxu3/ticket/12278:
  [ticket/12278] Add mcp.php core event to allow to modify modules display option
2014-03-18 00:25:57 +01:00
Andreas Fischer
c09d3f924b Merge remote-tracking branch 'VSEphpbb/ticket/12284' into develop
* VSEphpbb/ticket/12284:
  [ticket/12284] Fix functional test for extension manager changes
2014-03-17 23:10:35 +01:00
Matt Friedman
9d2381cf3d [ticket/12284] Fix functional test for extension manager changes
PHPBB3-12284
2014-03-17 13:23:42 -07:00
Andreas Fischer
4635c5917c Merge remote-tracking branch 'VSEphpbb/ticket/12284' into develop
* VSEphpbb/ticket/12284:
  [ticket/12284] Improve readability of extension manager details
2014-03-17 20:30:57 +01:00
Matt Friedman
e46e3111e2 [ticket/12284] Improve readability of extension manager details
Use span tags like the rest of the ACP does, instead of P tags.
There is no semantic need to use P tags here. These are not
paragraphs.

PHPBB3-12284
2014-03-17 12:10:18 -07:00
rxu
378cfd6e16 [ticket/12278] Add mcp.php core event to allow to modify modules display option
This event allows extensions to set display option for custom MCP modules
for extensions which add custom MCP modules
and some of them should be displayed conditionally.

PHPBB3-12278
2014-03-17 23:28:51 +08:00
Joas Schilling
772dd0def6 Merge remote-tracking branch 'rxu3/ticket/12279' into develop
* rxu3/ticket/12279:
  [ticket/12279] Add memberlist_view.html template event to add custom info
2014-03-17 15:58:33 +01:00
Joas Schilling
6fba2c6778 Merge remote-tracking branch 'vsephpbb/ticket/7580' into develop
* vsephpbb/ticket/7580:
  [ticket/7580] Add test for IF {VAR} is defined in templates
2014-03-17 15:55:51 +01:00
rxu
1e1a54882c [ticket/12279] Add memberlist_view.html template event to add custom info
Template event to ddd custom content
to the user profile view after the main content.

PHPBB3-12279
2014-03-17 21:01:16 +08:00
Joas Schilling
ee754dfab1 Merge remote-tracking branch 'dragooon/ticket/9040' into develop
* dragooon/ticket/9040:
  [ticket/9040] Minor cleanup in the unit test file
  [ticket/9040] Count HTML entities as single in custom profile fields
2014-03-17 13:33:23 +01:00
Shitiz Garg
8a48f6e267 [ticket/9040] Minor cleanup in the unit test file
PHPBB3-9040
2014-03-17 17:35:37 +05:30
Shitiz Garg
403ab49716 [ticket/9040] Count HTML entities as single in custom profile fields
Currently when an user adds a HTML entity to a custom profile field, the length
gets incremented by 4 since the code reads &gt; instead of <. However, the
length is presentational and not DB storage so it should be treated as a
single character even if it takes four lengths in the DB by being stored as
a HTML entity.

Work around this by decoding html entities before counting. Also, added unit
tests for string field type

PHPBB3-9040
2014-03-17 17:35:30 +05:30
Joas Schilling
ec25eba444 Merge branch 'ticket/12269' of github.com:netdeamon/phpbb into develop
# By netdeamon
# Via netdeamon
* 'ticket/12269' of github.com:netdeamon/phpbb:
  [ticket/12269] Delete folder mods in language
2014-03-17 10:18:37 +01:00
netdeamon
85147eb987 [ticket/12269] Delete folder mods in language
Deleted mods folder in phpbb/language/en/.

PHPBB3-12269
2014-03-17 14:26:08 +05:30
Matt Friedman
d8c1c7fb9a [ticket/7580] Add test for IF {VAR} is defined in templates
http://tracker.phpbb.com/browse/PHPBB3-7580
This test demonstrates that is possible to test if a
variable exists and then use it if it does, similar to
using isset(), but in template/twig syntax.
<!— IF {VAR} is defined —>{VAR}<!— ENDIF —>

PHPBB3-7580
2014-03-16 20:38:50 -07:00
Joas Schilling
f9438bcbf7 Merge branch 'ticket/11239' of github.com:geetakshi/phpbb into develop
# By geetakshi
# Via geetakshi
* 'ticket/11239' of github.com:geetakshi/phpbb:
  [ticket/11239] Removing hard-coded, language specific possessive
  [ticket/11239] Including username before Overview title
2014-03-16 23:30:54 +01:00
Joas Schilling
cdbc1e8a5c Merge remote-tracking branch 'vsephpbb/ticket/12274' into develop
* vsephpbb/ticket/12274:
  [ticket/12274] Add core.js to the install footer
  [ticket/12274] Fix broke/missing jQuery asset paths in update script
  [ticket/12274] Load correct T_TEMPLATE_PATH during update
2014-03-16 23:05:24 +01:00
Nathan Guse
5f70518987 Merge pull request #2136 from Elsensee/ticket/11071
[ticket/11071] Add fallback if requested style don't exist
2014-03-16 14:09:46 -05:00
Nathan Guse
69c195687f Merge pull request #2144 from nickvergessen/travis/disable-redis
[travis/disable-redis] Disable redis on travis until its fixed again
2014-03-16 11:06:26 -05:00
Joas Schilling
ada37226bf [ticket/12281] Disable redis on travis until its fixed again
/home/travis/build/phpbb/phpbb/redis/redis.c:6141:34:
error: unknown type name ‘tsrm_ls’
make: *** [redis.lo] Error 1

The command "sh -c "if [ '$TRAVIS_PHP_VERSION' != 'hhvm' ];
then travis/setup-php-extensions.sh; fi"" failed
and exited with 2 during install.

PHPBB3-12281
2014-03-16 16:36:58 +01:00
Matt Friedman
a29ad78da6 [ticket/12274] Add core.js to the install footer
Required so phpbb var is defined, as it is used in admin.js.

PHPBB3-12274
2014-03-16 07:56:26 -07:00
Matt Friedman
81ceefd889 [ticket/12274] Fix broke/missing jQuery asset paths in update script
PHPBB3-12274
2014-03-16 07:22:24 -07:00
geetakshi
4d191f254d [ticket/11239] Removing hard-coded, language specific possessive
PHPBB3-11239
2014-03-16 15:36:47 +05:30
Matt Friedman
fd6836ca8a [ticket/12274] Load correct T_TEMPLATE_PATH during update
PHPBB3-12274
2014-03-15 20:44:56 -07:00
Oliver Schramm
df0ac9876c [ticket/11071] Add fallback if requested style don't exist
PHPBB3-11071
2014-03-15 22:00:48 +01:00
geetakshi
7647b51d5d [ticket/11239] Including username before Overview title
Adding username to the page title to avoid confusion while managing
multiple users in ACP

PHPBB3-11239
2014-03-16 02:12:50 +05:30
Joas Schilling
325931a56b Merge branch 'prep-release-3.1.0-b1' into develop
* prep-release-3.1.0-b1:
  [prep-release-3.1.0-b1] Update build version to 3.1.0-b2-dev
  [prep-release-3.1.0-b1] Add changelog for 3.1.0-b1
  [prep-release-3.1.0-b1] Prepare Changelog
  [prep-release-3.1.0-b1] Add migration for 3.1.0-b1
  [prep-release-3.1.0-b1] Update version to 3.1.0-b1
2014-03-15 17:32:48 +01:00
Joas Schilling
9be5405e5b [prep-release-3.1.0-b1] Update build version to 3.1.0-b2-dev 2014-03-15 17:32:07 +01:00
Joas Schilling
873b5686a1 [prep-release-3.1.0-b1] Add changelog for 3.1.0-b1 2014-03-15 16:05:12 +01:00
Joas Schilling
f9c27ccd52 [prep-release-3.1.0-b1] Prepare Changelog 2014-03-15 15:37:22 +01:00
Joas Schilling
6159c3c738 [prep-release-3.1.0-b1] Add migration for 3.1.0-b1 2014-03-15 15:37:22 +01:00
Joas Schilling
407e0dbd8b [prep-release-3.1.0-b1] Update version to 3.1.0-b1 2014-03-15 15:37:21 +01:00
Andreas Fischer
aee4534d71 Merge pull request #2111 from nickvergessen/ticket/12262
[ticket/12262] Fix event exporter

* nickvergessen/ticket/12262:
  [ticket/12262] Do not use inline assignments
  [ticket/12262] Do not use getExtension()
  [ticket/12262] Fix location list for acp events with "Locations:"
  [ticket/12262] Also find vars array when it's defined in the trigger_event()
2014-03-15 15:34:55 +01:00
Joas Schilling
2d987d36c1 Merge remote-tracking branch 'maelsoucaze/develop' into develop
* maelsoucaze/develop:
  [ticket/12272] Fix hardcoded colons in subforums.
  [ticket/12272] Fix hardcoded colons in subforums.
2014-03-15 15:17:55 +01:00
Joas Schilling
87292f534e [ticket/12262] Do not use inline assignments
PHPBB3-12262
2014-03-15 15:14:00 +01:00
Joas Schilling
2071abda1f [ticket/12262] Do not use getExtension()
The method is php 5.3.6+ only.

PHPBB3-12262
2014-03-15 15:13:59 +01:00