Commit graph

15304 commits

Author SHA1 Message Date
Joas Schilling
d5d282005c [ticket/10714] Add getter for is_in_admin and use it
PHPBB3-10714
2013-01-22 16:47:05 +01:00
Joas Schilling
c2504e9300 [ticket/10714] Fix more comments
PHPBB3-10714
2013-01-22 15:56:34 +01:00
Joas Schilling
ffde887aad [ticket/10714] Cast values to integer before using them in the query
PHPBB3-10714
2013-01-22 15:46:48 +01:00
Joas Schilling
c0ab3f3ddd [ticket/10714] Fix several doc blocks and comments
PHPBB3-10714
2013-01-22 15:45:20 +01:00
Joas Schilling
2c4e7eabe2 [ticket/10714] Fix missing 8th argument in unit tests
PHPBB3-10714
2013-01-22 15:10:35 +01:00
Joas Schilling
786e2438d5 [ticket/10714] Use new core.adm_relative_path to create the object.
PHPBB3-10714
2013-01-16 16:23:41 +01:00
Joas Schilling
19b6ea8cf7 Merge branch 'develop' of https://github.com/phpbb/phpbb3 into ticket/10714
* 'develop' of https://github.com/phpbb/phpbb3: (205 commits)
  [ticket/10786] Javascript toggle member search panel in memberlist.php
  [ticket/10786] Javascript toggle member search panel in memberlist.php
  [ticket/10786] Javascript toggle member search panel in memberlist.php
  [ticket/11201] Remove database column on update
  [ticket/10431] Remove .left class from reply-all
  [ticket/10431] Remove reply-all custom css
  [ticket/10431] Adjustments for large buttons
  [ticket/11323] Add tests for inclusion of defined variables
  [ticket/11324] Add PHP 5.5 environment to travis and allow it to fail.
  [ticket/11201] Remove MSN/WLM fields
  [ticket/11321] Recreate schema files with develop/create_schema_files.php
  [ticket/11320] Include functions file as we need phpbb_convert_30_dbms_to_31
  [ticket/11313] Use correct object el instead of eel in alt_text callback
  [ticket/11301] Guidelines: Add spaces in front and after the / operator.
  [ticket/11301] Explicitly cast str offset to int to prevent E_NOTICE on 5.4.
  [ticket/11311] Include asset core.js in subsilver2 overall_footer.html
  [ticket/10949] Remove not needed comma
  [ticket/11309] phpbb_extension_interface::disable_step correct docblock.
  [ticket/10949] Converted missing code to new JS coding guidelines
  [ticket/11302] Correctly select first timezone or selected timezone
  ...
2013-01-16 16:15:31 +01:00
Joas Schilling
37014abd02 [ticket/10714] Fix several comments and variable names
PHPBB3-10714
2013-01-16 14:18:09 +01:00
Nathan Guse
f63e115ae9 Merge remote-tracking branch 'remotes/DavidIQ/ticket/10786' into develop
# By David Colón
* remotes/DavidIQ/ticket/10786:
  [ticket/10786] Javascript toggle member search panel in memberlist.php
  [ticket/10786] Javascript toggle member search panel in memberlist.php
  [ticket/10786] Javascript toggle member search panel in memberlist.php
2013-01-16 00:13:01 -06:00
David Colón
4306a7641f [ticket/10786] Javascript toggle member search panel in memberlist.php
Search functions on the memberlist.php page are now rendered by default and displayed via javascript.  If javascript is disabled the page still works as it previously did.

PHPBB3-10786
2013-01-15 23:29:06 -06:00
David Colón
babe07caef [ticket/10786] Javascript toggle member search panel in memberlist.php
Search functions on the memberlist.php page are now rendered by default and displayed via javascript.  If javascript is disabled the page still works as it previously did.

PHPBB3-10786
2013-01-15 23:29:01 -06:00
David Colón
de541ac13b [ticket/10786] Javascript toggle member search panel in memberlist.php
PHPBB3-10786
2013-01-15 23:28:45 -06:00
Nathan Guse
28e0520fe4 Merge remote-tracking branch 'remotes/Sajaki/ticket/10854' into develop
# By Sajaki
# Via Sajaki
* remotes/Sajaki/ticket/10854:
  [ticket/10854] sql server drop default constraint when dropping column
2013-01-15 22:22:06 -06:00
Nathan Guse
6b895e0a02 Merge remote-tracking branch 'remotes/cyberalien/ticket/10431' into develop
# By Vjacheslav Trushkin
# Via Vjacheslav Trushkin
* remotes/cyberalien/ticket/10431:
  [ticket/10431] Remove .left class from reply-all
  [ticket/10431] Remove reply-all custom css
  [ticket/10431] Adjustments for large buttons
  [ticket/10431] Changed fonts for Linux
  [ticket/10431] Adjustments for IE7
  [ticket/10431] Different font for iOS
  [ticket/10431] CSS3 buttons
2013-01-15 19:02:04 -06:00
Nathan Guse
d59431691c Merge remote-tracking branch 'remotes/nickv/ticket/11201' into develop
# By Joas Schilling
# Via Joas Schilling
* remotes/nickv/ticket/11201:
  [ticket/11201] Remove database column on update
  [ticket/11201] Remove MSN/WLM fields
2013-01-15 18:54:11 -06:00
Joas Schilling
460470229d [ticket/11201] Remove database column on update
PHPBB3-11201
2013-01-16 01:08:34 +01:00
Vjacheslav Trushkin
107a9016f1 [ticket/10431] Remove .left class from reply-all
Remove .left class from .reply-all button

PHPBB3-10431
2013-01-16 00:09:10 +02:00
Vjacheslav Trushkin
74b09c01ff [ticket/10431] Remove reply-all custom css
Remove CSS for reply-all button that is no longer used

PHPBB3-10431
2013-01-16 00:03:17 +02:00
Vjacheslav Trushkin
63b037b4bd [ticket/10431] Adjustments for large buttons
Changing CSS for large buttons to display better on Mac browsers.
Fixing tabs.

PHPBB3-10431
2013-01-15 23:12:44 +02:00
Nathan Guse
a2f6e494f3 Merge remote-tracking branch 'remotes/brunoais/ticket/11171' into develop
# By Bruno Ais
# Via Bruno Ais
* remotes/brunoais/ticket/11171:
  [ticket/11171] Moved the DB schema changes to its place
  [ticket/11171] Cleanup of leftovers
  [ticket/11171] Adapted the code in report.php
  [ticket/11171] Use the options stored to decide how to show it
  [ticket/11171] DB changes for the update
  [ticket/11171] DB additions for these changes

Conflicts:
	phpBB/install/schemas/firebird_schema.sql
	phpBB/install/schemas/mssql_schema.sql
	phpBB/install/schemas/mysql_40_schema.sql
	phpBB/install/schemas/mysql_41_schema.sql
	phpBB/install/schemas/oracle_schema.sql
	phpBB/install/schemas/postgres_schema.sql
	phpBB/install/schemas/sqlite_schema.sql
2013-01-14 12:16:59 -06:00
Oleg Pudeyev
62279d46a6 Merge PR #1194 branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/11323] Add tests for inclusion of defined variables
2013-01-13 20:13:17 -05:00
Oleg Pudeyev
227f7f46df Merge PR #1194 branch 'marc1706/ticket/11323' into develop-olympus
# By Marc Alexander
# Via Marc Alexander
* marc1706/ticket/11323:
  [ticket/11323] Add tests for inclusion of defined variables
2013-01-13 20:11:31 -05:00
Marc Alexander
4c50a35b62 [ticket/11323] Add tests for inclusion of defined variables
This adds 2 tests for the template engine. The test using
include_define_variable.html will test if a defined variable, which was
defined with another template variable, can be used to include a file.
The second test will do the same inside a loop using a loop variable.

PHPBB3-11323
2013-01-14 01:14:29 +01:00
Oleg Pudeyev
56e6d0531b Merge PR #1191 branch 'develop-olympus' into develop
# By Andreas Fischer
# Via Andreas Fischer (1) and Oleg Pudeyev (1)
* develop-olympus:
  [ticket/11324] Add PHP 5.5 environment to travis and allow it to fail.
2013-01-13 18:14:41 -05:00
Oleg Pudeyev
0b0b5e15c3 Merge PR #1191 branch 'bantu/ticket/11324' into develop-olympus
# By Andreas Fischer
# Via Andreas Fischer
* bantu/ticket/11324:
  [ticket/11324] Add PHP 5.5 environment to travis and allow it to fail.
2013-01-13 18:14:39 -05:00
Andreas Fischer
405a1a1793 Merge remote-tracking branch 'EXreaction/ticket/11320' into develop
* EXreaction/ticket/11320:
  [ticket/11320] Include functions file as we need phpbb_convert_30_dbms_to_31
2013-01-13 23:58:29 +01:00
Andreas Fischer
4001410c8c [ticket/11324] Add PHP 5.5 environment to travis and allow it to fail.
PHPBB3-11324
2013-01-13 23:41:40 +01:00
Joas Schilling
9affd6f7e7 [ticket/11201] Remove MSN/WLM fields
WLM will be shutdown in March 2013. Skype is the new replacement. But as Skype
uses a different login ID and service, the values in this field are useless.
So we can safely remove the field and the links/functions we create.

PHPBB3-11201
2013-01-11 14:32:44 +01:00
Andreas Fischer
6702a11dcb Merge remote-tracking branch 'nickvergessen/ticket/11321' into develop
* nickvergessen/ticket/11321:
  [ticket/11321] Recreate schema files with develop/create_schema_files.php
2013-01-11 14:29:15 +01:00
Joas Schilling
032f172a07 [ticket/11321] Recreate schema files with develop/create_schema_files.php
PHPBB3-11321
2013-01-11 14:27:05 +01:00
Nathan Guse
71e07ecc47 [ticket/11320] Include functions file as we need phpbb_convert_30_dbms_to_31
PHPBB3-11320
2013-01-10 19:27:51 -06:00
Oleg Pudeyev
dc8d4dbf30 Merge PR #1181 branch 'marc1706/ticket/11313' into develop
# By Marc Alexander
# Via Marc Alexander
* marc1706/ticket/11313:
  [ticket/11313] Use correct object el instead of eel in alt_text callback
2013-01-09 20:32:48 -05:00
Oleg Pudeyev
0e9b7bcae9 Merge PR #1182 branch 'develop-olympus' into develop
# By Andreas Fischer
# Via Andreas Fischer (1) and Oleg Pudeyev (1)
* develop-olympus:
  [ticket/11301] Guidelines: Add spaces in front and after the / operator.
  [ticket/11301] Explicitly cast str offset to int to prevent E_NOTICE on 5.4.
2013-01-09 01:25:54 -05:00
Oleg Pudeyev
8b4e661904 Merge PR #1182 branch 'bantu/ticket/11301' into develop-olympus
# By Andreas Fischer
# Via Andreas Fischer
* bantu/ticket/11301:
  [ticket/11301] Guidelines: Add spaces in front and after the / operator.
  [ticket/11301] Explicitly cast str offset to int to prevent E_NOTICE on 5.4.
2013-01-09 01:25:44 -05:00
Marc Alexander
fbdd3170c9 [ticket/11313] Use correct object el instead of eel in alt_text callback
This typo was added by the PRs #860 and #1178. Only the object el exists
and is correct. Due to this the text of links using the alt_text callback
were not modified while executing the callback.

PHPBB3-11313
2013-01-08 23:35:39 +01:00
Andreas Fischer
41a07eedeb [ticket/11301] Guidelines: Add spaces in front and after the / operator.
PHPBB3-11301
2013-01-08 23:20:30 +01:00
Andreas Fischer
24befac7b4 [ticket/11301] Explicitly cast str offset to int to prevent E_NOTICE on 5.4.
PHPBB3-11301
2013-01-08 23:18:17 +01:00
Oleg Pudeyev
b96a2fce28 Merge PR #1178 branch 'marc1706/ticket/10949' into develop
# By Marc Alexander (2) and Callum Macrae (1)
# Via Marc Alexander
* marc1706/ticket/10949:
  [ticket/10949] Remove not needed comma
  [ticket/10949] Converted missing code to new JS coding guidelines
  [ticket/10949] Converted AJAX coding standards to new guidelines.
2013-01-08 16:36:35 -05:00
Andreas Fischer
ef8cc04dc8 Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/11292] Fix: Newlines removed in display of PM reports
2013-01-06 02:12:25 +01:00
Andreas Fischer
c8dd12e5f4 Merge remote-tracking branch 'gn36/ticket/11292' into develop-olympus
* gn36/ticket/11292:
  [ticket/11292] Fix: Newlines removed in display of PM reports
2013-01-06 02:11:10 +01:00
Andreas Fischer
b7bd657882 Merge remote-tracking branch 'marc1706/ticket/11311' into develop
* marc1706/ticket/11311:
  [ticket/11311] Include asset core.js in subsilver2 overall_footer.html
2013-01-06 01:47:42 +01:00
Marc Alexander
4773eb3583 [ticket/11311] Include asset core.js in subsilver2 overall_footer.html
Without the inclusion of core.js the timezone functions will not properly
work. They refer to phpbb which is defined in core.js.

PHPBB3-11311
2013-01-05 11:42:58 +01:00
Marc Alexander
be77194435 [ticket/10949] Remove not needed comma
This comma might actually cause issues in browser. Therefore remove it.

PHPBB3-10949
2013-01-05 11:40:41 +01:00
Oleg Pudeyev
df5cba46d9 Merge PR #1177 branch 'erikfrerejean/ticket/11309' into develop
# By Erik Frèrejean
# Via Erik Frèrejean
* erikfrerejean/ticket/11309:
  [ticket/11309] phpbb_extension_interface::disable_step correct docblock.
2013-01-04 18:52:08 -05:00
Erik Frèrejean
68baee4ce2 [ticket/11309] phpbb_extension_interface::disable_step correct docblock.
The `@return` documentation of the `phpbb_extension_interface::disable_step`
method states incorrect that the method returns null, as it returns
false or a state.

PHPBB3-11309
2013-01-04 23:59:34 +01:00
Marc Alexander
b5cc1ed683 [ticket/10949] Converted missing code to new JS coding guidelines
A few missing semi-colons were also added where needed.

PHPBB3-10949
2013-01-04 22:46:12 +01:00
Marc Alexander
46c33e08b5 Merge remote-tracking branch 'callumacrae/ticket/10949' into ticket/10949
Conflicts:
	phpBB/assets/javascript/core.js
2013-01-04 20:46:56 +01:00
Andreas Fischer
228580b674 Merge remote-tracking branch 'erikfrerejean/ticket/11283' into develop
* erikfrerejean/ticket/11283:
  [ticket/11283] Extension manager follow symlinks.
2013-01-03 04:10:04 +01:00
Oleg Pudeyev
300b8236eb Merge PR #1153 branch 'marc1706/ticket/10805' into develop
# By Marc Alexander
# Via Marc Alexander
* marc1706/ticket/10805:
  [ticket/10805] Compare phpbbAlertTimer against null
  [ticket/10805] Clear loading alert timeout after ajax request finished
2013-01-02 16:56:38 -05:00
Oleg Pudeyev
56a7dd2bd5 Merge PR #1176 branch 'marc1706/ticket/11302' into develop
# By Marc Alexander
# Via Marc Alexander
* marc1706/ticket/11302:
  [ticket/11302] Correctly select first timezone or selected timezone
2013-01-02 16:48:46 -05:00