Commit graph

11697 commits

Author SHA1 Message Date
Igor Wiedler
fd08cd8dd0 [feature/request-class] Remove $html_encode arg, force manual decoding
PHPBB3-9716
2011-08-18 23:19:48 +02:00
Igor Wiedler
b4ae124084 [feature/request-class] Do not html escape user agent in header_filename
PHPBB3-9716
2011-08-18 22:52:09 +02:00
Igor Wiedler
38c65da553 Merge branch 'develop' into feature/request-class
* develop: (157 commits)
  [ticket/10316] Resolve inconsistent move topic behavior
  [ticket/9297] Add network to class name of unit tests.
  [ticket/9297] Fix typo in localhost.
  [ticket/9297] Rename test class to reflect its contents.
  [ticket/9297] Adjust comment - IPv6 is needed for IPv6 connections to work.
  [ticket/9297] Fix markTestSkipped call in setUpBeforeClass.
  [ticket/9608] Remove use of references in topic_review
  [ticket/9297] Skip FTP PASV/EPSV test if FTP connection fails.
  [ticket/9297] Separate ipv4 and ipv6 tests into separate functions.
  [ticket/9297] Update copyright year of unit test file.
  [feature/template-engine] Delete _get_locator function.
  [feature/template-engine] Clean up template locator usage in bbcode.
  [ticket/9297] Make EPSV unit tests work without IPv6.
  [ticket/9297] Unit tests for ftp_fsock PASV and EPSV.
  [ticket/9297] Add support for Extended Passive Mode (EPSV) in ftp_fsock class.
  [ticket/10312] Un-check the shadow option while moving.
  [feature/template-engine] Need to call set_template on template.
  [feature/template-engine] Update installer for template engine changes.
  [feature/template-engine] Dependency inject locator into template.
  [feature/template-engine] Delete useless code from set_template.
  ...

Conflicts:
	phpBB/includes/functions.php
2011-08-18 22:31:25 +02:00
Igor Wiedler
f84460c710 [feature/request-class] Make use of the is_secure() method
PHPBB3-9716
2011-08-18 22:26:30 +02:00
Igor Wiedler
a48889fed8 [feature/request-class] Add is_secure method to request for HTTPS
PHPBB3-9716
2011-08-18 22:26:30 +02:00
Andreas Fischer
9589fbffe4 Merge remote-tracking branch 'erikfrerejean/ticket/10312' into develop
* erikfrerejean/ticket/10312:
  [ticket/10312] Un-check the shadow option while moving.
2011-08-16 18:36:22 +02:00
Andreas Fischer
04f03c5ff1 Merge remote-tracking branch 'erikfrerejean/ticket/10316' into develop
* erikfrerejean/ticket/10316:
  [ticket/10316] Resolve inconsistent move topic behavior
2011-08-16 18:35:21 +02:00
Andreas Fischer
7ae11e3727 Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/9976] Fix link to post when two posts have the same post_time.
2011-08-16 18:09:42 +02:00
Andreas Fischer
a91131c55e Merge remote-tracking branch 'p/ticket/9976' into develop-olympus
* p/ticket/9976:
  [ticket/9976] Fix link to post when two posts have the same post_time.
2011-08-16 18:09:21 +02:00
Erik Frèrejean
bf2b4a81d3 [ticket/10316] Resolve inconsistent move topic behavior
When moving a topic you can straight away lock it, when using proSilver
this checkbox is unchecked by default. subSilver2 however has this
checked.
Change subSilver2 to not check the box by default and behave as
proSilver does.

PHPBB3-10316
2011-08-15 14:05:34 +02:00
Oleg Pudeyev
5fa096aca4 Merge remote-tracking branch 'igorw/ticket/9608' into develop
* igorw/ticket/9608:
  [ticket/9608] Remove use of references in topic_review
  [ticket/9608] Revert changes to normalizer
  [ticket/9608] Remove blank line
  [ticket/9608] Remove use of references in captcha and other places
2011-08-14 19:24:27 -04:00
Oleg Pudeyev
5305f6a977 Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/9297] Add network to class name of unit tests.
  [ticket/9297] Fix typo in localhost.
  [ticket/9297] Rename test class to reflect its contents.
  [ticket/9297] Adjust comment - IPv6 is needed for IPv6 connections to work.
  [ticket/9297] Fix markTestSkipped call in setUpBeforeClass.
  [ticket/9297] Skip FTP PASV/EPSV test if FTP connection fails.
  [ticket/9297] Separate ipv4 and ipv6 tests into separate functions.
  [ticket/9297] Update copyright year of unit test file.
  [ticket/9297] Make EPSV unit tests work without IPv6.
  [ticket/9297] Unit tests for ftp_fsock PASV and EPSV.
  [ticket/9297] Add support for Extended Passive Mode (EPSV) in ftp_fsock class.
2011-08-14 15:52:11 -04:00
Oleg Pudeyev
a6dd3d0c65 Merge remote-tracking branch 'bantu/ticket/9297' into develop-olympus
* bantu/ticket/9297:
  [ticket/9297] Add network to class name of unit tests.
  [ticket/9297] Fix typo in localhost.
  [ticket/9297] Rename test class to reflect its contents.
  [ticket/9297] Adjust comment - IPv6 is needed for IPv6 connections to work.
  [ticket/9297] Fix markTestSkipped call in setUpBeforeClass.
  [ticket/9297] Skip FTP PASV/EPSV test if FTP connection fails.
  [ticket/9297] Separate ipv4 and ipv6 tests into separate functions.
  [ticket/9297] Update copyright year of unit test file.
  [ticket/9297] Make EPSV unit tests work without IPv6.
  [ticket/9297] Unit tests for ftp_fsock PASV and EPSV.
  [ticket/9297] Add support for Extended Passive Mode (EPSV) in ftp_fsock class.
2011-08-14 15:52:01 -04:00
Andreas Fischer
02a8cebd65 [ticket/9297] Add network to class name of unit tests.
PHPBB3-9297
2011-08-14 21:40:02 +02:00
Andreas Fischer
702985c927 [ticket/9297] Fix typo in localhost.
PHPBB3-9297
2011-08-14 20:55:21 +02:00
Oleg Pudeyev
a7e709d920 [ticket/9297] Rename test class to reflect its contents.
setUpBeforeClass logic makes this test specific to PASV/EPSV tests.

PHPBB3-9297
2011-08-14 14:47:16 -04:00
Oleg Pudeyev
2a0c9e4026 [ticket/9297] Adjust comment - IPv6 is needed for IPv6 connections to work.
Looks like IPv6-encapsulated IPv4 addresses do not actually work if
the host has no IPv6 connectivity.

PHPBB3-9297
2011-08-14 14:42:53 -04:00
Oleg Pudeyev
c211492092 [ticket/9297] Fix markTestSkipped call in setUpBeforeClass.
Need to use the static version here.

PHPBB3-9297
2011-08-14 14:33:00 -04:00
Igor Wiedler
749ab6547d [ticket/9608] Remove use of references in topic_review
PHPBB3-9608
2011-08-14 20:22:28 +02:00
Oleg Pudeyev
2973ccbd48 [ticket/9297] Skip FTP PASV/EPSV test if FTP connection fails.
It is possible to configure PHP without IPv6, in which case
IPv6-encapsulated IPv4 addresses won't be accepted by PHP.
Instead of failing the test suite on such setups, skip the
offending test.

PHPBB3-9297
2011-08-14 14:11:58 -04:00
Oleg Pudeyev
386883cda1 [ticket/9297] Separate ipv4 and ipv6 tests into separate functions.
PHPBB3-9297
2011-08-14 13:19:09 -04:00
Andreas Fischer
7a40ab8f7a [ticket/9297] Update copyright year of unit test file.
PHPBB3-9297
2011-08-14 18:17:16 +02:00
Nils Adermann
6fa83ba876 Merge remote-tracking branch 'github-p/feature/template-engine' into develop
* github-p/feature/template-engine: (87 commits)
  [feature/template-engine] Delete _get_locator function.
  [feature/template-engine] Clean up template locator usage in bbcode.
  [feature/template-engine] Need to call set_template on template.
  [feature/template-engine] Update installer for template engine changes.
  [feature/template-engine] Dependency inject locator into template.
  [feature/template-engine] Delete useless code from set_template.
  [feature/template-engine] Delete no longer used $template_filename property.
  [feature/template-engine] Delete useless $template globalization.
  [feature/template-engine] Use template engine class in bbcode class.
  [feature/template-engine] Corrected an error message in template locator.
  [feature/template-engine] Remaining documentation.
  [feature/template-engine] More documentation for template class.
  [feature/template-engine] Create load_and_render to reduce code duplication.
  [feature/template-engine] Get rid of orig_tpl_* in template engine.
  [feature/template-engine] Delete $style_name param from locator's set_custom_template.
  [feature/template-engine] Add constructor to template locator.
  [feature/template-engine] Factor template locator out of template class.
  [feature/template-engine] Delete $files_template property.
  [feature/template-engine] Rename is_absolute to phpbb_is_absolute.
  [feature/template-engine] Test template DEFINE statements across files
  ...

Conflicts:
	.gitignore
	phpBB/includes/template.php
2011-08-13 23:59:15 -04:00
Oleg Pudeyev
41de09e408 [feature/template-engine] Delete _get_locator function.
It is no longer needed as locator is injected into template.

PHPBB3-9726
2011-08-13 23:49:54 -04:00
Oleg Pudeyev
7cfd4052c5 [feature/template-engine] Clean up template locator usage in bbcode.
PHPBB3-9726
2011-08-13 23:49:54 -04:00
Andreas Fischer
83fa6cffc3 [ticket/9297] Make EPSV unit tests work without IPv6.
PHPBB3-9297
2011-08-11 23:15:33 +02:00
Andreas Fischer
18f19b03ab [ticket/9297] Unit tests for ftp_fsock PASV and EPSV.
PHPBB3-9297
2011-08-11 23:15:33 +02:00
Andreas Fischer
66553fb857 [ticket/9297] Add support for Extended Passive Mode (EPSV) in ftp_fsock class.
PHPBB3-9297
2011-08-11 23:15:25 +02:00
Erik Frèrejean
e9c4370444 [ticket/10312] Un-check the shadow option while moving.
Don't create a shadow topic by default when moving a topic
the user should have the option to do this but it shouldn't
be done by default.

PHPBB3-10312
2011-08-10 14:42:05 +02:00
Oleg Pudeyev
fb8a1d999f [feature/template-engine] Need to call set_template on template.
PHPBB3-9726
2011-08-09 23:33:47 -04:00
Oleg Pudeyev
60372b43c2 [feature/template-engine] Update installer for template engine changes.
PHPBB3-9726
2011-08-09 23:28:56 -04:00
Oleg Pudeyev
acb767f14d [feature/template-engine] Dependency inject locator into template.
PHPBB3-9726
2011-08-09 23:28:40 -04:00
Oleg Pudeyev
66232035aa [feature/template-engine] Delete useless code from set_template.
set_custom_template performs these calls, repeating them in
set_template is not needed.

PHPBB3-9726
2011-08-09 23:20:54 -04:00
Oleg Pudeyev
4bb56cddb3 [feature/template-engine] Delete no longer used $template_filename property.
PHPBB3-9726
2011-08-09 23:18:58 -04:00
Oleg Pudeyev
035a8d7154 [feature/template-engine] Delete useless $template globalization.
PHPBB3-9726
2011-08-09 23:18:37 -04:00
Oleg Pudeyev
4754e11d67 Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/10240] Added code to strip control characters from messages.
2011-08-09 21:33:36 -04:00
Oleg Pudeyev
cad3e4cb45 Merge remote-tracking branch 'callumacrae/ticket/10240' into develop-olympus
* callumacrae/ticket/10240:
  [ticket/10240] Added code to strip control characters from messages.
2011-08-09 21:30:37 -04:00
Callum Macrae
f9dbe33fa7 [ticket/10240] Added code to strip control characters from messages.
It is possible to evade the word filter using control characters.

Seeing as control characters have no practical application in a bulletin
board software, it doesn't do any harm to remove them entirely. That is
what this commit does.

PHPBB3-10240
2011-08-08 17:43:28 +01:00
Igor Wiedler
11d20e0ec4 [ticket/9608] Revert changes to normalizer
They were breaking the tests.

PHPBB3-9608
2011-08-08 08:58:52 +02:00
Nils Adermann
55e4dfd3bd Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/10313] Create a separate build task for slow tests.
2011-08-07 21:34:46 -04:00
Nils Adermann
b85cd7a431 Merge branch 'ticket/naderman/10313' into develop-olympus
* ticket/naderman/10313:
  [ticket/10313] Create a separate build task for slow tests.
2011-08-07 21:34:24 -04:00
Nils Adermann
32e15315a8 [ticket/10313] Create a separate build task for slow tests.
PHPBB3-10313
2011-08-07 21:28:35 -04:00
Chris Smith
35b0badcf3 Merge branch 'task/naderman/whitelist-code-coverage' into develop
* task/naderman/whitelist-code-coverage:
  [task/whitelist-code-coverage] Load all of includes/ into code coverage report
2011-08-08 01:34:07 +01:00
Nils Adermann
c24249ae55 [task/whitelist-code-coverage] Load all of includes/ into code coverage report
PHPBB3-10314
2011-08-07 20:14:53 -04:00
Oleg Pudeyev
df46a576e9 [feature/template-engine] Use template engine class in bbcode class.
PHPBB3-9726
2011-08-07 19:26:28 -04:00
Nils Adermann
4c8c76171f Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/10313] Include slow unit tests when running build script.
2011-08-07 19:19:47 -04:00
Nils Adermann
abc0c336af Merge remote-tracking branch 'github-bantu/ticket/10313' into develop-olympus
* github-bantu/ticket/10313:
  [ticket/10313] Include slow unit tests when running build script.
2011-08-07 19:19:37 -04:00
Oleg Pudeyev
db257956aa [feature/template-engine] Corrected an error message in template locator.
PHPBB3-9726
2011-08-07 19:17:22 -04:00
Andreas Fischer
43fc8142f5 [ticket/10313] Include slow unit tests when running build script.
PHPBB3-10313
2011-08-08 01:11:44 +02:00
Oleg Pudeyev
f3befa4b29 [feature/template-engine] Remaining documentation.
PHPBB3-9726
2011-08-07 19:07:27 -04:00