phpbb/phpBB/includes
Andreas Fischer ee875c0a43 [ticket/10790] Remove a (kind of) dead code section from submit_pm().
The type of $user->data['user_id'] is (almost) guranteed to be integer
since session::session_create() casts it to integer.
The type of $row['user_id'] is only an integer if the DB driver adjusts the
PHP type according to the DB type. This is only done by some of our
not-so-popular DB drivers and is not the case for MySQL.

As such this comparison is (almost) never true and a PM is also sent to the
author itself when it is sent to a group the author is also a member of.

Since this behaviour seems to have been accepted by the communty, the dead
code is removed and current behaviour is kept.

Also, checking this in the loop seems to be a rather bad idea.

Introduced by 78b1c4caaa.

PHPBB3-10790
2012-05-22 02:24:31 +02:00
..
acm [ticket/10110] Remove multi-server syntax from Redis ACM. 2011-06-11 01:47:50 +02:00
acp [ticket/10846] fixing SQL query bug in acp_main.php 2012-04-30 22:01:53 +02:00
auth [ticket/10708] Check converted passwords for multi-byte characters 2012-03-19 23:19:21 -04:00
captcha [ticket/9892] Shorten the index names on the q&a captcha 2011-06-12 01:28:06 +02:00
db [ticket/10858] Move generic row seeking to DBAL 2012-05-08 19:41:22 -05:00
diff improve code to detect and solve conflicts for code removed from one version to another. 2009-09-20 16:20:20 +00:00
hooks - fixed database updater 2007-10-04 12:03:05 +00:00
mcp [ticket/10797] user rank is displayed in mcp_warn.php 2012-04-16 01:24:10 +05:30
questionnaire [Feature] Ability to use HTTP authentication in ATOM feeds by passing the GET parameter auth=http 2010-01-19 19:08:51 +00:00
search [ticket/9813] Only get posts table row count if we detected a fulltext index. 2012-03-08 14:38:59 +01:00
ucp [ticket/10561] Casted $config['default_style'] to int 2012-04-09 00:33:55 +05:30
utf - replaced the drop down menu log filter thing with log searching 2009-08-21 21:47:19 +00:00
.htaccess [ticket/9698] Add .htaccess to the includes subdirectory. 2010-10-15 16:47:21 +02:00
auth.php [ticket/10252] Correctly document behaviour of acl_get_list() for a_ permission 2011-07-15 10:23:06 +02:00
bbcode.php [ticket/8937] Keep space characters in front of [code] bbcode content 2011-07-17 00:44:39 -04:00
cache.php [ticket/9933] Move word censor regex into separate function in functions.php 2011-01-07 15:32:34 +01:00
constants.php [prep-release-3.0.10] Bumping version number for 3.0.10-RC3. 2011-12-04 00:22:10 +01:00
error_collector.php [ticket/10369] Rename filter_errfile() to filter_root_path(). 2011-09-18 22:32:25 +02:00
functions.php [ticket/10561] Moved and renamed the funtion validate_style(). 2012-04-05 19:31:18 +05:30
functions_admin.php Merge remote-tracking branch 'Noxwizard/ticket/10349' into develop-olympus 2011-12-03 22:07:34 -05:00
functions_compress.php [ticket/7296] Exporting styles to tar creates corrupted archives. 2010-08-22 11:16:19 -04:00
functions_content.php [ticket/10240] Reverted a commit which added buggy code. 2011-08-21 13:16:50 +01:00
functions_convert.php [ticket/10407] Fix check for empty image paths in convertor 2012-01-02 13:09:21 -05:00
functions_display.php Merge remote-tracking branch 'nickvergessen/ticket/10237' into develop-olympus 2011-11-11 22:07:11 +01:00
functions_install.php [ticket/10492] Separate config generation from the installer 2012-04-20 23:50:49 -05:00
functions_jabber.php Fix Jabber SASL PLAIN authentication failures. (Bug #52995) 2009-10-29 15:04:19 +00:00
functions_messenger.php [ticket/10538] Call htmlspecialchars_decode() on Jabber and SMTP passwords. 2011-12-19 14:24:39 +01:00
functions_module.php [Change] Alllow applications to set custom module inclusion path (idea by HoL) 2008-11-23 12:42:34 +00:00
functions_posting.php Merge remote-tracking branch 'Dickyf/ticket/10675' into develop-olympus 2012-03-31 19:27:19 +02:00
functions_privmsgs.php [ticket/10790] Remove a (kind of) dead code section from submit_pm(). 2012-05-22 02:24:31 +02:00
functions_profile_fields.php Merge remote-tracking branch 'rxu/ticket/9831' into develop-olympus 2012-03-09 05:24:03 -05:00
functions_template.php [ticket/10147] Corrected a typo in includes/functions_template.php. 2011-04-23 15:36:45 -04:00
functions_transfer.php [ticket/9297] Add support for Extended Passive Mode (EPSV) in ftp_fsock class. 2011-08-11 23:15:25 +02:00
functions_upload.php [ticket/9764] Allow $config['mime_triggers'] to be an empty string. 2010-10-28 22:00:04 +02:00
functions_user.php Merge branch 'ticket/10605' into develop-olympus 2012-05-14 00:38:54 +02:00
index.htm Add blank indexes to stop nosey people being, erm, nosey 2001-11-21 13:06:56 +00:00
message_parser.php [ticket/217] Silence errors in tests, not code. 2011-06-06 21:14:10 +08:00
session.php [ticket/10428] Documentation for optionget/optionset functions. 2011-12-25 01:51:32 -05:00
startup.php [task/php54] Disable E_STRICT in Olympus when running on PHP 5.4. 2012-03-15 22:47:42 -04:00
template.php [ticket/10145] Always recompile all templates when DEBUG_EXTRA is defined. 2011-04-26 12:35:44 +02:00